Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
Preserve decision settings when replacing disabled Ternary
Emre Sokullu8b90ee2b7f14
diff --git a/src/chrome/src/agent/decision-config.js b/src/chrome/src/agent/decision-config.jsindex 1ff9a4ef9..0666a9d38 100644--- a/src/chrome/src/agent/decision-config.js+++ b/src/chrome/src/agent/decision-config.js@@ -78,7 +78,7 @@ export function resolveDecisionConfig(stored = {}, compass = null, _options = {}const legacy = mode === 'on' && !DECISION_MODES.includes(stored[DECISION_MODE_KEY]);const on = mode === 'on';const config = selectedDecisionConfig(stored, mode === 'off' ? null : compass, on);- const features = mode === 'off' || config.provider === 'webgpu_chat' ? { ...NO_DECISION_FEATURES }+ const features = mode === 'off' ? { ...NO_DECISION_FEATURES }: on ? onDecisionFeatures(stored, config, legacy): config.provider === 'compass' ? { ...AUTO_COMPASS_FEATURES } : { ...NO_DECISION_FEATURES };const source = mode === 'off' ? 'off' : config.provider === 'compass' ? 'compass' : on ? 'configured' : 'none';@@ -122,7 +122,8 @@ function selectedDecisionConfig(stored, compass, on) {if (provider === 'webgpu_chat') return {provider, model: WEBGPU_CHAT_DECISION_MODEL, apiKey: '', baseUrl: '', url: '', local: true,enabled: false, unavailable: 'decision_validation_failed',- doneEnabled: false,+ // Preserve the legacy opt-in value for Settings; enabled gates every use.+ doneEnabled: stored.systemOneDoneEnabled === true,threshold: doneThreshold(stored),supportsVision: stored.decisionVisionMode !== 'off', experimental: true,requiresIndependentSuccessConfirmation: true,diff --git a/src/chrome/src/ui/settings.js b/src/chrome/src/ui/settings.jsindex a4ff73979..f762a33d8 100644--- a/src/chrome/src/ui/settings.js+++ b/src/chrome/src/ui/settings.js@@ -1788,6 +1788,7 @@ decisionProviderInput?.addEventListener('change', () => {document.getElementById('decision-models').replaceChildren();document.getElementById('decision-endpoint-field').hidden = previousDecisionProvider !== 'local';syncWebgpuDecisionProvider();+ void syncDecisionStatus();});decisionModelInput?.addEventListener('input', () => {decisionVisionSupported = decisionModels.find(m => m.id === decisionModelInput.value)?.supportsVision === true;diff --git a/test/systemone-ui.mjs b/test/systemone-ui.mjsindex f2c097ec7..c287dfc6b 100644--- a/test/systemone-ui.mjs+++ b/test/systemone-ui.mjs@@ -47,7 +47,8 @@ try {const errors = []; page.on('pageerror', error => errors.push(error.message));await page.addInitScript(({ lang, build, version }) => {localStorage.setItem('wbLocale', lang);- const data = { wbLocale: lang, typesafeApiKey: '', systemOneEnabled: false, systemOneWatchEnabled: true, systemOneCompletionEnabled: true };+ const data = { wbLocale: lang, typesafeApiKey: '', systemOneEnabled: false, systemOneWatchEnabled: true, systemOneCompletionEnabled: true,+ ...JSON.parse(sessionStorage.getItem('decision-profile') || '{}') };window.testStore = data; window.testRequests = [];const listeners = [];const storage = {@@ -198,6 +199,28 @@ try {if (build === 'chrome' && lang === 'en' && width === 1280 && process.env.JEV_DOC_SCREENSHOTS) {await captureDocScreenshots(page, process.env.JEV_DOC_SCREENSHOTS);}+ if (build === 'chrome') {+ const switches = { systemOneDoneEnabled: true, systemOneWatchEnabled: false, systemOneCompletionEnabled: true,+ systemOneFastClassifications: false, systemOneFastBrowser: true };+ await page.evaluate(switches => sessionStorage.setItem('decision-profile', JSON.stringify({+ decisionMode: 'on', systemOneEnabled: true, decisionProvider: 'webgpu_chat', ...switches,+ })), switches);+ await page.reload();+ await page.waitForFunction(() => document.querySelector('#decision-provider').value === 'webgpu_chat');+ assert.equal(await page.locator('#btn-test-system-one').isVisible(), false, 'saved Ternary cannot be tested');+ const ids = ['toggle-decision-done', 'toggle-system-one-watch', 'toggle-system-one-completion', 'toggle-system-one-classifications', 'toggle-system-one-browser'];+ for (const [i, value] of Object.values(switches).entries()) assert.equal(await page.locator(`#${ids[i]}`).isChecked(), value, 'saved Ternary retains switches');+ for (const provider of ['openrouter', 'typesafe', 'local']) {+ await page.locator('#decision-provider').selectOption(provider);+ assert.equal(await page.locator('#btn-test-system-one').isVisible(), true, `${provider} can be tested immediately`);+ await page.locator('#system-one-api-key').fill('synthetic-replacement-key');+ await page.locator('#btn-test-system-one').click();+ await page.waitForFunction(provider => testRequests.some(r => r.action === 'test_system_one' && r.settings?.decisionProvider === provider), provider);+ await page.locator('#btn-save-system-one').click();+ await page.waitForFunction(provider => testStore.decisionProvider === provider, provider);+ assert.deepEqual(await page.evaluate(keys => Object.fromEntries(keys.map(key => [key, testStore[key]])), Object.keys(switches)), switches);+ }+ }assert.equal(await page.evaluate(() => document.documentElement.scrollWidth <= innerWidth), true, 'settings fit viewport');assert.deepEqual(errors, []);await page.close(); console.log(`${build} ${lang} ${width}: settings save/test/clear passed`);diff --git a/test/webgpu-decisions.mjs b/test/webgpu-decisions.mjsindex 0eb8095a5..a05968d28 100644--- a/test/webgpu-decisions.mjs+++ b/test/webgpu-decisions.mjs@@ -150,6 +150,25 @@ test('saved Ternary decision selections stay local and disabled', async () => {}});+test('disabled Ternary keeps configured feature switches for a replacement provider', async () => {+ const { resolveDecisionConfig, decisionFeatureEnabled } = await import('../src/chrome/src/agent/decision-config.js');+ for (const mode of [{ decisionMode: 'on' }, {}]) {+ const stored = { ...mode, decisionProvider: 'webgpu_chat', systemOneEnabled: true,+ systemOneDoneEnabled: true, systemOneWatchEnabled: false, systemOneCompletionEnabled: true,+ systemOneFastClassifications: false, systemOneFastBrowser: true };+ const selected = resolveDecisionConfig(stored);+ assert.equal(selected.enabled, false);+ assert.deepEqual(selected.features, { done: true, watch: false, completion: true, classifications: false, browser: true, semantic: true });+ for (const feature of Object.keys(selected.features)) assert.equal(decisionFeatureEnabled(selected, feature), false, feature);+ for (const provider of ['openrouter', 'typesafe', 'local']) {+ const replacement = resolveDecisionConfig({ ...stored, decisionProvider: provider });+ assert.deepEqual(replacement.features, selected.features, `${provider} keeps saved switches`);+ }+ }+ const legacy = resolveDecisionConfig({ decisionProvider: 'webgpu_chat', systemOneEnabled: true });+ assert.deepEqual(legacy.features, { done: false, watch: false, completion: false, classifications: false, browser: false, semantic: true });+});+test('Firefox never enables the Chrome-only chat-model provider and imports it with System One off', async () => {const config = await import('../src/firefox/src/agent/decision-config.js');const transfer = await import('../src/firefox/src/config-transfer.js');