Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix: verify Discord sends against authored text
Emre Sokullua21fce7ae607
diff --git a/src/chrome/src/agent/agent.js b/src/chrome/src/agent/agent.jsindex cf1be2486..39cf850c5 100644--- a/src/chrome/src/agent/agent.js+++ b/src/chrome/src/agent/agent.js@@ -23078,7 +23078,7 @@ Rules: no prose intro, no conclusion, no "this screenshot shows...", no layout dconst previouslySeenIds = new Set(observed.session.seenMessageIds);const outgoingVerified = verifiedState.snapshot.messages.some(message => (message.direction === 'outgoing'- && message.text === decision.text+ && (message.authoredText ?? message.text) === decision.text&& !previouslySeenIds.has(message.id))) || verifiedState.pendingDeliveryVerified === true;const deliveryVerified = outgoingVerified && verifiedState.session.pendingOutbound === null;diff --git a/src/firefox/src/agent/agent.js b/src/firefox/src/agent/agent.jsindex 982a3d465..a5b2433d2 100644--- a/src/firefox/src/agent/agent.js+++ b/src/firefox/src/agent/agent.js@@ -20821,7 +20821,7 @@ Rules: no prose intro, no conclusion, no "this screenshot shows...", no layout dconst previouslySeenIds = new Set(observed.session.seenMessageIds);const outgoingVerified = verifiedState.snapshot.messages.some(message => (message.direction === 'outgoing'- && message.text === decision.text+ && (message.authoredText ?? message.text) === decision.text&& !previouslySeenIds.has(message.id))) || verifiedState.pendingDeliveryVerified === true;const deliveryVerified = outgoingVerified && verifiedState.session.pendingOutbound === null;diff --git a/test/run.js b/test/run.jsindex d16f1c867..1f3b26be6 100644--- a/test/run.js+++ b/test/run.js@@ -6965,6 +6965,48 @@ test('chat workflow state survives worker restart and is durable before dispatchassert.equal(discordSent.chatWorkflow.newMessages[0].direction, 'unknown', `${AgentClass.name}: delivery verification must not claim the Discord message author`);assert.equal(discordSender.chatSessions.get(tabId)?.pendingOutbound, null, `${AgentClass.name}: default-avatar Discord send remained pending`);+ const discordPreviewSender = new AgentClass({});+ discordPreviewSender.conversations.set(tabId, [{ role: 'system', content: 'system' }]);+ discordPreviewSender.conversationIds.set(tabId, `conversation-discord-preview-${index}`);+ discordPreviewSender._persist = () => {};+ discordPreviewSender._persistNow = async () => true;+ discordPreviewSender._messageRecipientGuardBlock = async () => null;+ const discordPreviewThreadKey = 'dom:discord:123:789';+ const discordPreviewBefore = {+ ...baseSnapshot,+ threadKey: discordPreviewThreadKey,+ url: 'https://discord.com/channels/123/789',+ observedAt: new Date().toISOString(),+ composer: { ...baseSnapshot.composer, ref: `composer-preview-${index}` },+ };+ let discordPreviewAfter;+ const discordPreviewObservations = [discordPreviewBefore];+ discordPreviewSender._readChatObservation = async () => discordPreviewObservations.shift() || discordPreviewAfter;+ discordPreviewSender.executeTool = async () => {+ const observedAt = new Date().toISOString();+ discordPreviewAfter = {+ ...discordPreviewBefore,+ observedAt,+ messages: [{+ id: `discord:789:preview-${index}`,+ direction: 'outgoing',+ text: 'https://example.com/release\nAttachment: Release notes\nAttachment: Preview description',+ authoredText: 'https://example.com/release',+ timestamp: observedAt,+ }],+ };+ return { success: true, dispatched: true };+ };+ const discordPreviewSent = await discordPreviewSender._sendChatWorkflow(tabId, {+ thread_key: discordPreviewThreadKey,+ composer_ref: `composer-preview-${index}`,+ text: 'https://example.com/release',+ });+ assert.equal(discordPreviewSent.success, true, `${AgentClass.name}: outgoing URL bubble with preview did not report send success`);+ assert.equal(discordPreviewSent.sent, true, `${AgentClass.name}: outgoing URL bubble with preview was not reported as sent`);+ assert.equal(discordPreviewSent.deliveryVerified, true, `${AgentClass.name}: authored URL was not used for final delivery verification`);+ assert.equal(discordPreviewSender.chatSessions.get(tabId)?.pendingOutbound, null, `${AgentClass.name}: previewed URL send remained pending`);+const nondurableMarkerSender = new AgentClass({});nondurableMarkerSender.conversations.set(tabId, [{ role: 'system', content: 'system' }]);nondurableMarkerSender.conversationIds.set(tabId, `conversation-discord-nondurable-${index}`);