Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

Propagate Stop from pending traversal settling

Claudea95b46b97734
diff --git a/src/chrome/src/agent/page-feedback.js b/src/chrome/src/agent/page-feedback.js
index 338551e57..10e63dfbe 100644
--- a/src/chrome/src/agent/page-feedback.js
+++ b/src/chrome/src/agent/page-feedback.js
@@ -1548,7 +1548,8 @@ export const pageFeedbackMethods = {
if (!run || this._checkAbort(tabId)) return false;
// A Back/Forward reading still pending can withdraw an observation (a
// page's own Back after an agent click); only what remains is applied.
- try { await this._pageFeedbackTraversalSettled(run, this._runAbortSignal(tabId)); } catch { return false; }
+ // Stop must propagate; only a non-abort settlement failure is skipped here.
+ try { await this._pageFeedbackTraversalSettled(run, this._runAbortSignal(tabId)); } catch (error) { this._throwIfAborted(this._runAbortSignal(tabId)); return false; }
if (this._pageFeedbackRuns?.get(tabId) !== run || this._checkAbort(tabId) || !run.events.size) return false;
const events = [...run.events.values()], batchRevision = run.revision;
const state = run.modelState || { token: run.token, url: run.latestPage?.url || run.url,
diff --git a/src/firefox/src/agent/page-feedback.js b/src/firefox/src/agent/page-feedback.js
index 338551e57..10e63dfbe 100644
--- a/src/firefox/src/agent/page-feedback.js
+++ b/src/firefox/src/agent/page-feedback.js
@@ -1548,7 +1548,8 @@ export const pageFeedbackMethods = {
if (!run || this._checkAbort(tabId)) return false;
// A Back/Forward reading still pending can withdraw an observation (a
// page's own Back after an agent click); only what remains is applied.
- try { await this._pageFeedbackTraversalSettled(run, this._runAbortSignal(tabId)); } catch { return false; }
+ // Stop must propagate; only a non-abort settlement failure is skipped here.
+ try { await this._pageFeedbackTraversalSettled(run, this._runAbortSignal(tabId)); } catch (error) { this._throwIfAborted(this._runAbortSignal(tabId)); return false; }
if (this._pageFeedbackRuns?.get(tabId) !== run || this._checkAbort(tabId) || !run.events.size) return false;
const events = [...run.events.values()], batchRevision = run.revision;
const state = run.modelState || { token: run.token, url: run.latestPage?.url || run.url,
diff --git a/test/feedback-navigation-idle.mjs b/test/feedback-navigation-idle.mjs
index c17a8cd4d..24aaac145 100644
--- a/test/feedback-navigation-idle.mjs
+++ b/test/feedback-navigation-idle.mjs
@@ -277,6 +277,25 @@ for (const build of ['chrome', 'firefox']) {
} finally { api.tabs.sendMessage = previous; urls.delete(tab); agent._releaseRunEntry(tab); }
});
+ test(`${build}: Stop during a pending traversal reading rejects instead of returning an ordinary result`, async () => {
+ const agent = makeAgent(Agent), tab = nextTab++, previous = api.tabs.sendMessage;
+ api.tabs.sendMessage = async (id, message, options) => message.action === 'page_monitor_traversal'
+ ? new Promise(() => {})
+ : previous(id, message, options);
+ try {
+ await agent._claimRunEntry(tab, 'interactive');
+ const send = bindMain(agent, tab);
+ send({ kind: 'activity', source: 'agent', operation: 'click' });
+ send({ kind: 'click', source: 'user', target: 'button#menu' });
+ navigate(agent, tab, 0, 'history', 'https://app.example/pending', { transitionQualifiers: ['forward_back'] });
+ agent._pageFeedbackIdleMs = 0;
+ const waiting = agent._applyPendingPageFeedback(tab, [], () => {});
+ await new Promise(resolve => setTimeout(resolve, 20));
+ agent.abort(tab);
+ await assert.rejects(waiting, { name: 'AbortError' });
+ } finally { api.tabs.sendMessage = previous; agent._releaseRunEntry(tab); }
+ });
+
test(`${build}: a traversal reading cannot outlive its run or hold Stop`, async () => {
const agent = makeAgent(Agent), tab = nextTab++, previous = api.tabs.sendMessage;
let answer;