Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

fix(skills, security): await strict secret hydration, reparse skill tools on edit, and fork built-in edits

Emre Sokullub2aef990eb97
diff --git a/src/chrome/src/background.js b/src/chrome/src/background.js
index 551030533..385375ab0 100644
--- a/src/chrome/src/background.js
+++ b/src/chrome/src/background.js
@@ -569,7 +569,7 @@ async function loadStrictSecretMode() {
const stored = await chrome.storage.local.get('strictSecretMode');
agent.strictSecretMode = stored.strictSecretMode !== false;
}
-loadStrictSecretMode();
+const strictSecretModeReady = loadStrictSecretMode().catch(() => {});
async function loadWebMCPEnabled() {
const stored = await chrome.storage.local.get('webMcpEnabled');
@@ -2816,6 +2816,7 @@ async function handleMessage(msg, sender) {
// storage round-trip on every message.
await Promise.all([planBeforeActReady, planReviewReady, customSkillsReady, userMemoryReady]);
await alwaysAllowApiMutationsReady;
+ await strictSecretModeReady;
await webMcpEnabledReady;
await screenshotRedactionReady;
await imageBudgetReady;
diff --git a/src/chrome/src/ui/settings.js b/src/chrome/src/ui/settings.js
index 0a97a29b2..9a69581b2 100644
--- a/src/chrome/src/ui/settings.js
+++ b/src/chrome/src/ui/settings.js
@@ -1317,10 +1317,14 @@ async function addSkillFromText() {
cancelSkillEdit();
throw new Error(t('st.skills.error.add_failed'));
}
+ const isBuiltIn = original.sourceType === 'built-in';
const updated = {
- ...original,
+ id: original.id,
name: (skillNameInput?.value || '').trim() || original.name || '',
+ sourceType: isBuiltIn ? 'text' : (original.sourceType || 'text'),
+ sourceUrl: isBuiltIn ? '' : (original.sourceUrl || ''),
content,
+ createdAt: original.createdAt || Date.now(),
};
const next = customSkills.map((s) => (s.id === editingSkillId ? updated : s));
await saveCustomSkills(next);
diff --git a/src/firefox/src/background.js b/src/firefox/src/background.js
index 426ba9d16..e3c059a57 100644
--- a/src/firefox/src/background.js
+++ b/src/firefox/src/background.js
@@ -451,7 +451,7 @@ async function loadStrictSecretMode() {
const stored = await browser.storage.local.get('strictSecretMode');
agent.strictSecretMode = stored.strictSecretMode !== false;
}
-loadStrictSecretMode();
+const strictSecretModeReady = loadStrictSecretMode().catch(() => {});
async function loadProfile() {
const stored = await browser.storage.local.get(['profileEnabled', 'profileText']);
@@ -2447,6 +2447,7 @@ async function handleMessage(msg, sender) {
// onChanged keeps them in sync afterward.
await Promise.all([planBeforeActReady, planReviewReady, customSkillsReady, userMemoryReady]);
await alwaysAllowApiMutationsReady;
+ await strictSecretModeReady;
await screenshotRedactionReady;
await imageBudgetReady;
await researchEscalationReady;
diff --git a/src/firefox/src/ui/settings.js b/src/firefox/src/ui/settings.js
index d1da1d95d..fdb06b187 100644
--- a/src/firefox/src/ui/settings.js
+++ b/src/firefox/src/ui/settings.js
@@ -1079,10 +1079,14 @@ async function addSkillFromText() {
cancelSkillEdit();
throw new Error(t('st.skills.error.add_failed'));
}
+ const isBuiltIn = original.sourceType === 'built-in';
const updated = {
- ...original,
+ id: original.id,
name: (skillNameInput?.value || '').trim() || original.name || '',
+ sourceType: isBuiltIn ? 'text' : (original.sourceType || 'text'),
+ sourceUrl: isBuiltIn ? '' : (original.sourceUrl || ''),
content,
+ createdAt: original.createdAt || Date.now(),
};
const next = customSkills.map((s) => (s.id === editingSkillId ? updated : s));
await saveCustomSkills(next);