Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

fix(social-publish): enforce attachment set metadata

Barack Sokullub4fe931d6d55
diff --git a/src/chrome/src/agent/agent.js b/src/chrome/src/agent/agent.js
index b6c6888d4..59d41b1c9 100644
--- a/src/chrome/src/agent/agent.js
+++ b/src/chrome/src/agent/agent.js
@@ -3615,6 +3615,14 @@ export class Agent extends LoopDetector {
return true;
}
+ const hasRangeCardinality = parsed.isMinimumCount || parsed.isMaximumCount
+ || parsed.isImageMinimum || parsed.isImageMaximum
+ || parsed.isVideoMinimum || parsed.isVideoMaximum
+ || parsed.isGifMinimum || parsed.isGifMaximum;
+ if (!hasRangeCardinality && rawAttachments.length !== targetsToCheck.length) {
+ return false;
+ }
+
if (matchingAttachments.length < targetsToCheck.length) {
return false;
}
@@ -3656,7 +3664,7 @@ export class Agent extends LoopDetector {
const attachments = Array.isArray(record?.attachments)
? record.attachments
: (Array.isArray(record?.media) ? record.media : []);
- return attachments.some(attachment => (
+ return attachments.length > 0 && attachments.every(attachment => (
attachment && typeof attachment === 'object'
&& this._workflowMetadataValue(attachment.alt) === want
));
diff --git a/src/firefox/src/agent/agent.js b/src/firefox/src/agent/agent.js
index e72c891a0..2d2a560bb 100644
--- a/src/firefox/src/agent/agent.js
+++ b/src/firefox/src/agent/agent.js
@@ -3330,6 +3330,14 @@ export class Agent extends LoopDetector {
return true;
}
+ const hasRangeCardinality = parsed.isMinimumCount || parsed.isMaximumCount
+ || parsed.isImageMinimum || parsed.isImageMaximum
+ || parsed.isVideoMinimum || parsed.isVideoMaximum
+ || parsed.isGifMinimum || parsed.isGifMaximum;
+ if (!hasRangeCardinality && rawAttachments.length !== targetsToCheck.length) {
+ return false;
+ }
+
if (matchingAttachments.length < targetsToCheck.length) {
return false;
}
@@ -3371,7 +3379,7 @@ export class Agent extends LoopDetector {
const attachments = Array.isArray(record?.attachments)
? record.attachments
: (Array.isArray(record?.media) ? record.media : []);
- return attachments.some(attachment => (
+ return attachments.length > 0 && attachments.every(attachment => (
attachment && typeof attachment === 'object'
&& this._workflowMetadataValue(attachment.alt) === want
));
diff --git a/test/run.js b/test/run.js
index c1ffca4f1..be778764d 100644
--- a/test/run.js
+++ b/test/run.js
@@ -91457,6 +91457,24 @@ test('X and Bluesky same-route publication accepts only one new permalink with t
fixture.feedUrl,
submit,
), false, AgentClass.name + ': mismatched attachment alt text was accepted');
+ assert.equal(agent._workflowSocialPublishedAltTextObserved(
+ { value: 'Diagram' },
+ {
+ attachments: [
+ { type: 'image', src: 'https://example.test/a.png', alt: 'Diagram' },
+ { type: 'image', src: 'https://example.test/b.png', alt: 'Diagram' },
+ ],
+ },
+ ), true, AgentClass.name + ': shared alt text on every attachment was rejected');
+ assert.equal(agent._workflowSocialPublishedAltTextObserved(
+ { value: 'Diagram' },
+ {
+ attachments: [
+ { type: 'image', src: 'https://example.test/a.png', alt: 'Diagram' },
+ { type: 'image', src: 'https://example.test/b.png', alt: 'Other' },
+ ],
+ },
+ ), false, AgentClass.name + ': one matching alt text hid a mismatched attachment');
assert.equal(agent._workflowPublishedResourcePayloadMatch(
{
@@ -93035,6 +93053,18 @@ test('attachment verification matches specific attachment names without substrin
);
assert.equal(exactChartUrl, true, AgentClass.name + ': chart.png in URL should satisfy chart.png');
+ const exactChartWithExtra = agent._workflowSocialPublishedAttachmentObserved(
+ { value: 'chart.png' },
+ {
+ attachments: [
+ { type: 'image', src: 'https://pbs.twimg.com/media/chart.png' },
+ { type: 'image', src: 'https://pbs.twimg.com/media/stale.png' },
+ ],
+ }
+ );
+ assert.equal(exactChartWithExtra, false,
+ AgentClass.name + ': one named attachment should reject extra media');
+
const exactChartAlt = agent._workflowSocialPublishedAttachmentObserved(
{ value: 'chart.png' },
{ attachments: [{ type: 'image', src: 'https://pbs.twimg.com/media/random-id.jpg', alt: 'Uploaded chart.png' }] }