Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

fix(sidepanel): hide typed secrets from labels and refresh steps on locale change

Emre Sokullub8e1276652ed
diff --git a/src/chrome/src/ui/sidepanel.js b/src/chrome/src/ui/sidepanel.js
index 085df9d1d..9488f621d 100644
--- a/src/chrome/src/ui/sidepanel.js
+++ b/src/chrome/src/ui/sidepanel.js
@@ -2999,7 +2999,10 @@ function friendlyToolLabel(name, args) {
if ((name === 'click' || name === 'click_ax' || name === 'iframe_click') && args?.text) {
return t('tool.click.selector', { selector: truncate(args.text, 30) });
}
- if ((name === 'type_text' || name === 'type_ax' || name === 'set_field' || name === 'iframe_type') && args?.text) {
+ // NOTE: only type_text previews its text. type_ax / set_field / iframe_type
+ // are the preferred form-filling tools and routinely carry passwords, OTP
+ // codes, and API keys — never render their values in the always-visible label.
+ if (name === 'type_text' && args?.text) {
return t('tool.type_text.text', { text: truncate(args.text, 25) });
}
if (name === 'navigate' && args?.url) return t('tool.navigate.url', { url: truncate(args.url, 35) });
@@ -3025,6 +3028,46 @@ function friendlyToolLabel(name, args) {
return name || '';
}
+// Persisted step labels are plain textContent, so a later locale change would
+// otherwise leave old steps in the previous language (applyDOMTranslations only
+// touches data-i18n elements). Steps store their tool + args in dataset so the
+// locale-change handler can recompute them via refreshRenderedStepLabels().
+function safeLabelArgs(args) {
+ try {
+ return JSON.stringify(args ?? {});
+ } catch {
+ return '{}';
+ }
+}
+
+function refreshRenderedStepLabels(root) {
+ const scope = root || document;
+ scope.querySelectorAll('.step-item[data-tool] .step-label').forEach((labelEl) => {
+ const step = labelEl.closest('.step-item');
+ if (!step || step.dataset.labelSource === 'progress') return;
+ if (step.dataset.labelSource === 'done-terminal' && step.dataset.doneLabelKey) {
+ labelEl.textContent = String(t(step.dataset.doneLabelKey)).trim();
+ return;
+ }
+ let args = null;
+ try {
+ args = step.dataset.args ? JSON.parse(step.dataset.args) : null;
+ } catch {
+ args = null;
+ }
+ labelEl.textContent = friendlyToolLabel(step.dataset.tool || '', args);
+ });
+ scope.querySelectorAll('.step-details > .detail-label').forEach((el) => {
+ el.textContent = t('sp.step.input_label');
+ });
+ scope.querySelectorAll('.detail-result > .detail-label').forEach((el) => {
+ el.textContent = t('sp.step.result_label');
+ });
+ scope.querySelectorAll('.step-details-toggle').forEach((el) => {
+ el.textContent = t('sp.step.details');
+ });
+}
+
function formatScheduledTime(value) {
const ms = Date.parse(value || '');
if (!Number.isFinite(ms)) return t('sp.scheduled.time_unknown');
@@ -10837,6 +10880,8 @@ function appendCompactStep(toolName, args) {
}
const priorLabel = priorRejected.querySelector('.step-label');
if (priorLabel) priorLabel.textContent = friendlyToolLabel(toolName, args);
+ priorRejected.dataset.args = safeLabelArgs(args);
+ priorRejected.dataset.labelSource = 'friendly';
const priorDetails = priorRejected.nextElementSibling;
if (priorDetails?.classList?.contains('step-details')) {
const priorArgs = priorDetails.querySelector('.detail-args');
@@ -10850,6 +10895,8 @@ function appendCompactStep(toolName, args) {
const step = document.createElement('div');
step.className = 'step-item active';
step.dataset.tool = toolName;
+ step.dataset.args = safeLabelArgs(args);
+ step.dataset.labelSource = 'friendly';
const icon = document.createElement('span');
icon.className = 'step-icon spinning';
@@ -10891,6 +10938,7 @@ function updateActiveToolProgress(toolName, message) {
const active = findLastActiveCompactStep(toolName);
const label = active?.querySelector('.step-label');
if (label) label.textContent = message;
+ if (active) active.dataset.labelSource = 'progress';
}
function markLastStepDone(toolName, result) {
@@ -10921,6 +10969,8 @@ function markLastStepDone(toolName, result) {
? 'sp.tool.done.rejected'
: (failed ? 'sp.tool.done.failed' : 'sp.tool.done.completed');
label.textContent = String(t(key)).trim();
+ active.dataset.doneLabelKey = key;
+ active.dataset.labelSource = 'done-terminal';
}
}
@@ -14191,6 +14241,7 @@ document.addEventListener('wb-locale-changed', () => {
renderQueuedComposerMessages();
syncSelectionScopeUi();
refreshOpenMessageInfoRows();
+ refreshRenderedStepLabels();
void loadProviders();
});
diff --git a/src/firefox/src/ui/sidepanel.js b/src/firefox/src/ui/sidepanel.js
index 24e739442..f86c64803 100644
--- a/src/firefox/src/ui/sidepanel.js
+++ b/src/firefox/src/ui/sidepanel.js
@@ -2860,7 +2860,10 @@ function friendlyToolLabel(name, args) {
if ((name === 'click' || name === 'click_ax' || name === 'iframe_click') && args?.text) {
return t('tool.click.selector', { selector: truncate(args.text, 30) });
}
- if ((name === 'type_text' || name === 'type_ax' || name === 'set_field' || name === 'iframe_type') && args?.text) {
+ // NOTE: only type_text previews its text. type_ax / set_field / iframe_type
+ // are the preferred form-filling tools and routinely carry passwords, OTP
+ // codes, and API keys — never render their values in the always-visible label.
+ if (name === 'type_text' && args?.text) {
return t('tool.type_text.text', { text: truncate(args.text, 25) });
}
if (name === 'navigate' && args?.url) return t('tool.navigate.url', { url: truncate(args.url, 35) });
@@ -2886,6 +2889,46 @@ function friendlyToolLabel(name, args) {
return name || '';
}
+// Persisted step labels are plain textContent, so a later locale change would
+// otherwise leave old steps in the previous language (applyDOMTranslations only
+// touches data-i18n elements). Steps store their tool + args in dataset so the
+// locale-change handler can recompute them via refreshRenderedStepLabels().
+function safeLabelArgs(args) {
+ try {
+ return JSON.stringify(args ?? {});
+ } catch {
+ return '{}';
+ }
+}
+
+function refreshRenderedStepLabels(root) {
+ const scope = root || document;
+ scope.querySelectorAll('.step-item[data-tool] .step-label').forEach((labelEl) => {
+ const step = labelEl.closest('.step-item');
+ if (!step || step.dataset.labelSource === 'progress') return;
+ if (step.dataset.labelSource === 'done-terminal' && step.dataset.doneLabelKey) {
+ labelEl.textContent = String(t(step.dataset.doneLabelKey)).trim();
+ return;
+ }
+ let args = null;
+ try {
+ args = step.dataset.args ? JSON.parse(step.dataset.args) : null;
+ } catch {
+ args = null;
+ }
+ labelEl.textContent = friendlyToolLabel(step.dataset.tool || '', args);
+ });
+ scope.querySelectorAll('.step-details > .detail-label').forEach((el) => {
+ el.textContent = t('sp.step.input_label');
+ });
+ scope.querySelectorAll('.detail-result > .detail-label').forEach((el) => {
+ el.textContent = t('sp.step.result_label');
+ });
+ scope.querySelectorAll('.step-details-toggle').forEach((el) => {
+ el.textContent = t('sp.step.details');
+ });
+}
+
function formatScheduledTime(value) {
const ms = Date.parse(value || '');
if (!Number.isFinite(ms)) return t('sp.scheduled.time_unknown');
@@ -10447,6 +10490,8 @@ function appendCompactStep(toolName, args) {
}
const priorLabel = priorRejected.querySelector('.step-label');
if (priorLabel) priorLabel.textContent = friendlyToolLabel(toolName, args);
+ priorRejected.dataset.args = safeLabelArgs(args);
+ priorRejected.dataset.labelSource = 'friendly';
const priorDetails = priorRejected.nextElementSibling;
if (priorDetails?.classList?.contains('step-details')) {
const priorArgs = priorDetails.querySelector('.detail-args');
@@ -10460,6 +10505,8 @@ function appendCompactStep(toolName, args) {
const step = document.createElement('div');
step.className = 'step-item active';
step.dataset.tool = toolName;
+ step.dataset.args = safeLabelArgs(args);
+ step.dataset.labelSource = 'friendly';
const icon = document.createElement('span');
icon.className = 'step-icon spinning';
@@ -10501,6 +10548,7 @@ function updateActiveToolProgress(toolName, message) {
const active = findLastActiveCompactStep(toolName);
const label = active?.querySelector('.step-label');
if (label) label.textContent = message;
+ if (active) active.dataset.labelSource = 'progress';
}
function markLastStepDone(toolName, result) {
@@ -10531,6 +10579,8 @@ function markLastStepDone(toolName, result) {
? 'sp.tool.done.rejected'
: (failed ? 'sp.tool.done.failed' : 'sp.tool.done.completed');
label.textContent = String(t(key)).trim();
+ active.dataset.doneLabelKey = key;
+ active.dataset.labelSource = 'done-terminal';
}
}
@@ -13664,6 +13714,7 @@ document.addEventListener('wb-locale-changed', () => {
renderQueuedComposerMessages();
syncSelectionScopeUi();
refreshOpenMessageInfoRows();
+ refreshRenderedStepLabels();
void loadProviders();
});
diff --git a/test/run.js b/test/run.js
index 87063908f..dfd474654 100644
--- a/test/run.js
+++ b/test/run.js
@@ -45051,6 +45051,11 @@ test('sidepanel friendlyToolLabel localizes get_accessibility_tree and actions a
assert.match(panel, /get_shadow_dom:\s*['"]tool\.get_shadow_dom['"]/, `${label}: get_shadow_dom must keep its own discovery label`);
assert.match(panel, /shadow_dom_query:\s*['"]tool\.shadow_dom_query['"]/, `${label}: shadow_dom_query must keep its own query label`);
assert.match(panel, /gmail_count_results:\s*['"]tool\.gmail_count_results['"]/, `${label}: gmail_count_results must keep its own counting label`);
+ assert.doesNotMatch(panel, /name === 'type_ax'[^;]*?tool\.type_text\.text/, `${label}: type_ax must not preview typed text (credential exposure)`);
+ assert.doesNotMatch(panel, /name === 'set_field'[^;]*?tool\.type_text\.text/, `${label}: set_field must not preview typed text (credential exposure)`);
+ assert.match(panel, /function refreshRenderedStepLabels\(root\)/, `${label}: rendered step labels must be refreshable on locale change`);
+ assert.match(panel, /step\.dataset\.args = safeLabelArgs\(args\)/, `${label}: steps must persist label args for locale refresh`);
+ assert.match(panel, /refreshRenderedStepLabels\(\);/, `${label}: locale-change handler must refresh rendered step labels`);
}
});