Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

fix(sidepanel): refresh step labels after transcript restore

Emre Sokullubda48b6c53d0
diff --git a/src/chrome/src/ui/sidepanel.js b/src/chrome/src/ui/sidepanel.js
index a67de1026..413d23c3d 100644
--- a/src/chrome/src/ui/sidepanel.js
+++ b/src/chrome/src/ui/sidepanel.js
@@ -3049,11 +3049,15 @@ function refreshRenderedStepLabels(root) {
labelEl.textContent = String(t(step.dataset.doneLabelKey)).trim();
return;
}
+ // Legacy cached steps rendered before label metadata existed carry no
+ // dataset.args — leave their text untouched rather than recomputing with
+ // empty args (which would lose e.g. the original scroll direction).
+ if (!step.dataset.args) return;
let args = null;
try {
- args = step.dataset.args ? JSON.parse(step.dataset.args) : null;
+ args = JSON.parse(step.dataset.args);
} catch {
- args = null;
+ return;
}
labelEl.textContent = friendlyToolLabel(step.dataset.tool || '', args);
});
@@ -4688,6 +4692,7 @@ async function init() {
migrateLegacyEmptyStateFromRestoredChat(restoreTabId);
messagesEl.querySelectorAll('[data-bound]').forEach(el => delete el.dataset.bound);
rebindRestoredMessageControls();
+ refreshRenderedStepLabels();
}
}
} finally {
@@ -4872,6 +4877,7 @@ async function switchToTab(newTabId) {
migrateLegacyEmptyStateFromRestoredChat(newTabId);
messagesEl.querySelectorAll('[data-bound]').forEach(el => delete el.dataset.bound);
rebindRestoredMessageControls();
+ refreshRenderedStepLabels();
} else {
messagesEl.innerHTML = '';
syncProgressDisplayMode();
@@ -4919,6 +4925,7 @@ async function refreshVisibleSidePanelState() {
messagesEl.innerHTML = html;
messagesEl.querySelectorAll('[data-bound]').forEach(el => delete el.dataset.bound);
rebindRestoredMessageControls();
+ refreshRenderedStepLabels();
} else if (!html) {
messagesEl.innerHTML = '';
syncProgressDisplayMode();
diff --git a/src/firefox/src/ui/sidepanel.js b/src/firefox/src/ui/sidepanel.js
index f46e4da5a..9f0e88806 100644
--- a/src/firefox/src/ui/sidepanel.js
+++ b/src/firefox/src/ui/sidepanel.js
@@ -2910,11 +2910,15 @@ function refreshRenderedStepLabels(root) {
labelEl.textContent = String(t(step.dataset.doneLabelKey)).trim();
return;
}
+ // Legacy cached steps rendered before label metadata existed carry no
+ // dataset.args — leave their text untouched rather than recomputing with
+ // empty args (which would lose e.g. the original scroll direction).
+ if (!step.dataset.args) return;
let args = null;
try {
- args = step.dataset.args ? JSON.parse(step.dataset.args) : null;
+ args = JSON.parse(step.dataset.args);
} catch {
- args = null;
+ return;
}
labelEl.textContent = friendlyToolLabel(step.dataset.tool || '', args);
});
@@ -4544,6 +4548,7 @@ async function init() {
migrateLegacyEmptyStateFromRestoredChat(restoreTabId);
messagesEl.querySelectorAll('[data-bound]').forEach(el => delete el.dataset.bound);
rebindRestoredMessageControls();
+ refreshRenderedStepLabels();
}
}
} finally {
@@ -4729,6 +4734,7 @@ async function switchToTab(newTabId) {
migrateLegacyEmptyStateFromRestoredChat(newTabId);
messagesEl.querySelectorAll('[data-bound]').forEach(el => delete el.dataset.bound);
rebindRestoredMessageControls();
+ refreshRenderedStepLabels();
} else {
messagesEl.innerHTML = '';
syncProgressDisplayMode();
@@ -4775,6 +4781,7 @@ async function refreshVisibleSidePanelState() {
messagesEl.innerHTML = html;
messagesEl.querySelectorAll('[data-bound]').forEach(el => delete el.dataset.bound);
rebindRestoredMessageControls();
+ refreshRenderedStepLabels();
} else if (!html) {
messagesEl.innerHTML = '';
syncProgressDisplayMode();
diff --git a/test/run.js b/test/run.js
index 16bafbd6e..ec31c0d7e 100644
--- a/test/run.js
+++ b/test/run.js
@@ -45062,6 +45062,7 @@ test('sidepanel friendlyToolLabel localizes get_accessibility_tree and actions a
assert.match(panel, /function refreshRenderedStepLabels\(root\)/, `${label}: rendered step labels must be refreshable on locale change`);
assert.match(panel, /step\.dataset\.args = safeLabelArgs\(args\)/, `${label}: steps must persist label args for locale refresh`);
assert.match(panel, /refreshRenderedStepLabels\(\);/, `${label}: locale-change handler must refresh rendered step labels`);
+ assert.ok((panel.match(/refreshRenderedStepLabels\(\);/g) || []).length >= 4, `${label}: restored transcripts must refresh step labels on every restore path`);
}
});