Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix: harden large tab-chat image persistence
alectimison-makerc0dd7417a55b
diff --git a/src/chrome/src/ui/tab-chat-persistence.js b/src/chrome/src/ui/tab-chat-persistence.jsindex d219b52c2..281497973 100644--- a/src/chrome/src/ui/tab-chat-persistence.js+++ b/src/chrome/src/ui/tab-chat-persistence.js@@ -6,11 +6,94 @@ const TAB_CHAT_QUOTA_RETRY_BUDGET = 256 * 1024;export const TRANSPARENT_PIXEL_PNG_DATA_URL ='data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNkYPhfDwAChwGA60e6kgAAAABJRU5ErkJggg==';+const IMAGE_DATA_URL_PREFIX = 'data:image/';+const BASE64_DATA_URL_MARKER = ';base64,';++function asciiLowerCode(code) {+ return code >= 65 && code <= 90 ? code + 32 : code;+}++function matchesAsciiIgnoreCase(source, offset, expected) {+ if (offset + expected.length > source.length) return false;+ for (let i = 0; i < expected.length; i++) {+ if (asciiLowerCode(source.charCodeAt(offset + i))+ !== asciiLowerCode(expected.charCodeAt(i))) return false;+ }+ return true;+}++function isMimeTypeCode(code) {+ return (code >= 48 && code <= 57)+ || (code >= 65 && code <= 90)+ || (code >= 97 && code <= 122)+ || code === 43+ || code === 45+ || code === 46;+}++function isBase64Code(code) {+ return (code >= 48 && code <= 57)+ || (code >= 65 && code <= 90)+ || (code >= 97 && code <= 122)+ || code === 43+ || code === 47+ || code === 61;+}++function findImageDataUrl(source, start) {+ const firstCode = IMAGE_DATA_URL_PREFIX.charCodeAt(0);+ for (let index = start; index <= source.length - IMAGE_DATA_URL_PREFIX.length; index++) {+ if (asciiLowerCode(source.charCodeAt(index)) !== firstCode) continue;+ if (matchesAsciiIgnoreCase(source, index, IMAGE_DATA_URL_PREFIX)) return index;+ }+ return -1;+}++function imageDataPayloadEnd(source, marker) {+ let cursor = marker + IMAGE_DATA_URL_PREFIX.length;+ const mimeStart = cursor;+ while (cursor < source.length && isMimeTypeCode(source.charCodeAt(cursor))) cursor++;+ if (cursor === mimeStart) return -1;++ // Walk the short metadata section without applying a regexp to the image+ // bytes. A comma before `;base64,` means this is not a base64 data URL.+ while (cursor < source.length) {+ if (source.charCodeAt(cursor) === 44) return -1;+ if (matchesAsciiIgnoreCase(source, cursor, BASE64_DATA_URL_MARKER)) {+ cursor += BASE64_DATA_URL_MARKER.length;+ const payloadStart = cursor;+ while (cursor < source.length && isBase64Code(source.charCodeAt(cursor))) cursor++;+ return cursor > payloadStart ? cursor : -1;+ }+ cursor++;+ }+ return -1;+}+export function stripImagePayloadsForPersist(html) {- return String(html || '').replace(- /data:image\/[a-z0-9.+-]+(?:;[^,]*)?;base64,[a-z0-9+/=]+/gi,- TRANSPARENT_PIXEL_PNG_DATA_URL,- );+ const source = String(html || '');+ const chunks = [];+ let copyCursor = 0;+ let searchCursor = 0;+ let replaced = false;++ while (searchCursor < source.length) {+ const marker = findImageDataUrl(source, searchCursor);+ if (marker < 0) break;+ const end = imageDataPayloadEnd(source, marker);+ if (end < 0) {+ searchCursor = marker + IMAGE_DATA_URL_PREFIX.length;+ continue;+ }+ chunks.push(source.slice(copyCursor, marker), TRANSPARENT_PIXEL_PNG_DATA_URL);+ copyCursor = end;+ searchCursor = end;+ replaced = true;+ }++ if (!replaced) return source;+ chunks.push(source.slice(copyCursor));+ return chunks.join('');}function findHtmlTagEnd(source, start) {diff --git a/src/firefox/src/ui/tab-chat-persistence.js b/src/firefox/src/ui/tab-chat-persistence.jsindex ebb440884..d214620b9 100644--- a/src/firefox/src/ui/tab-chat-persistence.js+++ b/src/firefox/src/ui/tab-chat-persistence.js@@ -6,11 +6,94 @@ const TAB_CHAT_QUOTA_RETRY_BUDGET = 256 * 1024;export const TRANSPARENT_PIXEL_PNG_DATA_URL ='data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNkYPhfDwAChwGA60e6kgAAAABJRU5ErkJggg==';+const IMAGE_DATA_URL_PREFIX = 'data:image/';+const BASE64_DATA_URL_MARKER = ';base64,';++function asciiLowerCode(code) {+ return code >= 65 && code <= 90 ? code + 32 : code;+}++function matchesAsciiIgnoreCase(source, offset, expected) {+ if (offset + expected.length > source.length) return false;+ for (let i = 0; i < expected.length; i++) {+ if (asciiLowerCode(source.charCodeAt(offset + i))+ !== asciiLowerCode(expected.charCodeAt(i))) return false;+ }+ return true;+}++function isMimeTypeCode(code) {+ return (code >= 48 && code <= 57)+ || (code >= 65 && code <= 90)+ || (code >= 97 && code <= 122)+ || code === 43+ || code === 45+ || code === 46;+}++function isBase64Code(code) {+ return (code >= 48 && code <= 57)+ || (code >= 65 && code <= 90)+ || (code >= 97 && code <= 122)+ || code === 43+ || code === 47+ || code === 61;+}++function findImageDataUrl(source, start) {+ const firstCode = IMAGE_DATA_URL_PREFIX.charCodeAt(0);+ for (let index = start; index <= source.length - IMAGE_DATA_URL_PREFIX.length; index++) {+ if (asciiLowerCode(source.charCodeAt(index)) !== firstCode) continue;+ if (matchesAsciiIgnoreCase(source, index, IMAGE_DATA_URL_PREFIX)) return index;+ }+ return -1;+}++function imageDataPayloadEnd(source, marker) {+ let cursor = marker + IMAGE_DATA_URL_PREFIX.length;+ const mimeStart = cursor;+ while (cursor < source.length && isMimeTypeCode(source.charCodeAt(cursor))) cursor++;+ if (cursor === mimeStart) return -1;++ // Walk the short metadata section without applying a regexp to the image+ // bytes. A comma before `;base64,` means this is not a base64 data URL.+ while (cursor < source.length) {+ if (source.charCodeAt(cursor) === 44) return -1;+ if (matchesAsciiIgnoreCase(source, cursor, BASE64_DATA_URL_MARKER)) {+ cursor += BASE64_DATA_URL_MARKER.length;+ const payloadStart = cursor;+ while (cursor < source.length && isBase64Code(source.charCodeAt(cursor))) cursor++;+ return cursor > payloadStart ? cursor : -1;+ }+ cursor++;+ }+ return -1;+}+export function stripImagePayloadsForPersist(html) {- return String(html || '').replace(- /data:image\/[a-z0-9.+-]+(?:;[^,]*)?;base64,[a-z0-9+/=]+/gi,- TRANSPARENT_PIXEL_PNG_DATA_URL,- );+ const source = String(html || '');+ const chunks = [];+ let copyCursor = 0;+ let searchCursor = 0;+ let replaced = false;++ while (searchCursor < source.length) {+ const marker = findImageDataUrl(source, searchCursor);+ if (marker < 0) break;+ const end = imageDataPayloadEnd(source, marker);+ if (end < 0) {+ searchCursor = marker + IMAGE_DATA_URL_PREFIX.length;+ continue;+ }+ chunks.push(source.slice(copyCursor, marker), TRANSPARENT_PIXEL_PNG_DATA_URL);+ copyCursor = end;+ searchCursor = end;+ replaced = true;+ }++ if (!replaced) return source;+ chunks.push(source.slice(copyCursor));+ return chunks.join('');}function findHtmlTagEnd(source, start) {diff --git a/test/run.js b/test/run.jsindex 2ac3082db..bb153e84b 100644--- a/test/run.js+++ b/test/run.js@@ -43780,6 +43780,28 @@ test('tab-chat persistence recovers when several sub-threshold chats exceed the}});+test('tab-chat persistence strips large and mixed-case image data URLs without changing other data URLs', () => {+ const payload = 'A'.repeat(6 * 1024 * 1024);+ const input = [+ '<div>before</div>',+ `<img src="DATA:IMAGE/WEBP;charset=utf-8;BASE64,${payload}">`,+ '<img src="data:image/svg+xml,not-base64">',+ '<div>after</div>',+ ].join('');+ const expected = [+ '<div>before</div>',+ `<img src="${TabChatPersistenceCh.TRANSPARENT_PIXEL_PNG_DATA_URL}">`,+ '<img src="data:image/svg+xml,not-base64">',+ '<div>after</div>',+ ].join('');++ const chromeResult = TabChatPersistenceCh.stripImagePayloadsForPersist(input);+ const firefoxResult = TabChatPersistenceFx.stripImagePayloadsForPersist(input);+ assert.equal(chromeResult, expected, 'chrome: large image data URL was not compacted exactly');+ assert.equal(firefoxResult, expected, 'firefox: large image data URL was not compacted exactly');+ assert.equal(chromeResult, firefoxResult, 'chrome/firefox image compaction diverged');+});+test('tab-chat persistence never evicts other chats when shared quota remains exhausted', async () => {for (const [label, persistence] of [['chrome', TabChatPersistenceCh],