Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
feat(ui): support drag-and-drop attachments
alectimison-makerc4aaf9e2e4f8
diff --git a/package.json b/package.jsonindex 20078c7f2..91a661092 100644--- a/package.json+++ b/package.json@@ -5,8 +5,9 @@"private": true,"type": "module","scripts": {- "test": "node --test test/browser-dialogs.mjs && npm run test:firefox-bidi && npm run test:runtime-lifecycle && npm run test:provider-limits && npm run test:toolbar-guard && npm run test:pdf-read && npm run test:pdf-selection && npm run test:social-contract && npm run test:build-unpacked && node test/run.js && node test/selection-scope-restoration.mjs && node scripts/benchmark-offline-relevance.mjs && npm run test:security",+ "test": "node --test test/browser-dialogs.mjs && npm run test:firefox-bidi && npm run test:runtime-lifecycle && npm run test:provider-limits && npm run test:toolbar-guard && npm run test:pdf-read && npm run test:pdf-selection && npm run test:social-contract && npm run test:build-unpacked && npm run test:attachment-drop && node test/run.js && node test/selection-scope-restoration.mjs && node scripts/benchmark-offline-relevance.mjs && npm run test:security","test:provider-limits": "node test/provider-model-limits.mjs",+ "test:attachment-drop": "node test/attachment-drop.mjs","test:security": "node test/security/injection-corpus.mjs","test:toolbar-guard": "node test/rich-text-toolbar-guard.mjs","test:pdf-read": "node test/pdf-read.mjs",diff --git a/src/chrome/src/ui/attachment-drop.js b/src/chrome/src/ui/attachment-drop.jsnew file mode 100644index 000000000..5d4539ae2--- /dev/null+++ b/src/chrome/src/ui/attachment-drop.js@@ -0,0 +1,62 @@+const FILE_DRAG_TYPE = 'Files';++export function hasFileDragPayload(event) {+ const dataTransfer = event?.dataTransfer;+ if (!dataTransfer) return false;+ const types = Array.from(dataTransfer.types || [], String);+ return types.includes(FILE_DRAG_TYPE) || Number(dataTransfer.files?.length || 0) > 0;+}++export function installFileDropHandlers(target, onFiles) {+ if (!target?.addEventListener || typeof onFiles !== 'function') return () => {};++ let dragDepth = 0;+ const setDragOver = (active) => target.classList?.toggle?.('drag-over', active);+ const isFileEvent = (event) => hasFileDragPayload(event);++ const onDragEnter = (event) => {+ if (!isFileEvent(event)) return;+ event.preventDefault();+ if (event.relatedTarget && target.contains?.(event.relatedTarget)) return;+ dragDepth += 1;+ setDragOver(true);+ };++ const onDragOver = (event) => {+ if (!isFileEvent(event)) return;+ event.preventDefault();+ if (event.dataTransfer) event.dataTransfer.dropEffect = 'copy';+ setDragOver(true);+ };++ const onDragLeave = (event) => {+ if (!isFileEvent(event)) return;+ event.preventDefault();+ if (event.relatedTarget && target.contains?.(event.relatedTarget)) return;+ dragDepth = Math.max(0, dragDepth - 1);+ if (dragDepth === 0) setDragOver(false);+ };++ const onDrop = (event) => {+ if (!isFileEvent(event)) return;+ event.preventDefault();+ dragDepth = 0;+ setDragOver(false);+ const files = event.dataTransfer?.files;+ if (files?.length) onFiles(files);+ };++ target.addEventListener('dragenter', onDragEnter);+ target.addEventListener('dragover', onDragOver);+ target.addEventListener('dragleave', onDragLeave);+ target.addEventListener('drop', onDrop);++ return () => {+ target.removeEventListener?.('dragenter', onDragEnter);+ target.removeEventListener?.('dragover', onDragOver);+ target.removeEventListener?.('dragleave', onDragLeave);+ target.removeEventListener?.('drop', onDrop);+ dragDepth = 0;+ setDragOver(false);+ };+}diff --git a/src/chrome/src/ui/sidepanel.js b/src/chrome/src/ui/sidepanel.jsindex 0c4609de4..fe570abfd 100644--- a/src/chrome/src/ui/sidepanel.js+++ b/src/chrome/src/ui/sidepanel.js@@ -80,6 +80,7 @@ import {removeStagedScreenshots,saveStagedScreenshot,} from './staged-screenshot-store.js';+import { installFileDropHandlers } from './attachment-drop.js';const isStandaloneWindow = new URLSearchParams(window.location.search).get('standalone') === 'true';@@ -14038,6 +14039,10 @@ if (attachBtn && fileAttachInput) {});}+installFileDropHandlers(inputArea, (files) => {+ handleAttachedFiles(files, renderedTabId ?? currentTabId);+});+// --- Event Listeners ---ensureSelectionAskActionEl();diff --git a/src/chrome/styles/sidepanel.css b/src/chrome/styles/sidepanel.cssindex ed6ef1e72..c38e1a08b 100644--- a/src/chrome/styles/sidepanel.css+++ b/src/chrome/styles/sidepanel.css@@ -3217,6 +3217,11 @@ html[data-ui-scale="175"] .conversation-action-label {border-color: var(--accent);}+#input-area.drag-over #input-wrapper {+ border-color: var(--accent);+ box-shadow: 0 0 0 2px color-mix(in srgb, var(--accent) 24%, transparent);+}+#input-area.act-mode #input-wrapper {border-color: rgba(255, 152, 0, 0.3);}diff --git a/src/firefox/src/ui/attachment-drop.js b/src/firefox/src/ui/attachment-drop.jsnew file mode 100644index 000000000..5d4539ae2--- /dev/null+++ b/src/firefox/src/ui/attachment-drop.js@@ -0,0 +1,62 @@+const FILE_DRAG_TYPE = 'Files';++export function hasFileDragPayload(event) {+ const dataTransfer = event?.dataTransfer;+ if (!dataTransfer) return false;+ const types = Array.from(dataTransfer.types || [], String);+ return types.includes(FILE_DRAG_TYPE) || Number(dataTransfer.files?.length || 0) > 0;+}++export function installFileDropHandlers(target, onFiles) {+ if (!target?.addEventListener || typeof onFiles !== 'function') return () => {};++ let dragDepth = 0;+ const setDragOver = (active) => target.classList?.toggle?.('drag-over', active);+ const isFileEvent = (event) => hasFileDragPayload(event);++ const onDragEnter = (event) => {+ if (!isFileEvent(event)) return;+ event.preventDefault();+ if (event.relatedTarget && target.contains?.(event.relatedTarget)) return;+ dragDepth += 1;+ setDragOver(true);+ };++ const onDragOver = (event) => {+ if (!isFileEvent(event)) return;+ event.preventDefault();+ if (event.dataTransfer) event.dataTransfer.dropEffect = 'copy';+ setDragOver(true);+ };++ const onDragLeave = (event) => {+ if (!isFileEvent(event)) return;+ event.preventDefault();+ if (event.relatedTarget && target.contains?.(event.relatedTarget)) return;+ dragDepth = Math.max(0, dragDepth - 1);+ if (dragDepth === 0) setDragOver(false);+ };++ const onDrop = (event) => {+ if (!isFileEvent(event)) return;+ event.preventDefault();+ dragDepth = 0;+ setDragOver(false);+ const files = event.dataTransfer?.files;+ if (files?.length) onFiles(files);+ };++ target.addEventListener('dragenter', onDragEnter);+ target.addEventListener('dragover', onDragOver);+ target.addEventListener('dragleave', onDragLeave);+ target.addEventListener('drop', onDrop);++ return () => {+ target.removeEventListener?.('dragenter', onDragEnter);+ target.removeEventListener?.('dragover', onDragOver);+ target.removeEventListener?.('dragleave', onDragLeave);+ target.removeEventListener?.('drop', onDrop);+ dragDepth = 0;+ setDragOver(false);+ };+}diff --git a/src/firefox/src/ui/sidepanel.js b/src/firefox/src/ui/sidepanel.jsindex 40608c035..026d1ac2e 100644--- a/src/firefox/src/ui/sidepanel.js+++ b/src/firefox/src/ui/sidepanel.js@@ -84,6 +84,7 @@ import {removeStagedScreenshots,saveStagedScreenshot,} from './staged-screenshot-store.js';+import { installFileDropHandlers } from './attachment-drop.js';const isStandaloneWindow = new URLSearchParams(window.location.search).get('standalone') === 'true';@@ -13504,6 +13505,10 @@ if (attachBtn && fileAttachInput) {});}+installFileDropHandlers(inputArea, (files) => {+ handleAttachedFiles(files, currentTabId);+});+// --- Event Listeners ---ensureSelectionAskActionEl();diff --git a/src/firefox/styles/sidepanel.css b/src/firefox/styles/sidepanel.cssindex dfb26c28d..9f4860982 100644--- a/src/firefox/styles/sidepanel.css+++ b/src/firefox/styles/sidepanel.css@@ -3043,6 +3043,11 @@ html[data-ui-scale="175"] .conversation-action-label {border-color: var(--accent);}+#input-area.drag-over #input-wrapper {+ border-color: var(--accent);+ box-shadow: 0 0 0 2px color-mix(in srgb, var(--accent) 24%, transparent);+}+#input-area.act-mode #input-wrapper {border-color: rgba(255, 152, 0, 0.3);}diff --git a/test/attachment-drop.mjs b/test/attachment-drop.mjsnew file mode 100644index 000000000..fcf34c6ba--- /dev/null+++ b/test/attachment-drop.mjs@@ -0,0 +1,110 @@+import { strict as assert } from 'node:assert';++const implementations = [+ ['chrome', '../src/chrome/src/ui/attachment-drop.js'],+ ['firefox', '../src/firefox/src/ui/attachment-drop.js'],+];++function createTarget() {+ const listeners = new Map();+ const classes = new Set();+ return {+ classList: {+ toggle(name, force) {+ if (force) classes.add(name);+ else classes.delete(name);+ },+ contains(name) {+ return classes.has(name);+ },+ },+ addEventListener(type, listener) {+ const handlers = listeners.get(type) || [];+ handlers.push(listener);+ listeners.set(type, handlers);+ },+ removeEventListener(type, listener) {+ const handlers = listeners.get(type) || [];+ listeners.set(type, handlers.filter(candidate => candidate !== listener));+ },+ contains(node) {+ return node === this || node?.parentNode === this;+ },+ dispatch(type, dataTransfer, extra = {}) {+ const event = {+ type,+ dataTransfer,+ defaultPrevented: false,+ preventDefault() {+ this.defaultPrevented = true;+ },+ ...extra,+ };+ for (const listener of listeners.get(type) || []) listener(event);+ return event;+ },+ };+}++function transfer(types, files = []) {+ return { types, files, dropEffect: 'none' };+}++for (const [label, relativeModule] of implementations) {+ const module = await import(new URL(relativeModule, import.meta.url).href);++ assert.equal(+ module.hasFileDragPayload({ dataTransfer: transfer(['Files']) }),+ true,+ `${label}: Files drag payload should be recognized before drop`+ );+ assert.equal(+ module.hasFileDragPayload({ dataTransfer: transfer(['text/uri-list']) }),+ false,+ `${label}: URL drags should not be treated as attachments`+ );+ assert.equal(+ module.hasFileDragPayload({ dataTransfer: transfer([], [{ name: 'notes.txt' }]) }),+ true,+ `${label}: file-list fallback should recognize a drop with no exposed type`+ );++ const target = createTarget();+ const files = [{ name: 'notes.txt', type: 'text/plain' }];+ const received = [];+ const cleanup = module.installFileDropHandlers(target, droppedFiles => received.push(droppedFiles));++ const firstEnter = target.dispatch('dragenter', transfer(['Files']));+ assert.equal(firstEnter.defaultPrevented, true, `${label}: file dragenter should be consumed`);+ assert.equal(target.classList.contains('drag-over'), true, `${label}: dragenter should show drop feedback`);++ const child = { parentNode: target };+ target.dispatch('dragenter', transfer(['Files']), { relatedTarget: target });+ target.dispatch('dragleave', transfer(['Files']), { relatedTarget: child });+ assert.equal(target.classList.contains('drag-over'), true, `${label}: moving across composer children should keep feedback`);+ target.dispatch('dragleave', transfer(['Files']));+ assert.equal(target.classList.contains('drag-over'), false, `${label}: leaving the composer should clear nested feedback`);++ target.dispatch('dragenter', transfer(['Files']));++ const over = target.dispatch('dragover', transfer(['Files']));+ assert.equal(over.defaultPrevented, true, `${label}: file dragover should be consumed`);+ assert.equal(over.dataTransfer.dropEffect, 'copy', `${label}: file dragover should advertise copy behavior`);++ const drop = target.dispatch('drop', transfer(['Files'], files));+ assert.equal(drop.defaultPrevented, true, `${label}: file drop should be consumed`);+ assert.deepEqual(received, [files], `${label}: drop should forward the original file list`);+ assert.equal(target.classList.contains('drag-over'), false, `${label}: drop should clear feedback`);++ const nonFileOver = target.dispatch('dragover', transfer(['text/plain']));+ assert.equal(nonFileOver.defaultPrevented, false, `${label}: non-file dragover should remain untouched`);+ const nonFileDrop = target.dispatch('drop', transfer(['text/uri-list'], []));+ assert.equal(nonFileDrop.defaultPrevented, false, `${label}: non-file drop should remain untouched`);+ assert.deepEqual(received, [files], `${label}: non-file drops should not reach the attachment reader`);++ cleanup();+ target.dispatch('drop', transfer(['Files'], files));+ assert.deepEqual(received, [files], `${label}: cleanup should remove drop listeners`);+}++console.log('attachment drag-and-drop tests passed for Chrome and Firefox');