Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

Fix cloud clarification timeout state and deadline updates

Emre Sokullucc5679020da0
diff --git a/src/chrome/src/cloud-runs.js b/src/chrome/src/cloud-runs.js
index aa3017d35..68b72707c 100644
--- a/src/chrome/src/cloud-runs.js
+++ b/src/chrome/src/cloud-runs.js
@@ -955,6 +955,17 @@ export function createCloudRunController({
run.status = 'needs_user_input';
run.pendingInput = scrubbedData;
}
+ if (type === 'clarify_timeout_extended' && scrubbedData?.clarifyId
+ && (run.pendingInput?.clarifyId || run.pendingInput?.clarify_id) === scrubbedData.clarifyId
+ && run.status === 'needs_user_input' && Number(scrubbedData.deadlineTs) > 0) {
+ run.pendingInput = { ...run.pendingInput, deadlineTs: Number(scrubbedData.deadlineTs) };
+ }
+ if (type === 'clarify_auto' && scrubbedData?.clarifyId
+ && (run.pendingInput?.clarifyId || run.pendingInput?.clarify_id) === scrubbedData.clarifyId
+ && run.status === 'needs_user_input') {
+ run.status = 'running';
+ run.pendingInput = null;
+ }
if (type === 'run_status'
&& ['clarification_required', 'captcha_manual_required'].includes(scrubbedData?.status)
&& run.status !== 'aborting'
diff --git a/test/run.js b/test/run.js
index ab0e5e106..c2bfe3f49 100644
--- a/test/run.js
+++ b/test/run.js
@@ -26202,10 +26202,29 @@ test('cloud run controller pauses and resumes clarify, permission, and submit in
);
}
+ emitUpdate('clarify', { clarifyId: 'clr_expired', question: 'Complete the challenge?', deadlineTs: 1790000000000 });
+ assert.equal((await controller.status({ runId: 'run_input' })).status, 'needs_user_input');
+ emitUpdate('clarify_timeout_extended', { clarifyId: 'clr_expired', deadlineTs: 1790000060000 });
+ assert.equal((await controller.status({ runId: 'run_input' })).pendingInput.deadlineTs, 1790000060000);
+ emitUpdate('clarify_timeout_extended', { clarifyId: 'clr_other', deadlineTs: 1790000120000 });
+ assert.equal((await controller.status({ runId: 'run_input' })).pendingInput.deadlineTs, 1790000060000);
+ emitUpdate('clarify_auto', { clarifyId: 'clr_expired', source: 'timeout', answer: '(no response — timed out)' });
+ const expired = await controller.status({ runId: 'run_input' });
+ assert.equal(expired.status, 'running');
+ assert.equal(expired.pendingInput, null);
+ await assert.rejects(
+ () => controller.respond({ runId: 'run_input', clarifyId: 'clr_expired', answer: 'Continue' }),
+ /not waiting for user input/,
+ );
+ emitUpdate('clarify', { clarifyId: 'clr_replacement', question: 'Continue now?' });
+ assert.equal((await controller.status({ runId: 'run_input' })).pendingInput.clarifyId, 'clr_replacement');
+ await controller.respond({ runId: 'run_input', clarifyId: 'clr_replacement', answer: 'Continue' });
+
assert.deepEqual(submitted, [
[20, 'clr_general', 'Work', 'cloud_api'],
[20, 'perm_network', 'once', 'cloud_api'],
[20, 'submit_form', 'once', 'cloud_api'],
+ [20, 'clr_replacement', 'Continue', 'cloud_api'],
]);
finishRun('Done');
await new Promise(resolve => setTimeout(resolve, 0));