Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix: validate Discord guild transcript route
Emre Sokulluccb346369ad2
diff --git a/src/chrome/src/content/chat-observation.js b/src/chrome/src/content/chat-observation.jsindex 2cfc82aa4..cd49eeeb4 100644--- a/src/chrome/src/content/chat-observation.js+++ b/src/chrome/src/content/chat-observation.js@@ -167,25 +167,21 @@&& !!selectedDmChannelId && selectedDmChannelId !== channelId;} catch { return false; }});- const transcriptDmRows = directMessageRoute- ? query(transcript, '[role="article"]').filter(visible)- : [];- const transcriptDmChannelIds = directMessageRoute- ? transcriptDmRows- .map(node => /^chat-messages___chat-messages-(\d+)-\d+$/.exec(attribute(node, 'data-list-item-id'))?.[1])- .filter(Boolean)- : [];- const transcriptMatchesDmRoute = transcriptDmRows.length > 0- && transcriptDmChannelIds.length === transcriptDmRows.length- && transcriptDmChannelIds.every(id => id === channelId);+ const transcriptRows = query(transcript, '[role="article"]').filter(visible);+ const transcriptChannelIds = transcriptRows+ .map(node => /^chat-messages___chat-messages-(\d+)-\d+$/.exec(attribute(node, 'data-list-item-id'))?.[1])+ .filter(Boolean);+ const transcriptMatchesRoute = transcriptRows.length > 0+ && transcriptChannelIds.length === transcriptRows.length+ && transcriptChannelIds.every(id => id === channelId);const name = /^Message #(.+)$/.exec(attribute(composer, 'aria-label'))?.[1]|| /^Messages in (.+)$/.exec(attribute(transcript, 'aria-label'))?.[1]|| /^(.+) \(channel\)$/.exec(attribute(root, 'aria-label'))?.[1]|| (directMessageRoute ? `direct-message-${channelId}` : `channel-${channelId}`);return transcript && (directMessageRoute? !selectedDmRouteMismatch- && (transcriptDmRows.length > 0 ? transcriptMatchesDmRoute : channelLink)- : channelLink)+ && (transcriptRows.length > 0 ? transcriptMatchesRoute : channelLink)+ : channelLink && (transcriptRows.length === 0 || transcriptMatchesRoute))? {root, transcript, name, channelId,isDirectMessage: !!directMessageRoute,diff --git a/src/firefox/src/content/chat-observation.js b/src/firefox/src/content/chat-observation.jsindex 2cfc82aa4..cd49eeeb4 100644--- a/src/firefox/src/content/chat-observation.js+++ b/src/firefox/src/content/chat-observation.js@@ -167,25 +167,21 @@&& !!selectedDmChannelId && selectedDmChannelId !== channelId;} catch { return false; }});- const transcriptDmRows = directMessageRoute- ? query(transcript, '[role="article"]').filter(visible)- : [];- const transcriptDmChannelIds = directMessageRoute- ? transcriptDmRows- .map(node => /^chat-messages___chat-messages-(\d+)-\d+$/.exec(attribute(node, 'data-list-item-id'))?.[1])- .filter(Boolean)- : [];- const transcriptMatchesDmRoute = transcriptDmRows.length > 0- && transcriptDmChannelIds.length === transcriptDmRows.length- && transcriptDmChannelIds.every(id => id === channelId);+ const transcriptRows = query(transcript, '[role="article"]').filter(visible);+ const transcriptChannelIds = transcriptRows+ .map(node => /^chat-messages___chat-messages-(\d+)-\d+$/.exec(attribute(node, 'data-list-item-id'))?.[1])+ .filter(Boolean);+ const transcriptMatchesRoute = transcriptRows.length > 0+ && transcriptChannelIds.length === transcriptRows.length+ && transcriptChannelIds.every(id => id === channelId);const name = /^Message #(.+)$/.exec(attribute(composer, 'aria-label'))?.[1]|| /^Messages in (.+)$/.exec(attribute(transcript, 'aria-label'))?.[1]|| /^(.+) \(channel\)$/.exec(attribute(root, 'aria-label'))?.[1]|| (directMessageRoute ? `direct-message-${channelId}` : `channel-${channelId}`);return transcript && (directMessageRoute? !selectedDmRouteMismatch- && (transcriptDmRows.length > 0 ? transcriptMatchesDmRoute : channelLink)- : channelLink)+ && (transcriptRows.length > 0 ? transcriptMatchesRoute : channelLink)+ : channelLink && (transcriptRows.length === 0 || transcriptMatchesRoute))? {root, transcript, name, channelId,isDirectMessage: !!directMessageRoute,diff --git a/test/discord-guard.mjs b/test/discord-guard.mjsindex 399f51cc6..365985ef4 100644--- a/test/discord-guard.mjs+++ b/test/discord-guard.mjs@@ -321,6 +321,14 @@ for (const [kind, engine, AgentClass, policy] of [assert.equal(localized.threadKey,result.threadKey);assert.deepEqual(localized.messages,result.messages);+ await page.locator('nav').evaluate(el=>el.insertAdjacentHTML('beforeend',+ '<a id="channel-b" href="/channels/123/789" aria-current="page">second channel</a>'));+ await page.evaluate(()=>history.replaceState(null,'','/channels/123/789'));+ assert.equal((await observe()).success,false,'a matching current guild rail link cannot override stale transcript rows');+ await page.locator('#channel-b').evaluate(el=>el.remove());+ await page.evaluate(()=>history.replaceState(null,'','/channels/123/456'));+ assert.equal((await observe()).success,true,'the guild route succeeds again when the transcript IDs match it');+await page.locator('#message .contents img').evaluate(el=>el.setAttribute('src','https://cdn.discordapp.com/guilds/123/users/22/avatars/other.webp?size=160'));assert.equal((await observe()).messages[0].direction,'incoming','guild-profile avatars retain the member identity');await page.locator('#message .contents img').evaluate(el=>el.setAttribute('src','https://cdn.discordapp.com/guilds/123/users/11/avatars/self.webp?size=160'));@@ -356,8 +364,11 @@ for (const [kind, engine, AgentClass, policy] of [<li><div role="article" data-list-item-id="chat-messages___chat-messages-456-1002"><div class="contents"><img src="/assets/embed/avatars/3.png"><h3><span id="message-username-1002"><span data-text="WebBrain">WebBrain</span></span><time id="message-timestamp-1002" datetime="${new Date().toISOString()}"></time></h3><div id="message-content-1002">My answer</div></div><div id="message-accessories-1002"><div class="embedTitle_fixture">My answer link preview</div><div class="embedDescription_fixture">Preview description</div></div></div></li>- <li><div role="article" data-list-item-id="chat-messages___chat-messages-999-1003"><div id="message-content-1003">Wrong channel</div></div></li><li><div role="article" class="isSystemMessage_fixture" data-list-item-id="chat-messages___chat-messages-456-1004"><div id="message-content-1004">A member joined</div></div></li>`));+ await page.locator('[data-list-id=chat-messages]').evaluate(el=>el.insertAdjacentHTML('beforeend',+ '<li id="foreign-channel-row"><div role="article" data-list-item-id="chat-messages___chat-messages-999-1003"><div id="message-content-1003">Wrong channel</div></div></li>'));+ assert.equal((await observe()).success,false,'a visible conflicting guild transcript row fails closed');+ await page.locator('#foreign-channel-row').evaluate(el=>el.remove());const afterDraft=await observe();const pending=markChatSendPending(advanced.session,{ok:true,messageKey:'test-pending',threadKey:result.threadKey,text:'My answer',attemptedAt,