Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix: avoid duplicate clipboard images from files+items union
Emre Sokullud0286b30f026
diff --git a/src/chrome/src/ui/attachment-drop.js b/src/chrome/src/ui/attachment-drop.jsindex da8cf0ee5..d771b5614 100644--- a/src/chrome/src/ui/attachment-drop.js+++ b/src/chrome/src/ui/attachment-drop.js@@ -11,11 +11,14 @@ export function clipboardImageFiles(event) {const clipboardData = event?.clipboardData;if (!clipboardData) return [];const fromFiles = Array.from(clipboardData.files || []);+ if (fromFiles.length) return fromFiles.filter(file => (+ String(file?.type || '').startsWith('image/')+ ));const fromItems = Array.from(clipboardData.items || []).filter(item => item?.kind === 'file').map(item => item.getAsFile?.()).filter(Boolean);- return [...fromFiles, ...fromItems].filter(file => (+ return fromItems.filter(file => (String(file?.type || '').startsWith('image/')));}diff --git a/src/firefox/src/ui/attachment-drop.js b/src/firefox/src/ui/attachment-drop.jsindex da8cf0ee5..d771b5614 100644--- a/src/firefox/src/ui/attachment-drop.js+++ b/src/firefox/src/ui/attachment-drop.js@@ -11,11 +11,14 @@ export function clipboardImageFiles(event) {const clipboardData = event?.clipboardData;if (!clipboardData) return [];const fromFiles = Array.from(clipboardData.files || []);+ if (fromFiles.length) return fromFiles.filter(file => (+ String(file?.type || '').startsWith('image/')+ ));const fromItems = Array.from(clipboardData.items || []).filter(item => item?.kind === 'file').map(item => item.getAsFile?.()).filter(Boolean);- return [...fromFiles, ...fromItems].filter(file => (+ return fromItems.filter(file => (String(file?.type || '').startsWith('image/')));}diff --git a/test/attachment-drop.mjs b/test/attachment-drop.mjsindex 31cfd0149..45f1387f7 100644--- a/test/attachment-drop.mjs+++ b/test/attachment-drop.mjs@@ -205,6 +205,17 @@ for (const [label, relativeModule] of implementations) {[itemsImage],`${label}: clipboard images from items should be recognized when files is empty`);+ const sharedImage = { name: 'shared.png', type: 'image/png' };+ assert.deepEqual(+ module.clipboardImageFiles({+ clipboardData: {+ files: [sharedImage],+ items: [{ kind: 'file', getAsFile: () => sharedImage }],+ },+ }),+ [sharedImage],+ `${label}: files and items should not produce duplicate attachments`+ );const target = createTarget();const files = [{ name: 'notes.txt', type: 'text/plain' }];