Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix(sidepanel): keep sensitive values out of activity labels
Emre Sokullud7c56b303dd6
diff --git a/src/chrome/src/ui/sidepanel.js b/src/chrome/src/ui/sidepanel.jsindex 1a68eb182..00aa3391f 100644--- a/src/chrome/src/ui/sidepanel.js+++ b/src/chrome/src/ui/sidepanel.js@@ -2950,7 +2950,7 @@ const TOOL_KEYS = {read_youtube_transcript: 'tool.read_youtube_transcript',screenshot: 'tool.screenshot',full_page_screenshot: 'tool.screenshot',- auto_screenshot: 'tool.screenshot',+ auto_screenshot: 'tool.staged_screenshot',staged_screenshot: 'tool.staged_screenshot',upload_file: 'tool.upload_file',download_resource_from_page: 'tool.download_resource',@@ -3002,9 +3002,6 @@ function friendlyToolLabel(name, args) {if ((name === 'click' || name === 'click_ax' || name === 'iframe_click') && args?.index != null) {return t('tool.click.index', { index: args.index });}- if ((name === 'click' || name === 'click_ax' || name === 'iframe_click') && args?.text) {- return t('tool.click.selector', { selector: truncate(args.text, 30) });- }// NOTE: only type_text previews its text. type_ax / set_field / iframe_type// are the preferred form-filling tools and routinely carry passwords, OTP// codes, and API keys — never render their values in the always-visible label.diff --git a/src/firefox/src/ui/sidepanel.js b/src/firefox/src/ui/sidepanel.jsindex ff5a6c303..0a571f93e 100644--- a/src/firefox/src/ui/sidepanel.js+++ b/src/firefox/src/ui/sidepanel.js@@ -2811,7 +2811,7 @@ const TOOL_KEYS = {read_youtube_transcript: 'tool.read_youtube_transcript',screenshot: 'tool.screenshot',full_page_screenshot: 'tool.screenshot',- auto_screenshot: 'tool.screenshot',+ auto_screenshot: 'tool.staged_screenshot',staged_screenshot: 'tool.staged_screenshot',upload_file: 'tool.upload_file',download_resource_from_page: 'tool.download_resource',@@ -2863,9 +2863,6 @@ function friendlyToolLabel(name, args) {if ((name === 'click' || name === 'click_ax' || name === 'iframe_click') && args?.index != null) {return t('tool.click.index', { index: args.index });}- if ((name === 'click' || name === 'click_ax' || name === 'iframe_click') && args?.text) {- return t('tool.click.selector', { selector: truncate(args.text, 30) });- }// NOTE: only type_text previews its text. type_ax / set_field / iframe_type// are the preferred form-filling tools and routinely carry passwords, OTP// codes, and API keys — never render their values in the always-visible label.diff --git a/test/run.js b/test/run.jsindex 4348a2aee..47b9fd806 100644--- a/test/run.js+++ b/test/run.js@@ -45057,8 +45057,10 @@ test('sidepanel friendlyToolLabel localizes get_accessibility_tree and actions aassert.match(panel, /staged_screenshot:\s*['"]tool\.staged_screenshot['"]/, `${label}: staged_screenshot must keep its own inspection label`);assert.match(panel, /get_frames:\s*['"]tool\.get_frames['"]/, `${label}: get_frames must keep its own discovery label`);assert.match(panel, /download_resource_from_page:\s*['"]tool\.download_resource['"]/, `${label}: download_resource_from_page must keep its own file label`);+ assert.match(panel, /auto_screenshot:\s*['"]tool\.staged_screenshot['"]/, `${label}: auto_screenshot must use an inspection label after capture`);assert.doesNotMatch(panel, /name === 'type_ax'[^;]*?tool\.type_text\.text/, `${label}: type_ax must not preview typed text (credential exposure)`);assert.doesNotMatch(panel, /name === 'set_field'[^;]*?tool\.type_text\.text/, `${label}: set_field must not preview typed text (credential exposure)`);+ assert.doesNotMatch(panel, /name === 'click'[^;]*?args\?\.text/, `${label}: click must not preview arbitrary target text`);assert.match(panel, /function refreshRenderedStepLabels\(root\)/, `${label}: rendered step labels must be refreshable on locale change`);assert.match(panel, /step\.dataset\.args = safeLabelArgs\(args\)/, `${label}: steps must persist label args for locale refresh`);assert.match(panel, /refreshRenderedStepLabels\(\);/, `${label}: locale-change handler must refresh rendered step labels`);