Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

fix(social-publish): exact NFC bodies through link verification

Barack Sokullud8f378ec8a1a
diff --git a/src/chrome/src/agent/agent.js b/src/chrome/src/agent/agent.js
index ff1b5d377..0ceeb30e0 100644
--- a/src/chrome/src/agent/agent.js
+++ b/src/chrome/src/agent/agent.js
@@ -2803,17 +2803,22 @@ export class Agent extends LoopDetector {
if (this._workflowPublishedPayloadValueObserved(requirement, { pageText: authoredText })) return true;
}
const links = Array.isArray(record?.links) ? record.links : [];
+ // The URL-substitution comparison below runs on the exact (NFC) bodies
+ // built from the preserved raw value, so compatibility-folding can never
+ // certify visibly distinct text before matching.
+ const expectedExact = this._workflowSocialExactBody(requirement?.rawValue ?? requirement?.value);
+ const observedExact = this._workflowSocialExactBody(authoredText);
// "!", ";" and ":" are valid path characters, so a URL like
// https://en.wikipedia.org/wiki/Yahoo! is not punctuated, it just ends
// that way. Trim only when the page never rendered the raw form.
// CJK prose runs a sentence delimiter straight into the next clause with
// no space, and no amount of trailing trimming can find the end of a URL
// that already swallowed the rest of the sentence.
- const requestedUrls = (expectedBody.match(/https?:\/\/[^\s<>"'\u3002\u3001\uff0c\uff1b\uff1a\uff01\uff1f\u2026\u2025]+/gi) || [])
+ const requestedUrls = (expectedExact.match(/https?:\/\/[^\s<>"'\u3002\u3001\uff0c\uff1b\uff1a\uff01\uff1f\u2026\u2025]+/gi) || [])
.map((rawUrl) => {
const trimmed = this._workflowTrimUrlPunctuation(rawUrl);
if (trimmed === rawUrl) return rawUrl;
- const renderedRaw = observedBody.includes(rawUrl)
+ const renderedRaw = observedExact.includes(rawUrl)
|| links.some(link => this._workflowSocialLinkMatchesRequested(link, rawUrl));
return renderedRaw ? rawUrl : trimmed;
});
@@ -2839,8 +2844,8 @@ export class Agent extends LoopDetector {
const getDisplayed = (candidate) => {
if (!candidate) return null;
return ['text', 'title', 'ariaLabel', 'expandedUrl', 'href']
- .map(field => this._workflowMetadataValue(candidate[field]))
- .filter(value => value && observedBody.includes(value))
+ .map(field => this._workflowSocialExactBody(candidate[field]))
+ .filter(value => value && observedExact.includes(value))
.find(value => this._workflowSocialDisplayedUrlMatchesRequested(value, requested));
};
@@ -2884,7 +2889,7 @@ export class Agent extends LoopDetector {
let priorDisplayOccurrences = 0;
for (let i = 0; i < linkIndex; i++) {
const hasMatchingDisplay = ['text', 'title', 'ariaLabel', 'expandedUrl', 'href']
- .map(field => this._workflowMetadataValue(links[i]?.[field]))
+ .map(field => this._workflowSocialExactBody(links[i]?.[field]))
.some(val => val === displayed);
if (hasMatchingDisplay) {
const usage = linkUsageCount.get(i) || 0;
@@ -2893,13 +2898,13 @@ export class Agent extends LoopDetector {
}
const occurrenceIndex = priorDisplayOccurrences + timesUsed;
- const observedOccurrences = findOccurrences(observedBody, displayed);
+ const observedOccurrences = findOccurrences(observedExact, displayed);
if (occurrenceIndex >= observedOccurrences.length) return false;
const observedRange = observedOccurrences[occurrenceIndex];
const expTimesUsed = expectedOccurrencesByUrl.get(requested) || 0;
expectedOccurrencesByUrl.set(requested, expTimesUsed + 1);
- const expOccurrences = findOccurrences(expectedBody, requested);
+ const expOccurrences = findOccurrences(expectedExact, requested);
if (expTimesUsed >= expOccurrences.length) return false;
const expectedRange = expOccurrences[expTimesUsed];
@@ -2917,8 +2922,8 @@ export class Agent extends LoopDetector {
return res;
};
- const comparableExpected = applyReplacements(expectedBody, expectedReplacements);
- const comparableObserved = applyReplacements(observedBody, observedReplacements);
+ const comparableExpected = applyReplacements(expectedExact, expectedReplacements);
+ const comparableObserved = applyReplacements(observedExact, observedReplacements);
if (!comparableExpected || !comparableObserved) return false;
if (hasDedicatedAuthoredText) {
diff --git a/src/firefox/src/agent/agent.js b/src/firefox/src/agent/agent.js
index 0f0e502b5..b2cdd2470 100644
--- a/src/firefox/src/agent/agent.js
+++ b/src/firefox/src/agent/agent.js
@@ -2518,17 +2518,22 @@ export class Agent extends LoopDetector {
if (this._workflowPublishedPayloadValueObserved(requirement, { pageText: authoredText })) return true;
}
const links = Array.isArray(record?.links) ? record.links : [];
+ // The URL-substitution comparison below runs on the exact (NFC) bodies
+ // built from the preserved raw value, so compatibility-folding can never
+ // certify visibly distinct text before matching.
+ const expectedExact = this._workflowSocialExactBody(requirement?.rawValue ?? requirement?.value);
+ const observedExact = this._workflowSocialExactBody(authoredText);
// "!", ";" and ":" are valid path characters, so a URL like
// https://en.wikipedia.org/wiki/Yahoo! is not punctuated, it just ends
// that way. Trim only when the page never rendered the raw form.
// CJK prose runs a sentence delimiter straight into the next clause with
// no space, and no amount of trailing trimming can find the end of a URL
// that already swallowed the rest of the sentence.
- const requestedUrls = (expectedBody.match(/https?:\/\/[^\s<>"'\u3002\u3001\uff0c\uff1b\uff1a\uff01\uff1f\u2026\u2025]+/gi) || [])
+ const requestedUrls = (expectedExact.match(/https?:\/\/[^\s<>"'\u3002\u3001\uff0c\uff1b\uff1a\uff01\uff1f\u2026\u2025]+/gi) || [])
.map((rawUrl) => {
const trimmed = this._workflowTrimUrlPunctuation(rawUrl);
if (trimmed === rawUrl) return rawUrl;
- const renderedRaw = observedBody.includes(rawUrl)
+ const renderedRaw = observedExact.includes(rawUrl)
|| links.some(link => this._workflowSocialLinkMatchesRequested(link, rawUrl));
return renderedRaw ? rawUrl : trimmed;
});
@@ -2554,8 +2559,8 @@ export class Agent extends LoopDetector {
const getDisplayed = (candidate) => {
if (!candidate) return null;
return ['text', 'title', 'ariaLabel', 'expandedUrl', 'href']
- .map(field => this._workflowMetadataValue(candidate[field]))
- .filter(value => value && observedBody.includes(value))
+ .map(field => this._workflowSocialExactBody(candidate[field]))
+ .filter(value => value && observedExact.includes(value))
.find(value => this._workflowSocialDisplayedUrlMatchesRequested(value, requested));
};
@@ -2599,7 +2604,7 @@ export class Agent extends LoopDetector {
let priorDisplayOccurrences = 0;
for (let i = 0; i < linkIndex; i++) {
const hasMatchingDisplay = ['text', 'title', 'ariaLabel', 'expandedUrl', 'href']
- .map(field => this._workflowMetadataValue(links[i]?.[field]))
+ .map(field => this._workflowSocialExactBody(links[i]?.[field]))
.some(val => val === displayed);
if (hasMatchingDisplay) {
const usage = linkUsageCount.get(i) || 0;
@@ -2608,13 +2613,13 @@ export class Agent extends LoopDetector {
}
const occurrenceIndex = priorDisplayOccurrences + timesUsed;
- const observedOccurrences = findOccurrences(observedBody, displayed);
+ const observedOccurrences = findOccurrences(observedExact, displayed);
if (occurrenceIndex >= observedOccurrences.length) return false;
const observedRange = observedOccurrences[occurrenceIndex];
const expTimesUsed = expectedOccurrencesByUrl.get(requested) || 0;
expectedOccurrencesByUrl.set(requested, expTimesUsed + 1);
- const expOccurrences = findOccurrences(expectedBody, requested);
+ const expOccurrences = findOccurrences(expectedExact, requested);
if (expTimesUsed >= expOccurrences.length) return false;
const expectedRange = expOccurrences[expTimesUsed];
@@ -2632,8 +2637,8 @@ export class Agent extends LoopDetector {
return res;
};
- const comparableExpected = applyReplacements(expectedBody, expectedReplacements);
- const comparableObserved = applyReplacements(observedBody, observedReplacements);
+ const comparableExpected = applyReplacements(expectedExact, expectedReplacements);
+ const comparableObserved = applyReplacements(observedExact, observedReplacements);
if (!comparableExpected || !comparableObserved) return false;
if (hasDedicatedAuthoredText) {
diff --git a/test/run.js b/test/run.js
index 4c752c55a..02162899f 100644
--- a/test/run.js
+++ b/test/run.js
@@ -91661,6 +91661,20 @@ test('X and Bluesky same-route publication accepts only one new permalink with t
{ field: 'body', value: '1', rawValue: 'â‘ ' },
{ bodyText: 'â‘ ' },
), true, AgentClass.name + ': the preserved raw body stopped verifying');
+ assert.equal(agent._workflowSocialPublishedBodyObserved(
+ { field: 'body', value: '1 https://example.com/long', rawValue: 'â‘  https://example.com/long' },
+ {
+ bodyText: '1 example.com/long…',
+ links: [{ href: 'https://t.co/x', text: 'example.com/long…', expandedUrl: 'https://example.com/long' }],
+ },
+ ), false, AgentClass.name + ': a folded body with a shortened link verified');
+ assert.equal(agent._workflowSocialPublishedBodyObserved(
+ { field: 'body', value: 'â‘  https://example.com/long' },
+ {
+ bodyText: '① example.com/long…',
+ links: [{ href: 'https://t.co/x', text: 'example.com/long…', expandedUrl: 'https://example.com/long' }],
+ },
+ ), true, AgentClass.name + ': an exact body with a shortened link stopped verifying');
const guard = agent._startPlanExecutionGuard(tabId, 'act', {
requestKind: 'execute',
requiresStateChange: true,