Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

fix: reject blank safe-first options

Emre Sokulludda421f52b31
diff --git a/src/chrome/src/agent/agent.js b/src/chrome/src/agent/agent.js
index ad9720fad..34b107b1f 100644
--- a/src/chrome/src/agent/agent.js
+++ b/src/chrome/src/agent/agent.js
@@ -33852,7 +33852,7 @@ If the user has already named or confirmed this exact recipient, do NOT ask agai
return { success: false, error: 'clarify: `question` is required (a single sentence asking the user something specific).' };
}
const options = Array.isArray(args?.options)
- ? args.options.map(s => String(s).slice(0, 200)).filter(Boolean).slice(0, 4)
+ ? args.options.map(s => String(s).trim().slice(0, 200)).filter(Boolean).slice(0, 4)
: [];
const safeFirst = args?.safe_first === true && options.length > 0;
const reason = args?.reason ? String(args.reason).slice(0, 300) : null;
diff --git a/src/firefox/src/agent/agent.js b/src/firefox/src/agent/agent.js
index 1d058b692..8825d9c59 100644
--- a/src/firefox/src/agent/agent.js
+++ b/src/firefox/src/agent/agent.js
@@ -30561,7 +30561,7 @@ Rules: no prose intro, no conclusion, no "this screenshot shows...", no layout d
return { success: false, error: 'clarify: `question` is required (a single sentence asking the user something specific).' };
}
const options = Array.isArray(args?.options)
- ? args.options.map(s => String(s).slice(0, 200)).filter(Boolean).slice(0, 4)
+ ? args.options.map(s => String(s).trim().slice(0, 200)).filter(Boolean).slice(0, 4)
: [];
const safeFirst = args?.safe_first === true && options.length > 0;
const reason = args?.reason ? String(args.reason).slice(0, 300) : null;
diff --git a/test/run.js b/test/run.js
index 02569d02d..095f7281c 100644
--- a/test/run.js
+++ b/test/run.js
@@ -48798,6 +48798,18 @@ test('clarify result distinguishes waited timeout from user and Instant authoriz
assert.equal(userReply.requiresExplicitConfirmation, false, `${AgentClass.name}: direct reply kept the timeout warning`);
assert.equal(agent._clarificationAuthorizationGuards.has(tabId), false, `${AgentClass.name}: direct reply did not clear the timeout guard`);
+ const blankOptionTimeout = await agent.executeTool(
+ tabId,
+ 'clarify',
+ { question: 'Continue?', options: [' '], safe_first: true },
+ (type, data) => {
+ if (type === 'clarify') agent.submitClarifyResponse(tabId, data.clarifyId, '', 'timeout');
+ },
+ );
+ assert.equal(blankOptionTimeout.authorized, false, `${AgentClass.name}: whitespace-only safe_first option was accepted`);
+ assert.equal(agent._clarificationAuthorizationGuards.get(tabId)?.authorized, false, `${AgentClass.name}: whitespace-only option did not arm a timeout guard`);
+
+ await agent._recordClarificationAuthorization(tabId, 'user');
const affirmativeTimeout = await agent.executeTool(
tabId,
'clarify',