Skip to content

Open-source AI browser agent for Chrome and Firefox (monorepo) 🧠

observe form submission method changes

Barack Sokullue173c4eacf07
diff --git a/src/chrome/src/content/page-monitor.js b/src/chrome/src/content/page-monitor.js
index 60edf28e2..49cf26b38 100644
--- a/src/chrome/src/content/page-monitor.js
+++ b/src/chrome/src/content/page-monitor.js
@@ -386,8 +386,8 @@
el.getAttribute('aria-valuenow'), el.getAttribute('aria-valuetext'),
el.getAttribute('aria-pressed'),
el.getAttribute('type'),
- el.getAttribute('href'), el.getAttribute('target'), el.getAttribute('download'), el.getAttribute('action'),
- el.getAttribute('formaction'), el.getAttribute('formtarget'),
+ el.getAttribute('href'), el.getAttribute('target'), el.getAttribute('download'), el.getAttribute('action'), el.getAttribute('method'),
+ el.getAttribute('formaction'), el.getAttribute('formmethod'), el.getAttribute('formtarget'),
el.getAttribute('popover'), popoverOpen(el),
el.selected === true, el.defaultSelected === true,
Number.isInteger(el.selectedIndex) ? el.selectedIndex : null,
@@ -462,7 +462,7 @@
attributeFilter: ['role', 'aria-label', 'id', 'for', 'name', 'placeholder', 'title', 'alt', 'aria-labelledby',
'aria-required', 'aria-readonly', 'contenteditable', 'tabindex', 'onclick', 'required',
'aria-expanded', 'aria-selected', 'aria-checked', 'aria-pressed', 'aria-disabled',
- 'type', 'href', 'target', 'download', 'action', 'formaction', 'formtarget',
+ 'type', 'href', 'target', 'download', 'action', 'method', 'formaction', 'formmethod', 'formtarget',
'aria-valuenow', 'aria-valuetext', 'aria-hidden', 'hidden', 'disabled', 'readonly', 'checked', 'selected', 'open', 'popover', 'inert', 'class', 'style'] });
listen(root, 'beforetoggle', event => {
const el = elementFor(event);
diff --git a/src/firefox/src/content/page-monitor.js b/src/firefox/src/content/page-monitor.js
index 60edf28e2..49cf26b38 100644
--- a/src/firefox/src/content/page-monitor.js
+++ b/src/firefox/src/content/page-monitor.js
@@ -386,8 +386,8 @@
el.getAttribute('aria-valuenow'), el.getAttribute('aria-valuetext'),
el.getAttribute('aria-pressed'),
el.getAttribute('type'),
- el.getAttribute('href'), el.getAttribute('target'), el.getAttribute('download'), el.getAttribute('action'),
- el.getAttribute('formaction'), el.getAttribute('formtarget'),
+ el.getAttribute('href'), el.getAttribute('target'), el.getAttribute('download'), el.getAttribute('action'), el.getAttribute('method'),
+ el.getAttribute('formaction'), el.getAttribute('formmethod'), el.getAttribute('formtarget'),
el.getAttribute('popover'), popoverOpen(el),
el.selected === true, el.defaultSelected === true,
Number.isInteger(el.selectedIndex) ? el.selectedIndex : null,
@@ -462,7 +462,7 @@
attributeFilter: ['role', 'aria-label', 'id', 'for', 'name', 'placeholder', 'title', 'alt', 'aria-labelledby',
'aria-required', 'aria-readonly', 'contenteditable', 'tabindex', 'onclick', 'required',
'aria-expanded', 'aria-selected', 'aria-checked', 'aria-pressed', 'aria-disabled',
- 'type', 'href', 'target', 'download', 'action', 'formaction', 'formtarget',
+ 'type', 'href', 'target', 'download', 'action', 'method', 'formaction', 'formmethod', 'formtarget',
'aria-valuenow', 'aria-valuetext', 'aria-hidden', 'hidden', 'disabled', 'readonly', 'checked', 'selected', 'open', 'popover', 'inert', 'class', 'style'] });
listen(root, 'beforetoggle', event => {
const el = elementFor(event);
diff --git a/test/page-monitor-ui.mjs b/test/page-monitor-ui.mjs
index 33305ab46..91c452a43 100644
--- a/test/page-monitor-ui.mjs
+++ b/test/page-monitor-ui.mjs
@@ -1774,6 +1774,40 @@ for (const [build, engine] of [['chrome', chromium], ['firefox', firefox]]) {
} finally { await browser.close(); }
});
+ test(`${build}: form method changes invalidate a prepared submit click`, async () => {
+ const { browser, page } = await fixture(engine, build);
+ try {
+ await page.evaluate(() => {
+ const form = document.createElement('form');
+ form.id = 'guarded-form'; form.method = 'get';
+ form.innerHTML = '<button id="guarded-submit" type="submit" formmethod="get">Save</button>';
+ form.addEventListener('submit', event => event.preventDefault());
+ document.body.append(form);
+ });
+ await page.waitForTimeout(120);
+
+ const prepare = operationId => page.evaluate(id => {
+ feedback = [];
+ deliver('page_monitor_prepare', { operationId: id, tool: 'click', selector: '#guarded-submit' });
+ deliver('page_monitor_dispatch', { operationId: id, kind: 'click', selector: '#guarded-submit' });
+ return lastMonitorResponse.guard;
+ }, operationId);
+ const assertStale = guard => page.evaluate(value => window.dispatchEvent(new CustomEvent('webbrain-agent-dom-dispatch', {
+ detail: JSON.stringify({ ...value, dispatchPhase: 'focus' }), cancelable: true,
+ })), guard);
+
+ const formGuard = await prepare('form-method');
+ await page.locator('#guarded-form').evaluate(form => form.setAttribute('method', 'post'));
+ await page.waitForFunction(() => feedback.some(event => event.kind === 'dom' && event.target === 'form#guarded-form'));
+ assert.equal(await assertStale(formGuard), false, 'Changing form method must invalidate the prepared submit click');
+
+ const buttonGuard = await prepare('button-formmethod');
+ await page.locator('#guarded-submit').evaluate(button => button.setAttribute('formmethod', 'post'));
+ await page.waitForFunction(() => feedback.some(event => event.kind === 'dom' && event.target === 'button#guarded-submit'));
+ assert.equal(await assertStale(buttonGuard), false, 'Changing formmethod must invalidate the prepared submit click');
+ } finally { await browser.close(); }
+ });
+
for (const action of ['click', 'type']) {
test(`${build}: ${action} preparation preserves same-target human input`, async () => {
const { browser, page } = await fixture(engine, build);