Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix(ui): polish drag-and-drop styles, cleanup, and test coverage
Codex release-state teste4c483883fcf
diff --git a/src/chrome/src/ui/attachment-drop.js b/src/chrome/src/ui/attachment-drop.jsindex 5d4539ae2..c85151f91 100644--- a/src/chrome/src/ui/attachment-drop.js+++ b/src/chrome/src/ui/attachment-drop.js@@ -46,16 +46,25 @@ export function installFileDropHandlers(target, onFiles) {if (files?.length) onFiles(files);};+ const onWindowDragEnd = () => {+ dragDepth = 0;+ setDragOver(false);+ };+target.addEventListener('dragenter', onDragEnter);target.addEventListener('dragover', onDragOver);target.addEventListener('dragleave', onDragLeave);target.addEventListener('drop', onDrop);+ window.addEventListener?.('dragend', onWindowDragEnd);+ window.addEventListener?.('drop', onWindowDragEnd);return () => {target.removeEventListener?.('dragenter', onDragEnter);target.removeEventListener?.('dragover', onDragOver);target.removeEventListener?.('dragleave', onDragLeave);target.removeEventListener?.('drop', onDrop);+ window.removeEventListener?.('dragend', onWindowDragEnd);+ window.removeEventListener?.('drop', onWindowDragEnd);dragDepth = 0;setDragOver(false);};diff --git a/src/chrome/styles/sidepanel.css b/src/chrome/styles/sidepanel.cssindex c38e1a08b..3eb7d875c 100644--- a/src/chrome/styles/sidepanel.css+++ b/src/chrome/styles/sidepanel.css@@ -3217,11 +3217,6 @@ html[data-ui-scale="175"] .conversation-action-label {border-color: var(--accent);}-#input-area.drag-over #input-wrapper {- border-color: var(--accent);- box-shadow: 0 0 0 2px color-mix(in srgb, var(--accent) 24%, transparent);-}-#input-area.act-mode #input-wrapper {border-color: rgba(255, 152, 0, 0.3);}@@ -3230,6 +3225,11 @@ html[data-ui-scale="175"] .conversation-action-label {border-color: var(--warning);}+#input-area.drag-over #input-wrapper {+ border-color: var(--accent);+ box-shadow: 0 0 0 2px color-mix(in srgb, var(--accent) 24%, transparent);+}+.slash-command-menu {display: flex;flex-direction: column;diff --git a/src/firefox/src/ui/attachment-drop.js b/src/firefox/src/ui/attachment-drop.jsindex 5d4539ae2..c85151f91 100644--- a/src/firefox/src/ui/attachment-drop.js+++ b/src/firefox/src/ui/attachment-drop.js@@ -46,16 +46,25 @@ export function installFileDropHandlers(target, onFiles) {if (files?.length) onFiles(files);};+ const onWindowDragEnd = () => {+ dragDepth = 0;+ setDragOver(false);+ };+target.addEventListener('dragenter', onDragEnter);target.addEventListener('dragover', onDragOver);target.addEventListener('dragleave', onDragLeave);target.addEventListener('drop', onDrop);+ window.addEventListener?.('dragend', onWindowDragEnd);+ window.addEventListener?.('drop', onWindowDragEnd);return () => {target.removeEventListener?.('dragenter', onDragEnter);target.removeEventListener?.('dragover', onDragOver);target.removeEventListener?.('dragleave', onDragLeave);target.removeEventListener?.('drop', onDrop);+ window.removeEventListener?.('dragend', onWindowDragEnd);+ window.removeEventListener?.('drop', onWindowDragEnd);dragDepth = 0;setDragOver(false);};diff --git a/src/firefox/styles/sidepanel.css b/src/firefox/styles/sidepanel.cssindex 9f4860982..922495554 100644--- a/src/firefox/styles/sidepanel.css+++ b/src/firefox/styles/sidepanel.css@@ -3043,11 +3043,6 @@ html[data-ui-scale="175"] .conversation-action-label {border-color: var(--accent);}-#input-area.drag-over #input-wrapper {- border-color: var(--accent);- box-shadow: 0 0 0 2px color-mix(in srgb, var(--accent) 24%, transparent);-}-#input-area.act-mode #input-wrapper {border-color: rgba(255, 152, 0, 0.3);}@@ -3056,6 +3051,11 @@ html[data-ui-scale="175"] .conversation-action-label {border-color: var(--warning);}+#input-area.drag-over #input-wrapper {+ border-color: var(--accent);+ box-shadow: 0 0 0 2px color-mix(in srgb, var(--accent) 24%, transparent);+}+.slash-command-menu {display: flex;flex-direction: column;diff --git a/test/attachment-drop.mjs b/test/attachment-drop.mjsindex 3d460d212..898398ce2 100644--- a/test/attachment-drop.mjs+++ b/test/attachment-drop.mjs@@ -56,6 +56,26 @@ for (const [label, relativeModule] of fileImplementations) {true,`${label}: text/markdown should be accepted as a text attachment`);+ assert.equal(+ isTextAttachment({ name: 'payload', type: 'application/json' }),+ true,+ `${label}: application/json without file extension should be accepted`+ );+ assert.equal(+ isTextAttachment({ name: 'notes', type: 'text/plain' }),+ true,+ `${label}: text/plain without file extension should be accepted`+ );+ assert.equal(+ isTextAttachment({ name: 'data', type: 'text/csv' }),+ true,+ `${label}: text/csv without file extension should be accepted`+ );+ assert.equal(+ isTextAttachment({ name: 'doc', type: 'text/markdown' }),+ true,+ `${label}: text/markdown without file extension should be accepted`+ );assert.equal(isTextAttachment({ name: 'README.MD', type: '' }),true,@@ -76,7 +96,7 @@ for (const [label, relativeModule] of fileImplementations) {function createTarget() {const listeners = new Map();const classes = new Set();- return {+ const target = {classList: {toggle(name, force) {if (force) classes.add(name);@@ -112,8 +132,25 @@ function createTarget() {return event;},};+ return target;}+const windowListeners = new Map();+globalThis.window = {+ addEventListener(type, listener) {+ const handlers = windowListeners.get(type) || [];+ handlers.push(listener);+ windowListeners.set(type, handlers);+ },+ removeEventListener(type, listener) {+ const handlers = windowListeners.get(type) || [];+ windowListeners.set(type, handlers.filter(candidate => candidate !== listener));+ },+ dispatchEvent(type, event = {}) {+ for (const listener of windowListeners.get(type) || []) listener(event);+ },+};+function transfer(types, files = []) {return { types, files, dropEffect: 'none' };}@@ -173,6 +210,15 @@ for (const [label, relativeModule] of implementations) {cleanup();target.dispatch('drop', transfer(['Files'], files));assert.deepEqual(received, [files], `${label}: cleanup should remove drop listeners`);++ // Window dragend / drop fallback clears stuck drag-over+ const target2 = createTarget();+ const cleanup2 = module.installFileDropHandlers(target2, () => {});+ target2.dispatch('dragenter', transfer(['Files']));+ assert.equal(target2.classList.contains('drag-over'), true, `${label}: dragenter should activate drag-over`);+ globalThis.window.dispatchEvent('dragend');+ assert.equal(target2.classList.contains('drag-over'), false, `${label}: window dragend should reset stuck drag-over`);+ cleanup2();}console.log('attachment drag-and-drop tests passed for Chrome and Firefox');