Open-source AI browser agent for Chrome and Firefox (monorepo) ðŸ§
JavaScript ai-agentai-agentsai-toolsbrowser-aibrowser-automationbrowser-extensionchrome-aichrome-devtoolschrome-extensionchrome-extensionsfirefox-addonfirefox-addonsfirefox-extensionfirefox-extensionsgemmagemma4minimaxoffline-aioffline-llmqwen
fix(sidepanel): decode param names for URL redaction and restore friendly label on failure
Emre Sokulluef05a77d375d
diff --git a/src/chrome/src/ui/sidepanel.js b/src/chrome/src/ui/sidepanel.jsindex 82b316857..104422183 100644--- a/src/chrome/src/ui/sidepanel.js+++ b/src/chrome/src/ui/sidepanel.js@@ -10877,6 +10877,25 @@ function findLastActiveCompactStep(toolName = '') {return activeSteps.at(-1) || null;}+// When a step completes or fails, restore its friendly localized label so any+// transient tool_progress message (which may be English-only) does not linger,+// and clear the progress marker so future locale changes refresh the label.+function restoreStepFriendlyLabel(step) {+ if (!step || !step.dataset?.tool) return;+ if (isTerminalDoneTool(step.dataset.tool)) return;+ const label = step.querySelector('.step-label');+ if (label) {+ let stepArgs = null;+ try {+ stepArgs = step.dataset.args ? JSON.parse(step.dataset.args) : null;+ } catch {+ stepArgs = null;+ }+ label.textContent = friendlyToolLabel(step.dataset.tool, stepArgs);+ }+ step.dataset.labelSource = 'friendly';+}+function appendCompactStep(toolName, args) {const container = getOrCreateStepsContainer();if (!container) return;@@ -10890,6 +10909,7 @@ function appendCompactStep(toolName, args) {prev.classList.add('done');const icon = prev.querySelector('.step-icon');if (icon) { icon.className = 'step-icon check'; icon.textContent = '\u2713'; }+ restoreStepFriendlyLabel(prev);}if (isTerminalDoneTool(toolName)) {@@ -11004,17 +11024,7 @@ function markLastStepDone(toolName, result) {// A transient tool_progress message may have overwritten the friendly// label; restore the localized label now that the result arrived so a// later locale change or transcript restore shows the right text.- const label = active.querySelector('.step-label');- if (label) {- let stepArgs = null;- try {- stepArgs = active.dataset.args ? JSON.parse(active.dataset.args) : null;- } catch {- stepArgs = null;- }- label.textContent = friendlyToolLabel(toolName, stepArgs);- }- active.dataset.labelSource = 'friendly';+ restoreStepFriendlyLabel(active);}// Append result to the details panel@@ -11037,6 +11047,7 @@ function markLastStepFailed() {active.classList.add('done');const icon = active.querySelector('.step-icon');if (icon) { icon.className = 'step-icon fail'; icon.textContent = '\u2717'; }+ restoreStepFriendlyLabel(active);}}@@ -11048,6 +11059,7 @@ function finalizeSteps(assistantEl = currentAssistantEl) {step.classList.add('done');const icon = step.querySelector('.step-icon');if (icon) { icon.className = 'step-icon check'; icon.textContent = '\u2713'; }+ restoreStepFriendlyLabel(step);});}diff --git a/src/firefox/src/ui/sidepanel.js b/src/firefox/src/ui/sidepanel.jsindex 2cb0539d2..92cfb3f02 100644--- a/src/firefox/src/ui/sidepanel.js+++ b/src/firefox/src/ui/sidepanel.js@@ -10487,6 +10487,25 @@ function findLastActiveCompactStep(toolName = '') {return activeSteps.at(-1) || null;}+// When a step completes or fails, restore its friendly localized label so any+// transient tool_progress message (which may be English-only) does not linger,+// and clear the progress marker so future locale changes refresh the label.+function restoreStepFriendlyLabel(step) {+ if (!step || !step.dataset?.tool) return;+ if (isTerminalDoneTool(step.dataset.tool)) return;+ const label = step.querySelector('.step-label');+ if (label) {+ let stepArgs = null;+ try {+ stepArgs = step.dataset.args ? JSON.parse(step.dataset.args) : null;+ } catch {+ stepArgs = null;+ }+ label.textContent = friendlyToolLabel(step.dataset.tool, stepArgs);+ }+ step.dataset.labelSource = 'friendly';+}+function appendCompactStep(toolName, args) {const container = getOrCreateStepsContainer();if (!container) return;@@ -10500,6 +10519,7 @@ function appendCompactStep(toolName, args) {prev.classList.add('done');const icon = prev.querySelector('.step-icon');if (icon) { icon.className = 'step-icon check'; icon.textContent = '\u2713'; }+ restoreStepFriendlyLabel(prev);}if (isTerminalDoneTool(toolName)) {@@ -10614,17 +10634,7 @@ function markLastStepDone(toolName, result) {// A transient tool_progress message may have overwritten the friendly// label; restore the localized label now that the result arrived so a// later locale change or transcript restore shows the right text.- const label = active.querySelector('.step-label');- if (label) {- let stepArgs = null;- try {- stepArgs = active.dataset.args ? JSON.parse(active.dataset.args) : null;- } catch {- stepArgs = null;- }- label.textContent = friendlyToolLabel(toolName, stepArgs);- }- active.dataset.labelSource = 'friendly';+ restoreStepFriendlyLabel(active);}// Append result to the details panel@@ -10647,6 +10657,7 @@ function markLastStepFailed() {active.classList.add('done');const icon = active.querySelector('.step-icon');if (icon) { icon.className = 'step-icon fail'; icon.textContent = '\u2717'; }+ restoreStepFriendlyLabel(active);}}@@ -10658,6 +10669,7 @@ function finalizeSteps(assistantEl = currentAssistantEl) {step.classList.add('done');const icon = step.querySelector('.step-icon');if (icon) { icon.className = 'step-icon check'; icon.textContent = '\u2713'; }+ restoreStepFriendlyLabel(step);});}diff --git a/test/run.js b/test/run.jsindex 693e8c034..e9bf02f47 100644--- a/test/run.js+++ b/test/run.js@@ -45068,7 +45068,8 @@ test('sidepanel friendlyToolLabel localizes get_accessibility_tree and actions aassert.match(panel, /signature\|sig/, `${label}: URL credential redaction must cover signatures`);assert.match(panel, /redactUrlForLabel\(args\.url\)/, `${label}: fetch/research labels must redact URL credentials`);assert.match(panel, /function isTerminalDoneTool\(name\)/, `${label}: done_json must share terminal completion handling`);- assert.match(panel, /label\.textContent = friendlyToolLabel\(toolName, stepArgs\);/, `${label}: completed steps must restore the friendly label after progress`);+ assert.match(panel, /function restoreStepFriendlyLabel\(step\)/, `${label}: completed/failed steps must restore friendly label and clear progress marker`);+ assert.match(panel, /label\.textContent = friendlyToolLabel\(step\.dataset\.tool, stepArgs\);/, `${label}: completed steps must restore the friendly label after progress`);}});