Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.
TypeScript accessibilityalternativecloudflarecloudflare-workersdesignfreefrontendopen-sourceradix-uireactremixweb-developmentwebflowwebsite-builderwebsite-developmentwebsiteswebstudio
fix: block publish when JSON prop value is missing (#6507)
Oleg Isonen05ea26f6a6a7
diff --git a/apps/builder/app/builder/features/publish/publish.tsx b/apps/builder/app/builder/features/publish/publish.tsxindex 08147cbe53..c95558ee68 100644--- a/apps/builder/app/builder/features/publish/publish.tsx+++ b/apps/builder/app/builder/features/publish/publish.tsx@@ -239,6 +239,14 @@ const getPrePublishAuditFindings = (): PublishValidationFinding[] => {});};+const blockPublishOnLocalErrors = (+ setFindings: (findings: PublishValidationFinding[]) => void+) => {+ const findings = getPrePublishAuditFindings();+ setFindings(findings);+ return findings.some(({ severity }) => severity === "error");+};+const runPublishDiagnostics = async (projectId: Project["id"],domains?: string[]@@ -827,6 +835,11 @@ const Publish = ({return;}+ if (blockPublishOnLocalErrors(setPublishFindings)) {+ onValidationStateChange("idle");+ return;+ }+startTransition(async () => {setIsPublishing(true);await runPublishAfterBestEffortChecks({@@ -960,6 +973,10 @@ const PublishStatic = ({setPublishError(undefined);setPublishFindings([]);+ if (blockPublishOnLocalErrors(setPublishFindings)) {+ return;+ }+startTransition(async () => {try {setIsPendingOptimistic(true);diff --git a/packages/project-build/src/runtime/pre-publish-audit.test.tsx b/packages/project-build/src/runtime/pre-publish-audit.test.tsxindex 56e43ada87..9755a3f4df 100644--- a/packages/project-build/src/runtime/pre-publish-audit.test.tsx+++ b/packages/project-build/src/runtime/pre-publish-audit.test.tsx@@ -98,6 +98,25 @@ test("warns without blocking legacy invalid HTML", () => {);});+test("blocks publishing when a JSON prop has no value", () => {+ const { instances, props } = renderData(<Body ws:id="body" />);+ props.set("missing-value", {+ id: "missing-value",+ instanceId: "body",+ name: "data",+ type: "json",+ value: undefined,+ });++ expect(runAudit({ instances, props })).toContainEqual({+ ruleId: "json-prop-value",+ severity: "error",+ message:+ "JSON prop “data” on “Body” has no value. Set or reset it before publishing.",+ location: { instanceId: "body", propId: "missing-value" },+ });+});+test("allows valid publishable pages and ignores invalid drafts", () => {const { instances, props } = renderData(<>diff --git a/packages/project-build/src/runtime/pre-publish-audit.ts b/packages/project-build/src/runtime/pre-publish-audit.tsindex ce647deb0d..f8149f2da5 100644--- a/packages/project-build/src/runtime/pre-publish-audit.ts+++ b/packages/project-build/src/runtime/pre-publish-audit.ts@@ -141,8 +141,23 @@ const checkBuildIntegrity: PrePublishAuditCheck = ({},}));+const checkJsonPropValues: PrePublishAuditCheck = ({ props, instances }) =>+ [...props.values()]+ .filter((prop) => prop.type === "json" && prop.value === undefined)+ .map((prop) => {+ const instance = instances.get(prop.instanceId);+ const owner = instance?.label ?? instance?.component ?? prop.instanceId;+ return {+ ruleId: "json-prop-value",+ severity: "error",+ message: `JSON prop “${prop.name}” on “${owner}” has no value. Set or reset it before publishing.`,+ location: { instanceId: prop.instanceId, propId: prop.id },+ };+ });+const prePublishAuditChecks: PrePublishAuditCheck[] = [checkHtmlContentModel,+ checkJsonPropValues,checkBuildIntegrity,];