Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

Remove isEditable option from style source (#1344)

Bogdan Chadkin0dd4869f5110
diff --git a/apps/builder/app/builder/features/style-panel/style-source-section.tsx b/apps/builder/app/builder/features/style-panel/style-source-section.tsx
index a814fedc80..1570155e8d 100644
--- a/apps/builder/app/builder/features/style-panel/style-source-section.tsx
+++ b/apps/builder/app/builder/features/style-panel/style-source-section.tsx
@@ -247,7 +247,6 @@ const renameStyleSource = (id: StyleSource["id"], label: string) => {
type StyleSourceInputItem = {
id: string;
label: string;
- isEditable: boolean;
state: ItemState;
source: ItemSource;
};
@@ -262,7 +261,6 @@ const convertToInputItem = (
return {
id: styleSource.id,
label: "Local",
- isEditable: false,
state,
source: styleSource.type,
};
@@ -270,7 +268,6 @@ const convertToInputItem = (
return {
id: styleSource.id,
label: styleSource.name,
- isEditable: true,
state,
source: styleSource.type,
};
diff --git a/apps/builder/app/builder/features/style-panel/style-source/style-source-input.stories.tsx b/apps/builder/app/builder/features/style-panel/style-source/style-source-input.stories.tsx
index 38890f0da4..b44dbfae56 100644
--- a/apps/builder/app/builder/features/style-panel/style-source/style-source-input.stories.tsx
+++ b/apps/builder/app/builder/features/style-panel/style-source/style-source-input.stories.tsx
@@ -11,7 +11,6 @@ type Item = {
id: string;
label: string;
source: ItemSource;
- isEditable: boolean;
state: ItemState;
};
@@ -19,7 +18,6 @@ const localItem: Item = {
id: nanoid(),
label: "Local",
source: "local",
- isEditable: false,
state: "selected",
};
@@ -28,21 +26,18 @@ const getItems = (): Array<Item> => [
id: nanoid(),
label: "Token",
source: "token",
- isEditable: true,
state: "unselected",
},
{
id: nanoid(),
label: "Tag",
source: "tag",
- isEditable: true,
state: "unselected",
},
{
id: nanoid(),
label: "State",
source: "state",
- isEditable: true,
state: "unselected",
},
];
@@ -56,7 +51,6 @@ const createItem = (
id: nanoid(),
label,
source: "token",
- isEditable: true,
state: "selected",
};
const nextValue = value.map((item) => {
@@ -109,7 +103,6 @@ export const WithTruncatedItem: ComponentStory<
label:
"Local Something Something Something Something Something Something Something Something Something Something Something",
source: "local",
- isEditable: true,
state: "selected",
},
]);
@@ -141,7 +134,6 @@ export const Complete: ComponentStory<typeof StyleSourceInput> = () => {
label: "Disabled",
source: "token",
- isEditable: true,
state: "disabled",
},
]);
diff --git a/apps/builder/app/builder/features/style-panel/style-source/style-source-input.tsx b/apps/builder/app/builder/features/style-panel/style-source/style-source-input.tsx
index e3366311c3..2b5da8913d 100644
--- a/apps/builder/app/builder/features/style-panel/style-source/style-source-input.tsx
+++ b/apps/builder/app/builder/features/style-panel/style-source/style-source-input.tsx
@@ -50,7 +50,6 @@ import { StyleSourceBadge } from "./style-source-badge";
type IntermediateItem = {
id: string;
label: string;
- isEditable: boolean;
state: ItemState;
source: ItemSource;
isAdded?: boolean;
@@ -136,7 +135,6 @@ const TextFieldBase: ForwardRefRenderFunction<
isEditing={item.id === editingItemId}
state={item.state}
source={item.source}
- isEditable={item.isEditable}
onChangeEditing={(isEditing) => {
onEditItem?.(isEditing ? item.id : undefined);
}}
@@ -206,7 +204,6 @@ const matchOrSuggestToCreate = (
label: search.trim(),
state: "unselected",
source: "token",
- isEditable: true,
isAdded: false,
});
}
@@ -299,7 +296,6 @@ export const StyleSourceInput = (
state: "unselected",
id: "",
source: "local",
- isEditable: true,
},
selectedItem: undefined,
match: matchOrSuggestToCreate,
diff --git a/apps/builder/app/builder/features/style-panel/style-source/style-source.tsx b/apps/builder/app/builder/features/style-panel/style-source/style-source.tsx
index 2514e414a0..c9eae9b604 100644
--- a/apps/builder/app/builder/features/style-panel/style-source/style-source.tsx
+++ b/apps/builder/app/builder/features/style-panel/style-source/style-source.tsx
@@ -358,7 +358,6 @@ type StyleSourceProps = {
id: string;
label: string;
menuItems: ReactNode;
- isEditable: boolean;
isEditing: boolean;
isDragging: boolean;
state: ItemState;
@@ -373,7 +372,6 @@ export const StyleSource = ({
label,
state,
menuItems,
- isEditable,
isEditing,
isDragging,
source,
@@ -387,7 +385,7 @@ export const StyleSource = ({
return (
<SourceButton state={state} source={source} id={id} ref={ref}>
<EditableText
- isEditable={isEditable}
+ isEditable={source !== "local"}
isEditing={isEditing}
onChangeEditing={onChangeEditing}
onClick={() => {