Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.
TypeScript accessibilityalternativecloudflarecloudflare-workersdesignfreefrontendopen-sourceradix-uireactremixweb-developmentwebflowwebsite-builderwebsite-developmentwebsiteswebstudio
fix: CSS unitless properties parsing (#4278)
Ivan Starkov11f5450b9a02
diff --git a/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts b/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.tsindex 97fb16de83..99c6ee3551 100644--- a/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts+++ b/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts@@ -27,8 +27,15 @@ export const parseIntermediateOrInvalidValue = ("children" in ast && ast.children?.size === 1? ast.children.first: undefined;+if (node?.type === "Number") {- const testUnit = "unit" in styleValue ? (styleValue.unit ?? "px") : "px";+ const unit = "unit" in styleValue ? styleValue.unit : undefined;++ // Use number as a fallback for custom properties+ const fallbackUnitAsString = property.startsWith("--") ? "" : "px";++ const testUnit = unit === "number" ? "" : (unit ?? fallbackUnitAsString);+const styleInput = parseCssValue(property, `${value}${testUnit}`);if (styleInput.type !== "invalid") {diff --git a/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts.test.ts b/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts.test.tsindex 74b0e71d80..7dfa4e0816 100644--- a/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts.test.ts+++ b/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts.test.ts@@ -570,6 +570,24 @@ test("parse unit in css variable", () => {});});+test("prefer unitless css variable", () => {+ expect(+ parseIntermediateOrInvalidValue("--size", {+ type: "intermediate",+ value: "1",+ unit: undefined,+ })+ ).toEqual({ type: "unit", value: 1, unit: "number" });++ expect(+ parseIntermediateOrInvalidValue("--size", {+ type: "intermediate",+ value: "1",+ unit: "number",+ })+ ).toEqual({ type: "unit", value: 1, unit: "number" });+});+test("parse color in css variable", () => {expect(parseIntermediateOrInvalidValue("--size", {