Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.
TypeScript accessibilityalternativecloudflarecloudflare-workersdesignfreefrontendopen-sourceradix-uireactremixweb-developmentwebflowwebsite-builderwebsite-developmentwebsiteswebstudio
fix: generate empty function for cleared actions (#2616)
Bogdan Chadkin130d21a30756
diff --git a/packages/react-sdk/src/expression.test.ts b/packages/react-sdk/src/expression.test.tsindex 4667b910b3..04d24dff97 100644--- a/packages/react-sdk/src/expression.test.ts+++ b/packages/react-sdk/src/expression.test.ts@@ -267,3 +267,29 @@ test("generate variables with actions", () => {]));});++test("generate function for empty action", () => {+ const generated = generateDataSources({+ scope: createScope(),+ dataSources: new Map(),+ props: new Map([+ [+ "prop1",+ {+ id: "prop1",+ instanceId: "instance1",+ type: "action",+ name: "onChange",+ value: [],+ },+ ],+ ]),+ });+ expect(generated.body).toMatchInlineSnapshot(`+ "let onChange = () => {+ }+ "+ `);+ expect(generated.variables).toEqual(new Map());+ expect(generated.output).toEqual(new Map([["prop1", "onChange"]]));+});diff --git a/packages/react-sdk/src/expression.ts b/packages/react-sdk/src/expression.tsindex 06397355e8..a6d604964f 100644--- a/packages/react-sdk/src/expression.ts+++ b/packages/react-sdk/src/expression.ts@@ -259,7 +259,8 @@ export const generateDataSources = ({const name = scope.getName(prop.id, prop.name);output.set(prop.id, name);const setters = new Set<DataSourceId>();- let args: undefined | string[] = undefined;+ // important to fallback to empty argumets to render empty function+ let args: string[] = [];let newCode = "";for (const value of prop.value) {args = value.args;@@ -286,9 +287,6 @@ export const generateDataSources = ({});newCode += `\n`;}- if (args === undefined) {- continue;- }if (typed) {args = args.map((arg) => `${arg}: any`);}