Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.
TypeScript accessibilityalternativecloudflarecloudflare-workersdesignfreefrontendopen-sourceradix-uireactremixweb-developmentwebflowwebsite-builderwebsite-developmentwebsiteswebstudio
feat: forgive semicolon in css value inputs (#4090)
Bogdan Chadkin288c9399da61
diff --git a/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts b/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.tsindex 7a539dc791..5c86923b2e 100644--- a/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts+++ b/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts@@ -14,7 +14,10 @@ export const parseIntermediateOrInvalidValue = (property: StyleProperty,styleValue: IntermediateStyleValue | InvalidValue): StyleValue => {- const value = styleValue.value.trim();+ let value = styleValue.value.trim();+ if (value.endsWith(";")) {+ value = value.slice(0, -1);+ }if (property.startsWith("--")) {return {diff --git a/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts.test.ts b/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts.test.tsindex 1de87fc6ac..434de3eaf7 100644--- a/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts.test.ts+++ b/apps/builder/app/builder/features/style-panel/shared/css-value-input/parse-intermediate-or-invalid-value.ts.test.ts@@ -9,6 +9,21 @@ const propertiesAndKeywords = [["lineHeight", "normal" as string],] as const;+test("forgive trailing semicolon", () => {+ expect(+ parseIntermediateOrInvalidValue("width", {+ type: "intermediate",+ value: "20px;",+ })+ ).toEqual({ type: "unit", value: 20, unit: "px" });+ expect(+ parseIntermediateOrInvalidValue("color", {+ type: "intermediate",+ value: "red;",+ })+ ).toEqual({ type: "keyword", value: "red" });+});+describe("Parse intermediate or invalid value without math evaluation", () => {test("not lost unit value", () => {for (const propery of properties) {