Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

fix: Fix selecting text in places where it should be selectable (#3503)

Oleg Isonen2b3e44d74581
diff --git a/apps/builder/app/builder/features/style-panel/shared/property-name.tsx b/apps/builder/app/builder/features/style-panel/shared/property-name.tsx
index 32f820f571..e57c731a92 100644
--- a/apps/builder/app/builder/features/style-panel/shared/property-name.tsx
+++ b/apps/builder/app/builder/features/style-panel/shared/property-name.tsx
@@ -218,10 +218,10 @@ export const TooltipContent = ({
<Text
variant="monoBold"
color="moreSubtle"
+ userSelect="text"
css={{
whiteSpace: "break-spaces",
maxHeight: "3em",
- userSelect: "text",
cursor: "text",
}}
>
diff --git a/apps/builder/app/builder/features/style-panel/style-source/style-source.tsx b/apps/builder/app/builder/features/style-panel/style-source/style-source.tsx
index 3d7351ee30..e88e7615e2 100644
--- a/apps/builder/app/builder/features/style-panel/style-source/style-source.tsx
+++ b/apps/builder/app/builder/features/style-panel/style-source/style-source.tsx
@@ -134,10 +134,10 @@ const EditableText = ({
truncate
ref={ref}
spellCheck={false}
+ userSelect={isEditing ? "text" : "none"}
css={{
outline: "none",
textOverflow: isEditing ? "clip" : "ellipsis",
- userSelect: isEditing ? "auto" : "none",
cursor: isEditing ? "auto" : "default",
}}
{...handlers}
diff --git a/apps/builder/app/builder/shared/tree/index.tsx b/apps/builder/app/builder/shared/tree/index.tsx
index 332f9058d5..7086934d5e 100644
--- a/apps/builder/app/builder/shared/tree/index.tsx
+++ b/apps/builder/app/builder/shared/tree/index.tsx
@@ -215,7 +215,7 @@ const EditableTreeItemLabel = styled(TreeItemLabel, {
outline: "none",
cursor: "auto",
textOverflow: "clip",
- userSelect: "auto",
+ userSelect: "text",
},
},
},
diff --git a/apps/builder/app/dashboard/projects/project-card.tsx b/apps/builder/app/dashboard/projects/project-card.tsx
index 5d0e0968c6..a8049eea50 100644
--- a/apps/builder/app/dashboard/projects/project-card.tsx
+++ b/apps/builder/app/dashboard/projects/project-card.tsx
@@ -37,7 +37,7 @@ import { Card, CardContent, CardFooter } from "../shared/card";
import { CloneProjectDialog } from "~/shared/clone-project";
const titleStyle = css({
- userSelect: "auto",
+ userSelect: "text",
...truncate(),
});
@@ -313,7 +313,7 @@ export const ProjectTemplateCard = ({
</CardContent>
<CardFooter>
<Flex direction="column" justify="around">
- <Text variant="titles" truncate css={{ userSelect: "auto" }}>
+ <Text variant="titles" truncate userSelect="text">
{title}
</Text>
{isPublished ? (
diff --git a/apps/builder/app/dashboard/projects/project-dialogs.tsx b/apps/builder/app/dashboard/projects/project-dialogs.tsx
index 82d116b4ed..6ac54e5172 100644
--- a/apps/builder/app/dashboard/projects/project-dialogs.tsx
+++ b/apps/builder/app/dashboard/projects/project-dialogs.tsx
@@ -328,13 +328,13 @@ export const DeleteProjectDialog = ({
onChange={handleChange}
errors={errors}
label={
- <Label css={{ userSelect: "auto" }}>
+ <Label css={{ userSelect: "text" }}>
Confirm by typing
<Text
as="span"
color="destructive"
variant="labelsSentenceCase"
- css={{ userSelect: "auto" }}
+ css={{ userSelect: "text" }}
>
{` ${title} `}
</Text>
diff --git a/packages/design-system/src/components/text.ts b/packages/design-system/src/components/text.ts
index 7d14b3ab6d..e44ccdb017 100644
--- a/packages/design-system/src/components/text.ts
+++ b/packages/design-system/src/components/text.ts
@@ -56,8 +56,8 @@ export const textStyle = css({
},
},
userSelect: {
- auto: {
- userSelect: "auto",
+ text: {
+ userSelect: "text",
},
none: {
userSelect: "none",