Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

chore: don't fix boolean attributes to empty string values in html embed (#3251)

Oleg Isonen2d91ef420363
diff --git a/apps/builder/app/builder/features/settings-panel/controls/code.tsx b/apps/builder/app/builder/features/settings-panel/controls/code.tsx
index 6609acf382..a2556d8e3d 100644
--- a/apps/builder/app/builder/features/settings-panel/controls/code.tsx
+++ b/apps/builder/app/builder/features/settings-panel/controls/code.tsx
@@ -63,15 +63,28 @@ const ErrorInfo = ({
type Error = { message: string; value: string; expected: string };
+// The problem is to identify broken HTML and because browser is flexible and always tries to fix it we never
+// know if something is actually broken.
+// 1. Parse the HTML using DOM
+// 2. Get HTML via innerHTML
+// 3. Compare the original HTML with innerHTML
+// 4. We try to minimize the amount of false positives by removing
+// - different amount of whitespace
+// - unifying `boolean=""` is the same as `boolean`
const validateHtml = (value: string): Error | undefined => {
- // This is basically what browser does when innerHTML is set
- // but isolated within temporary element
- // so the result is correct markup
const div = document.createElement("div");
div.innerHTML = value;
const expected = div.innerHTML;
- // We don't need to show error for unnecessary whitespace.
- if (value.replace(/\s/g, "") !== expected.replace(/\s/g, "")) {
+ const clean = (value: string) => {
+ return (
+ value
+ // Compare without whitespace to avoid false positives
+ .replace(/\s/g, "")
+ // normalize boolean attributes by turning `boolean=""` into `boolean`
+ .replace('=""', "")
+ );
+ };
+ if (clean(value) !== clean(expected)) {
return { message: "Invalid HTML detected", value, expected };
}
};