Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

fix: strip invalid attributes when paste html (#5304)

Bogdan Chadkin4f2d21ee0655
diff --git a/apps/builder/app/shared/html.test.tsx b/apps/builder/app/shared/html.test.tsx
index 0f54fa5003..82771f6c60 100644
--- a/apps/builder/app/shared/html.test.tsx
+++ b/apps/builder/app/shared/html.test.tsx
@@ -334,3 +334,23 @@ test("generate Image component instead of img element", () => {
)
);
});
+
+test("strip unsupported attribute names", () => {
+ expect(
+ generateFragmentFromHtml(`
+ <button @click="open = true">Expand</button>
+ <button x-on:click="open = !open">
+ Toggle
+ </button>
+ `)
+ ).toEqual(
+ renderTemplate(
+ <>
+ <ws.element ws:tag="button">Expand</ws.element>
+ <ws.element ws:tag="button" x-on:click="open = !open">
+ Toggle
+ </ws.element>
+ </>
+ )
+ );
+});
diff --git a/apps/builder/app/shared/html.ts b/apps/builder/app/shared/html.ts
index c7809f1a44..3c4031a0f0 100644
--- a/apps/builder/app/shared/html.ts
+++ b/apps/builder/app/shared/html.ts
@@ -18,6 +18,7 @@ import { ariaAttributes, attributesByTag } from "@webstudio-is/html-data";
import { camelCaseProperty, parseCss } from "@webstudio-is/css-data";
import { richTextContentTags } from "./content-model";
import { setIsSubsetOf } from "./shim";
+import { isAttributeNameSafe } from "@webstudio-is/react-sdk";
type ElementNode = DefaultTreeAdapterMap["element"];
@@ -169,6 +170,10 @@ export const generateFragmentFromHtml = (
}
instances.set(instance.id, instance);
for (const attr of node.attrs) {
+ // skip attributes which cannot be rendered in jsx
+ if (!isAttributeNameSafe(attr.name)) {
+ continue;
+ }
const id = `${instance.id}:${attr.name}`;
const instanceId = instance.id;
const name = attr.name;