Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

Figcaption as a tag for Text (#1692)

Oleg Isonen54a9303a4768
diff --git a/packages/react-sdk/src/components/__generated__/text-block.props.ts b/packages/react-sdk/src/components/__generated__/text-block.props.ts
index e314ec6e6f..d242a2ad02 100644
--- a/packages/react-sdk/src/components/__generated__/text-block.props.ts
+++ b/packages/react-sdk/src/components/__generated__/text-block.props.ts
@@ -440,4 +440,11 @@ export const props: Record<string, PropMeta> = {
control: "text",
type: "string",
},
+ tag: {
+ required: false,
+ control: "radio",
+ type: "string",
+ defaultValue: "div",
+ options: ["div", "figcaption", "span"],
+ },
};
diff --git a/packages/react-sdk/src/components/box.tsx b/packages/react-sdk/src/components/box.tsx
index 873264f26d..87396dde14 100644
--- a/packages/react-sdk/src/components/box.tsx
+++ b/packages/react-sdk/src/components/box.tsx
@@ -24,7 +24,7 @@ type Props = ComponentProps<typeof defaultTag> & {
export const Box = forwardRef<ElementRef<typeof defaultTag>, Props>(
({ tag = defaultTag, ...props }, ref) => {
- return createElement(tag as string, { ...props, ref });
+ return createElement(tag, { ...props, ref });
}
);
diff --git a/packages/react-sdk/src/components/heading.tsx b/packages/react-sdk/src/components/heading.tsx
index dcfc8afd4f..8a3d33c226 100644
--- a/packages/react-sdk/src/components/heading.tsx
+++ b/packages/react-sdk/src/components/heading.tsx
@@ -13,7 +13,7 @@ type Props = ComponentProps<typeof defaultTag> & {
export const Heading = forwardRef<ElementRef<typeof defaultTag>, Props>(
({ tag = defaultTag, ...props }, ref) => {
- return createElement(tag as string, { ...props, ref });
+ return createElement(tag, { ...props, ref });
}
);
diff --git a/packages/react-sdk/src/components/text-block.tsx b/packages/react-sdk/src/components/text-block.tsx
index 03c20a5ddd..58b2833e97 100644
--- a/packages/react-sdk/src/components/text-block.tsx
+++ b/packages/react-sdk/src/components/text-block.tsx
@@ -1,10 +1,21 @@
-import { forwardRef, type ElementRef, type ComponentProps } from "react";
+import {
+ createElement,
+ forwardRef,
+ type ElementRef,
+ type ComponentProps,
+} from "react";
export const defaultTag = "div";
-export const TextBlock = forwardRef<
- ElementRef<typeof defaultTag>,
- ComponentProps<typeof defaultTag>
->((props, ref) => <div {...props} ref={ref} />);
+// We don't want to enable all tags because Box is usually a container and we have specific components for many tags.
+type Props = ComponentProps<typeof defaultTag> & {
+ tag?: "div" | "span" | "figcaption";
+};
+
+export const TextBlock = forwardRef<ElementRef<typeof defaultTag>, Props>(
+ ({ tag = defaultTag, ...props }, ref) => {
+ return createElement(tag, { ...props, ref });
+ }
+);
TextBlock.displayName = "TextBlock";
diff --git a/packages/react-sdk/src/components/text-block.ws.tsx b/packages/react-sdk/src/components/text-block.ws.tsx
index b70335fdeb..d6c601f7b6 100644
--- a/packages/react-sdk/src/components/text-block.ws.tsx
+++ b/packages/react-sdk/src/components/text-block.ws.tsx
@@ -38,4 +38,5 @@ export const meta: WsComponentMeta = {
export const propsMeta: WsComponentPropsMeta = {
props,
+ initialProps: ["tag"],
};