Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

feat: Show xml category for xml, hide in other cases (#3338)

Ivan Starkov595b443ee051
diff --git a/apps/builder/app/builder/features/settings-panel/props-section/use-props-logic.ts b/apps/builder/app/builder/features/settings-panel/props-section/use-props-logic.ts
index 65c7f1f420..f3cc73c4c2 100644
--- a/apps/builder/app/builder/features/settings-panel/props-section/use-props-logic.ts
+++ b/apps/builder/app/builder/features/settings-panel/props-section/use-props-logic.ts
@@ -151,11 +151,12 @@ export const usePropsLogic = ({
const instanceMeta = useStore($registeredComponentMetas).get(
instance.component
);
- const meta = useStore($registeredComponentPropsMetas).get(instance.component);
-
- if (meta === undefined) {
- throw new Error(`Could not get meta for component "${instance.component}"`);
- }
+ const meta = useStore($registeredComponentPropsMetas).get(
+ instance.component
+ ) ?? {
+ props: {},
+ initialProps: [],
+ };
const savedProps = props;
diff --git a/apps/builder/app/builder/features/sidebar-left/panels/components/components.tsx b/apps/builder/app/builder/features/sidebar-left/panels/components/components.tsx
index 67fa555d07..86670b1199 100644
--- a/apps/builder/app/builder/features/sidebar-left/panels/components/components.tsx
+++ b/apps/builder/app/builder/features/sidebar-left/panels/components/components.tsx
@@ -22,13 +22,17 @@ import {
useDraggable,
} from "./use-draggable";
import { MetaIcon } from "~/builder/shared/meta-icon";
-import { $registeredComponentMetas } from "~/shared/nano-states";
+import { $registeredComponentMetas, $selectedPage } from "~/shared/nano-states";
import { getMetaMaps } from "./get-meta-maps";
import { getInstanceLabel } from "~/shared/instance-utils";
import { isFeatureEnabled } from "@webstudio-is/feature-flags";
export const TabContent = ({ publish, onSetActiveTab }: TabContentProps) => {
const metaByComponentName = useStore($registeredComponentMetas);
+ const selectedPage = useStore($selectedPage);
+
+ const documentType = selectedPage?.meta.documentType ?? "html";
+
const { metaByCategory, componentNamesByMeta } = useMemo(
() => getMetaMaps(metaByComponentName),
[metaByComponentName]
@@ -51,10 +55,12 @@ export const TabContent = ({ publish, onSetActiveTab }: TabContentProps) => {
return false;
}
- if (
- isFeatureEnabled("xmlElement") === false &&
- category === "xml"
- ) {
+ // Only xml category is allowed for xml document type
+ if (documentType === "xml") {
+ return category === "xml";
+ }
+ // Hide xml category for non-xml document types
+ if (category === "xml") {
return false;
}
@@ -62,7 +68,7 @@ export const TabContent = ({ publish, onSetActiveTab }: TabContentProps) => {
isFeatureEnabled("internalComponents") === false &&
category === "internal"
) {
- return;
+ return false;
}
return true;