Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

fix: fix unknown font family support (#4136)

Oleg Isonen654c1345b176
diff --git a/packages/css-engine/src/core/to-value.test.ts b/packages/css-engine/src/core/to-value.test.ts
index c84f7aa525..5b5c8e9a47 100644
--- a/packages/css-engine/src/core/to-value.test.ts
+++ b/packages/css-engine/src/core/to-value.test.ts
@@ -46,7 +46,7 @@ describe("Convert WS CSS Values to native CSS strings", () => {
expect(value).toBe("var(--namespace, normal, 10px)");
});
- test("fontFamily", () => {
+ test("fontFamily stack", () => {
expect(
toValue({
type: "fontFamily",
@@ -57,6 +57,15 @@ describe("Convert WS CSS Values to native CSS strings", () => {
);
});
+ test("fontFamily unknown", () => {
+ expect(
+ toValue({
+ type: "fontFamily",
+ value: ["something-random"],
+ })
+ ).toBe("something-random, sans-serif");
+ });
+
test("Transform font family value to override default fallback", () => {
const value = toValue(
{
diff --git a/packages/css-engine/src/core/to-value.ts b/packages/css-engine/src/core/to-value.ts
index 25f3c20d35..1d89ba899b 100644
--- a/packages/css-engine/src/core/to-value.ts
+++ b/packages/css-engine/src/core/to-value.ts
@@ -7,6 +7,7 @@ export type TransformValue = (styleValue: StyleValue) => undefined | StyleValue;
const fallbackTransform: TransformValue = (styleValue) => {
if (styleValue.type === "fontFamily") {
const fonts = SYSTEM_FONTS.get(styleValue.value[0])?.stack ?? [
+ styleValue.value[0],
DEFAULT_FONT_FALLBACK,
];
const value = Array.from(new Set(fonts));