Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

feat: support <a> download attribute in preview (#5238)

Bogdan Chadkin68621fa3635d
diff --git a/apps/builder/app/canvas/interceptor.ts b/apps/builder/app/canvas/interceptor.ts
index 3421c63d85..c0139e08e5 100644
--- a/apps/builder/app/canvas/interceptor.ts
+++ b/apps/builder/app/canvas/interceptor.ts
@@ -76,45 +76,58 @@ const switchPageAndUpdateSystem = (href: string, formData?: FormData) => {
export const subscribeInterceptedEvents = () => {
const handleClick = (event: MouseEvent) => {
- if (event.target instanceof Element && !$isPreviewMode.get()) {
- // Prevent forwarding the click event on an input element when the associated label has a "for" attribute
- // and prevent checkbox or radio inputs changing when clicked
- if (event.target.closest("label[for]") || event.target.closest("input")) {
- event.preventDefault();
+ if (!(event.target instanceof Element)) {
+ return;
+ }
+ const isPreviewMode = $isPreviewMode.get();
+
+ // Prevent forwarding the click event on an input element when the associated label has a "for" attribute
+ // and prevent checkbox or radio inputs changing when clicked
+ if (event.target.closest("label[for]") || event.target.closest("input")) {
+ if (isPreviewMode) {
+ return;
}
+ event.preventDefault();
}
- if (
- event.target instanceof HTMLElement ||
- event.target instanceof SVGElement
- ) {
- const a = event.target.closest("a");
- if (a) {
- event.preventDefault();
- if ($isPreviewMode.get()) {
- // use attribute instead of a.href to get raw unresolved value
- const href = a.getAttribute("href") ?? "";
- if (isAbsoluteUrl(href)) {
- window.open(href, "_blank");
- } else {
- switchPageAndUpdateSystem(href);
- }
+ const a = event.target.closest("a");
+ if (a) {
+ if (isPreviewMode) {
+ // use attribute instead of a.href to get raw unresolved value
+ const href = a.getAttribute("href") ?? "";
+ if (isAbsoluteUrl(href)) {
+ window.open(href, "_blank");
+ // relative paths can be safely downloaded
+ } else if (a.hasAttribute("download")) {
+ return;
+ } else {
+ switchPageAndUpdateSystem(href);
}
- }
- // prevent invoking submit with buttons in canvas mode
- // because form with prevented submit still invokes validation
- if (event.target.closest("button") && $isPreviewMode.get() === false) {
event.preventDefault();
+ return;
}
+ event.preventDefault();
+ }
+ // prevent invoking submit with buttons in canvas mode
+ // because form with prevented submit still invokes validation
+ if (event.target.closest("button")) {
+ if (isPreviewMode) {
+ return;
+ }
+ event.preventDefault();
}
};
const handlePointerDown = (event: PointerEvent) => {
- if (false === event.target instanceof HTMLElement) {
+ if (!(event.target instanceof Element)) {
return;
}
+ const isPreviewMode = $isPreviewMode.get();
- if (event.target.closest("select") && $isPreviewMode.get() === false) {
+ if (event.target.closest("select")) {
+ if (isPreviewMode) {
+ return;
+ }
event.preventDefault();
}
};
@@ -140,16 +153,14 @@ export const subscribeInterceptedEvents = () => {
};
const handleKeydown = (event: KeyboardEvent) => {
+ if (!(event.target instanceof Element)) {
+ return;
+ }
if ($isPreviewMode.get()) {
return;
}
// prevent typing in inputs only in canvas mode
- if (
- event.target instanceof HTMLInputElement ||
- event.target instanceof HTMLTextAreaElement
- ) {
- event.preventDefault();
- }
+ event.preventDefault();
};
// Note: Event handlers behave unexpectedly when used inside a dialog component.