Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

Fix object fit, ignore loader (#1737)

Oleg Isonen7bef21719fb5
diff --git a/apps/builder/app/shared/nano-states/components-meta.ts b/apps/builder/app/shared/nano-states/components-meta.ts
index 041679140a..e9e40b4dd9 100644
--- a/apps/builder/app/shared/nano-states/components-meta.ts
+++ b/apps/builder/app/shared/nano-states/components-meta.ts
@@ -39,7 +39,7 @@ export const registerComponentPropsMetas = (
nextPropsMetas.set(componentName, {
// order of initialProps must be preserved
initialProps: [...initialProps, ...requiredProps],
- props: propsMeta.props,
+ props,
});
}
registeredComponentPropsMetasStore.set(nextPropsMetas);
diff --git a/packages/react-sdk/src/components/component-meta.ts b/packages/react-sdk/src/components/component-meta.ts
index a0e0218f01..244d655de6 100644
--- a/packages/react-sdk/src/components/component-meta.ts
+++ b/packages/react-sdk/src/components/component-meta.ts
@@ -11,6 +11,7 @@ export type PresetStyle<Tag extends HtmlTags = HtmlTags> = Partial<
// so they can be exported separately and potentially tree-shaken
const WsComponentPropsMeta = z.object({
props: z.record(PropMeta),
+ // Props that will be always visible in properties panel.
initialProps: z.array(z.string()).optional(),
});
diff --git a/packages/sdk-components-react/src/__generated__/image.props.ts b/packages/sdk-components-react/src/__generated__/image.props.ts
index 1c9a859383..223dd15587 100644
--- a/packages/sdk-components-react/src/__generated__/image.props.ts
+++ b/packages/sdk-components-react/src/__generated__/image.props.ts
@@ -482,6 +482,5 @@ export const props: Record<string, PropMeta> = {
type: "string",
},
quality: { required: false, control: "number", type: "number" },
- loader: { required: true, control: "text", type: "string" },
optimize: { required: false, control: "boolean", type: "boolean" },
};
diff --git a/packages/sdk-components-react/src/__generated__/vimeo-preview-image.props.ts b/packages/sdk-components-react/src/__generated__/vimeo-preview-image.props.ts
index 1c9a859383..223dd15587 100644
--- a/packages/sdk-components-react/src/__generated__/vimeo-preview-image.props.ts
+++ b/packages/sdk-components-react/src/__generated__/vimeo-preview-image.props.ts
@@ -482,6 +482,5 @@ export const props: Record<string, PropMeta> = {
type: "string",
},
quality: { required: false, control: "number", type: "number" },
- loader: { required: true, control: "text", type: "string" },
optimize: { required: false, control: "boolean", type: "boolean" },
};
diff --git a/packages/sdk-components-react/src/image.tsx b/packages/sdk-components-react/src/image.tsx
index 85b4d38470..67bec45d85 100644
--- a/packages/sdk-components-react/src/image.tsx
+++ b/packages/sdk-components-react/src/image.tsx
@@ -40,7 +40,7 @@ const imagePlaceholderSvg = `data:image/svg+xml;base64,${btoa(`<svg
/>
</svg>`)}`;
-type Props = ComponentPropsWithoutRef<typeof WebstudioImage>;
+type Props = Omit<ComponentPropsWithoutRef<typeof WebstudioImage>, "loader">;
export const Image = forwardRef<ElementRef<typeof defaultTag>, Props>(
(props, ref) => {
diff --git a/packages/sdk-components-react/src/image.ws.tsx b/packages/sdk-components-react/src/image.ws.tsx
index 83e3c8573b..6cb71e3a5a 100644
--- a/packages/sdk-components-react/src/image.ws.tsx
+++ b/packages/sdk-components-react/src/image.ws.tsx
@@ -37,9 +37,6 @@ export const meta: WsComponentMeta = {
order: 0,
};
-// "loader" is our internal prop not intended to show up in the props panel
-const { loader, ...publicProps } = props;
-
// Automatically generated props don't have the right control.
export const propsOverrides = {
src: {
@@ -52,7 +49,7 @@ export const propsOverrides = {
export const propsMeta: WsComponentPropsMeta = {
props: {
- ...publicProps,
+ ...props,
...propsOverrides,
},
initialProps: ["src", "width", "height", "alt", "loading"],
diff --git a/packages/sdk-components-react/src/vimeo.ws.ts b/packages/sdk-components-react/src/vimeo.ws.ts
index 24cb98e92d..24d8da7f9d 100644
--- a/packages/sdk-components-react/src/vimeo.ws.ts
+++ b/packages/sdk-components-react/src/vimeo.ws.ts
@@ -49,7 +49,7 @@ export const meta: WsComponentMeta = {
value: { type: "keyword", value: "absolute" },
},
{
- property: "objectPosition",
+ property: "objectFit",
value: { type: "keyword", value: "cover" },
},
{
@@ -88,6 +88,11 @@ export const meta: WsComponentMeta = {
name: "alt",
value: "Vimeo video preview image",
},
+ {
+ type: "string",
+ name: "sizes",
+ value: "100vw",
+ },
],
},
{