Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

fix: allow deleting unknown instance without meta (#3488)

Bogdan Chadkin8a522f17059d
diff --git a/apps/builder/app/shared/instance-utils.test.ts b/apps/builder/app/shared/instance-utils.test.ts
index 954900978a..93a793605c 100644
--- a/apps/builder/app/shared/instance-utils.test.ts
+++ b/apps/builder/app/shared/instance-utils.test.ts
@@ -1230,6 +1230,21 @@ describe("delete instance", () => {
expect(data.dataSources).toEqual(new Map());
expect(data.resources).toEqual(new Map());
});
+
+ test("delete instance without meta", () => {
+ // body
+ // invalid
+ const instances = new Map([
+ createInstancePair("body", "Body", [{ type: "id", value: "invalid" }]),
+ createInstancePair("invalid", "Invalid", []),
+ ]);
+ $registeredComponentMetas.set(new Map());
+ const data = getWebstudioDataStub({ instances });
+ deleteInstanceMutable(data, ["invalid", "body"]);
+ expect(data.instances).toEqual(
+ new Map([createInstancePair("body", "Body", [])])
+ );
+ });
});
describe("extract webstudio fragment", () => {
diff --git a/apps/builder/app/shared/instance-utils.ts b/apps/builder/app/shared/instance-utils.ts
index 4ab6c783ef..67a45b9776 100644
--- a/apps/builder/app/shared/instance-utils.ts
+++ b/apps/builder/app/shared/instance-utils.ts
@@ -221,7 +221,7 @@ export const isInstanceDetachable = (
}
const meta = metas.get(instance.component);
if (meta === undefined) {
- return false;
+ return true;
}
return meta.detachable ?? true;
};