Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

fix: Use empty alt attribute by default (#3001)

Oleg Isonen918da3fb8670
diff --git a/packages/image/src/image-optimize.test.ts b/packages/image/src/image-optimize.test.ts
index 37b03b5135..f5e12edc61 100644
--- a/packages/image/src/image-optimize.test.ts
+++ b/packages/image/src/image-optimize.test.ts
@@ -158,7 +158,7 @@ describe("Image optimizations not applied", () => {
loader: createImageLoader({ imageBaseUrl: "/asset/image/" }),
});
- expect(imgAttr).toMatchInlineSnapshot(`null`);
+ expect(imgAttr).toMatchInlineSnapshot(`undefined`);
});
test("src is undefined", () => {
@@ -172,6 +172,6 @@ describe("Image optimizations not applied", () => {
loader: createImageLoader({ imageBaseUrl: "/asset/image/" }),
});
- expect(imgAttr).toMatchInlineSnapshot(`null`);
+ expect(imgAttr).toMatchInlineSnapshot(`undefined`);
});
});
diff --git a/packages/image/src/image-optimize.ts b/packages/image/src/image-optimize.ts
index fd004902af..46e94b015e 100644
--- a/packages/image/src/image-optimize.ts
+++ b/packages/image/src/image-optimize.ts
@@ -238,11 +238,13 @@ export const getImageAttributes = (props: {
quality: string | number | undefined;
loader: ImageLoader;
optimize: boolean;
-}): {
- src: string;
- srcSet?: string;
- sizes?: string;
-} | null => {
+}):
+ | {
+ src: string;
+ srcSet?: string;
+ sizes?: string;
+ }
+ | undefined => {
const width = getInt(props.width);
const quality = Math.max(
Math.min(getInt(props.quality) ?? DEFAULT_QUALITY, 100),
@@ -279,6 +281,4 @@ export const getImageAttributes = (props: {
return resAttrs;
}
-
- return null;
};
diff --git a/packages/image/src/image.tsx b/packages/image/src/image.tsx
index 5f0dcd037d..f12a904b44 100644
--- a/packages/image/src/image.tsx
+++ b/packages/image/src/image.tsx
@@ -33,6 +33,7 @@ export const Image = forwardRef<ElementRef<typeof defaultTag>, ImageProps>(
return (
<img
+ alt=""
{...imageProps}
{...imageAttributes}
decoding={decoding}