Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

fix: make publish error more descriptive (#4480)

Bogdan Chadkin98bb309c08c3
diff --git a/apps/builder/app/builder/features/topbar/publish.tsx b/apps/builder/app/builder/features/topbar/publish.tsx
index bb2ea8e51d..ee8fd5fd91 100644
--- a/apps/builder/app/builder/features/topbar/publish.tsx
+++ b/apps/builder/app/builder/features/topbar/publish.tsx
@@ -66,7 +66,7 @@ import { $openProjectSettings } from "~/shared/nano-states/project-settings";
type ChangeProjectDomainProps = {
project: Project;
projectState: "idle" | "submitting";
- refresh: () => void;
+ refresh: () => Promise<void>;
};
const ChangeProjectDomain = ({
@@ -206,7 +206,7 @@ const Publish = ({
refresh: () => Promise<void>;
}) => {
- const [publishError, setPublishError] = useState<string | undefined>();
+ const [publishError, setPublishError] = useState<undefined | string>();
const [isPublishing, setIsPublishing] = useOptimistic(false);
const buttonRef = useRef<HTMLButtonElement>(null);
const [hasSelectedDomains, setHasSelectedDomains] = useState(false);
@@ -276,8 +276,19 @@ const Publish = ({
if (publishResult.success === false) {
console.error(publishResult.error);
- setPublishError(publishResult.error);
- toast.error(publishResult.error);
+ let error = publishResult.error;
+ if (publishResult.error === "NOT_IMPLEMENTED") {
+ error =
+ `Build data for publishing has been successfully created.\n\n` +
+ `Use Webstudio CLI to generate the code.\n\n` +
+ `https://docs.webstudio.is/university/self-hosting/cli`;
+ }
+ setPublishError(error);
+ if (publishResult.error === "NOT_IMPLEMENTED") {
+ toast.info(error);
+ } else {
+ toast.error(error);
+ }
if (process.env.NODE_ENV === "development") {
// Refresh locally as it's always an error
diff --git a/packages/trpc-interface/src/shared/deployment.ts b/packages/trpc-interface/src/shared/deployment.ts
index 2dc10dc169..db4de930e9 100644
--- a/packages/trpc-interface/src/shared/deployment.ts
+++ b/packages/trpc-interface/src/shared/deployment.ts
@@ -33,10 +33,10 @@ export const deploymentRouter = router({
publish: procedure
.input(PublishInput)
.output(Output)
- .mutation(async ({ input }) => {
+ .mutation(() => {
return {
success: false,
- error: `Not implemented, use buildId=${input.buildId}`,
+ error: "NOT_IMPLEMENTED",
};
}),
});