Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

fix: Create page templates without explicit titles (#6240)

Oleg Isonen9a4ee579296f
diff --git a/packages/project-build/src/runtime/page-copy.test.tsx b/packages/project-build/src/runtime/page-copy.test.tsx
index 4bdedd8b77..db22ff4ff0 100644
--- a/packages/project-build/src/runtime/page-copy.test.tsx
+++ b/packages/project-build/src/runtime/page-copy.test.tsx
@@ -5,6 +5,7 @@ import {
encodeDataVariableId,
elementComponent,
getHomePage,
+ pageTemplate,
type Asset,
type DataSource,
type Instance,
@@ -1587,6 +1588,29 @@ describe("insert page copy", () => {
});
});
+ test("creates a valid page template when title is omitted", () => {
+ const data = getWebstudioDataStub();
+ const ids = ["templateId", "templateBodyId"];
+
+ const result = createPageTemplate(
+ data,
+ { name: "Landing Template" },
+ { createId: () => ids.shift() ?? "extraId" }
+ );
+ const updated = applyBuilderPatchTransactions(data, [
+ { id: "create-page-template", payload: result.payload },
+ ]).state as WebstudioData;
+
+ expect(
+ pageTemplate.parse(updated.pages.pageTemplates?.get("templateId"))
+ ).toEqual(
+ expect.objectContaining({
+ name: "Landing Template",
+ title: '"Landing Template"',
+ })
+ );
+ });
+
test("updates page templates through page field validation semantics", () => {
const pages = createDefaultPages({ rootInstanceId: "homeBodyId" });
pages.pageTemplates = new Map([
diff --git a/packages/project-build/src/runtime/page-copy.ts b/packages/project-build/src/runtime/page-copy.ts
index 0a0a3543d0..096922cba9 100644
--- a/packages/project-build/src/runtime/page-copy.ts
+++ b/packages/project-build/src/runtime/page-copy.ts
@@ -1020,7 +1020,7 @@ export const createPageTemplate = (
draft.pages.pageTemplates.set(templateId, {
id: templateId,
name: input.name,
- title: input.title ?? "",
+ title: input.title ?? JSON.stringify(input.name),
rootInstanceId,
meta:
input.meta === undefined