Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

feat: Add all input types (#2901)

Oleg Isonen9efc76489853
diff --git a/packages/sdk-components-react/src/__generated__/input.props.ts b/packages/sdk-components-react/src/__generated__/input.props.ts
index 414006cdb1..fb99d03167 100644
--- a/packages/sdk-components-react/src/__generated__/input.props.ts
+++ b/packages/sdk-components-react/src/__generated__/input.props.ts
@@ -735,7 +735,24 @@ export const props: Record<string, PropMeta> = {
required: false,
control: "select",
type: "string",
- options: ["number", "text", "email", "password", "tel", "url"],
+ defaultValue: "text",
+ options: [
+ "number",
+ "search",
+ "time",
+ "text",
+ "hidden",
+ "color",
+ "date",
+ "datetime-local",
+ "email",
+ "month",
+ "password",
+ "range",
+ "tel",
+ "url",
+ "week",
+ ],
description:
"Specifies the type of data that this input will accept and helps the browser provide appropriate validation and formatting for that input type.",
},
diff --git a/packages/sdk-components-react/src/heading.tsx b/packages/sdk-components-react/src/heading.tsx
index 3d62a580d6..dc321e881c 100644
--- a/packages/sdk-components-react/src/heading.tsx
+++ b/packages/sdk-components-react/src/heading.tsx
@@ -8,7 +8,9 @@ type Props = ComponentProps<typeof defaultTag> & {
};
export const Heading = forwardRef<ElementRef<typeof defaultTag>, Props>(
- ({ tag: Tag = defaultTag, children, ...props }, ref) => {
+ ({ tag = defaultTag, children, ...props }, ref) => {
+ // Can't map it in the destricturing, default type won't be generated correctly
+ const Tag = tag;
return (
<Tag {...props} ref={ref}>
{children ?? "Heading you can edit"}
diff --git a/packages/sdk-components-react/src/input.tsx b/packages/sdk-components-react/src/input.tsx
index 5f48278269..fe3e6d2481 100644
--- a/packages/sdk-components-react/src/input.tsx
+++ b/packages/sdk-components-react/src/input.tsx
@@ -5,9 +5,26 @@ export const defaultTag = "input";
export const Input = forwardRef<
ElementRef<typeof defaultTag>,
ComponentProps<typeof defaultTag> & {
- type?: "text" | "email" | "password" | "number" | "tel" | "url";
+ type?:
+ | "color"
+ | "date"
+ | "datetime-local"
+ | "email"
+ | "hidden"
+ | "month"
+ | "number"
+ | "password"
+ | "range"
+ | "search"
+ | "tel"
+ | "text"
+ | "time"
+ | "url"
+ | "week";
}
// Make sure children are not passed down to an input, because this will result in error.
->(({ children: _children, ...props }, ref) => <input {...props} ref={ref} />);
+>(({ children: _children, type = "text", ...props }, ref) => (
+ <input {...props} type={type} ref={ref} />
+));
Input.displayName = "Input";
diff --git a/packages/sdk-components-react/src/text.tsx b/packages/sdk-components-react/src/text.tsx
index 81834a29fb..085ee74b08 100644
--- a/packages/sdk-components-react/src/text.tsx
+++ b/packages/sdk-components-react/src/text.tsx
@@ -9,7 +9,9 @@ type Props = ComponentProps<typeof defaultTag> & {
};
export const Text = forwardRef<ElementRef<typeof defaultTag>, Props>(
- ({ tag: Tag = defaultTag, children, ...props }, ref) => {
+ ({ tag = defaultTag, children, ...props }, ref) => {
+ // Can't map it in the destricturing, default type won't be generated correctly
+ const Tag = tag;
return (
<Tag {...props} ref={ref}>
{children ?? "The text you can edit"}
diff --git a/packages/sdk-components-react/src/vimeo.tsx b/packages/sdk-components-react/src/vimeo.tsx
index 0c66d9f0ac..aa8d43cc0a 100644
--- a/packages/sdk-components-react/src/vimeo.tsx
+++ b/packages/sdk-components-react/src/vimeo.tsx
@@ -318,7 +318,7 @@ export const Vimeo = forwardRef<Ref, Props>(
(
{
url,
- loading,
+ loading = "lazy",
autoplay = false,
autopause = true,
backgroundMode = false,