Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

No content Nav menu items (#2188)

Ivan Starkovaaaa50f10721
diff --git a/packages/sdk-components-react-radix/src/navigation-menu.tsx b/packages/sdk-components-react-radix/src/navigation-menu.tsx
index 8cd1bf6b64..96cbccfab1 100644
--- a/packages/sdk-components-react-radix/src/navigation-menu.tsx
+++ b/packages/sdk-components-react-radix/src/navigation-menu.tsx
@@ -107,11 +107,21 @@ export const hooksNavigationMenu: Hook = {
`${namespace}:NavigationMenu`
);
+ const menuItem = getClosestInstance(
+ event.instancePath,
+ instance,
+ `${namespace}:NavigationMenuItem`
+ );
+
+ if (menuItem === undefined || menu === undefined) {
+ return;
+ }
+
const contentValue =
- context.getPropValue(instance.id, "value") ??
- context.indexesWithinAncestors.get(instance.id)?.toString();
+ context.getPropValue(menuItem.id, "value") ??
+ context.indexesWithinAncestors.get(menuItem.id)?.toString();
- if (menu && contentValue) {
+ if (contentValue) {
context.setPropVariable(menu.id, "value", contentValue);
}
}
diff --git a/packages/sdk-components-react-radix/src/navigation-menu.ws.ts b/packages/sdk-components-react-radix/src/navigation-menu.ws.ts
index 7357253b29..c4adfb703c 100644
--- a/packages/sdk-components-react-radix/src/navigation-menu.ws.ts
+++ b/packages/sdk-components-react-radix/src/navigation-menu.ws.ts
@@ -178,6 +178,33 @@ const navItemsList = (props: {
},
];
+const menuItemLink = (props: {
+ title: string;
+}): NonNullable<WsComponentMeta["template"]> => [
+ {
+ type: "instance",
+ component: "NavigationMenuItem",
+ children: [
+ {
+ type: "instance",
+ component: "NavigationMenuLink",
+ children: [
+ {
+ type: "instance",
+ component: "Link",
+ styles: [
+ getButtonStyles("ghost", "sm"),
+ tc.noUnderline(),
+ tc.text("current"),
+ ].flat(),
+ children: [{ type: "text", value: props.title }],
+ },
+ ],
+ },
+ ],
+ },
+];
+
const menuItem = (props: {
title: string;
children: NonNullable<WsComponentMeta["template"]>;
@@ -354,6 +381,7 @@ export const metaNavigationMenu: WsComponentMeta = {
...navItemsList({ count: 3, offset: 6 }),
],
}),
+ ...menuItemLink({ title: "Standalone" }),
],
},
@@ -454,7 +482,10 @@ export const metaNavigationMenuLink: WsComponentMeta = {
type: "container",
stylable: false,
icon: BoxIcon,
- requiredAncestors: ["NavigationMenuContent"],
+ // https://github.com/webstudio-is/webstudio-builder/issues/2193
+ // requiredAncestors: ["NavigationMenuContent", "NavigationMenuItem"],
+ // Temporary restrict to NavigationMenu
+ requiredAncestors: ["NavigationMenu"],
presetStyle,
label: "Accessible Link Wrapper",
};