Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

feat: Rename "remove" to "detach" in token menu (#4814)

Oleg Isonenaf5d61dfc7bc
diff --git a/apps/builder/app/builder/features/style-panel/style-source-section.tsx b/apps/builder/app/builder/features/style-panel/style-source-section.tsx
index 6171499d48..96963ae012 100644
--- a/apps/builder/app/builder/features/style-panel/style-source-section.tsx
+++ b/apps/builder/app/builder/features/style-panel/style-source-section.tsx
@@ -422,7 +422,7 @@ export const StyleSourcesSection = () => {
setEditingItem(id);
}}
onClearStyles={clearStyles}
- onRemoveItem={(id) => {
+ onDetachItem={(id) => {
removeStyleSourceFromInstance(id);
}}
onDeleteItem={(id) => {
diff --git a/apps/builder/app/builder/features/style-panel/style-source/style-source-input.stories.tsx b/apps/builder/app/builder/features/style-panel/style-source/style-source-input.stories.tsx
index 59d2b4975c..816126b15e 100644
--- a/apps/builder/app/builder/features/style-panel/style-source/style-source-input.stories.tsx
+++ b/apps/builder/app/builder/features/style-panel/style-source/style-source-input.stories.tsx
@@ -77,7 +77,7 @@ export const Basic: StoryFn<typeof StyleSourceInput> = () => {
onSelectAutocompleteItem={(item) => {
setValue([...value, item]);
}}
- onRemoveItem={(itemId) => {
+ onDetachItem={(itemId) => {
removeItem(itemId, value, setValue);
}}
onSort={setValue}
@@ -108,7 +108,7 @@ export const WithTruncatedItem: StoryFn<typeof StyleSourceInput> = () => {
onSelectAutocompleteItem={(item) => {
setValue([...value, item]);
}}
- onRemoveItem={(itemToRemove) => {
+ onDetachItem={(itemToRemove) => {
removeItem(itemToRemove, value, setValue);
}}
onSort={setValue}
@@ -148,7 +148,7 @@ export const Complete: StoryFn<typeof StyleSourceInput> = () => {
onSelectAutocompleteItem={(item) => {
setValue([...value, item]);
}}
- onRemoveItem={(itemToRemove) => {
+ onDetachItem={(itemToRemove) => {
removeItem(itemToRemove, value, setValue);
}}
onChangeItem={(changedItem) => {
diff --git a/apps/builder/app/builder/features/style-panel/style-source/style-source-input.tsx b/apps/builder/app/builder/features/style-panel/style-source/style-source-input.tsx
index ea12fffefc..1c2de9ac62 100644
--- a/apps/builder/app/builder/features/style-panel/style-source/style-source-input.tsx
+++ b/apps/builder/app/builder/features/style-panel/style-source/style-source-input.tsx
@@ -277,7 +277,7 @@ type StyleSourceInputProps<Item extends IntermediateItem> = {
editingItemId?: Item["id"];
componentStates?: ComponentState[];
onSelectAutocompleteItem?: (item: Item) => void;
- onRemoveItem?: (id: Item["id"]) => void;
+ onDetachItem?: (id: Item["id"]) => void;
onDeleteItem?: (id: Item["id"]) => void;
onClearStyles?: (id: Item["id"]) => void;
onDuplicateItem?: (id: Item["id"]) => void;
@@ -351,7 +351,7 @@ const renderMenuItems = (props: {
onConvertToToken?: (itemId: IntermediateItem["id"]) => void;
onDisable?: (itemId: IntermediateItem["id"]) => void;
onEnable?: (itemId: IntermediateItem["id"]) => void;
- onRemove?: (itemId: IntermediateItem["id"]) => void;
+ onDetach?: (itemId: IntermediateItem["id"]) => void;
onDelete?: (itemId: IntermediateItem["id"]) => void;
onClearStyles?: (itemId: IntermediateItem["id"]) => void;
}) => {
@@ -404,8 +404,8 @@ const renderMenuItems = (props: {
)}
*/}
{props.item.source !== "local" && (
- <DropdownMenuItem onSelect={() => props.onRemove?.(props.item.id)}>
- Remove
+ <DropdownMenuItem onSelect={() => props.onDetach?.(props.item.id)}>
+ Detach
</DropdownMenuItem>
)}
{props.item.source !== "local" && (
@@ -537,7 +537,7 @@ export const StyleSourceInput = (
) {
const item = value[value.length - 2];
if (item) {
- props.onRemoveItem?.(item.id);
+ props.onDetachItem?.(item.id);
}
}
},
@@ -568,7 +568,7 @@ export const StyleSourceInput = (
onEnable: props.onEnableItem,
onDisable: props.onDisableItem,
onEdit: props.onEditItem,
- onRemove: props.onRemoveItem,
+ onDetach: props.onDetachItem,
onDelete: props.onDeleteItem,
onClearStyles: props.onClearStyles,
})