Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

Improve drag performance if style panel is open (#1606)

Ivan Starkovbcdd13d7ad49
diff --git a/apps/builder/app/builder/features/inspector/inspector.tsx b/apps/builder/app/builder/features/inspector/inspector.tsx
index 1dd4323b42..ab7c809a78 100644
--- a/apps/builder/app/builder/features/inspector/inspector.tsx
+++ b/apps/builder/app/builder/features/inspector/inspector.tsx
@@ -17,10 +17,7 @@ import { StylePanel } from "~/builder/features/style-panel";
import { PropsPanelContainer } from "~/builder/features/props-panel";
import { FloatingPanelProvider } from "~/builder/shared/floating-panel";
import { theme } from "@webstudio-is/design-system";
-import {
- selectedInstanceStore,
- useDragAndDropState,
-} from "~/shared/nano-states";
+import { selectedInstanceStore, isDraggingStore } from "~/shared/nano-states";
import { SettingsPanel } from "../settings-panel";
import { NavigatorTree } from "~/builder/shared/navigator-tree";
import type { Settings } from "~/builder/shared/client-settings";
@@ -39,9 +36,8 @@ const contentStyle = {
export const Inspector = ({ publish, navigatorLayout }: InspectorProps) => {
const selectedInstance = useStore(selectedInstanceStore);
const tabsRef = useRef<HTMLDivElement>(null);
- const [dragAndDropState] = useDragAndDropState();
-
const [tab, setTab] = useState("style");
+ const isDragging = useStore(isDraggingStore);
useEffect(() => {
if (selectedInstance?.component === "Slot") {
@@ -51,7 +47,7 @@ export const Inspector = ({ publish, navigatorLayout }: InspectorProps) => {
}
}, [selectedInstance, tab]);
- if (navigatorLayout === "docked" && dragAndDropState.isDragging) {
+ if (navigatorLayout === "docked" && isDragging) {
return <NavigatorTree />;
}
diff --git a/apps/builder/app/shared/nano-states/nano-states.ts b/apps/builder/app/shared/nano-states/nano-states.ts
index 585921278e..8cab4ab3e6 100644
--- a/apps/builder/app/shared/nano-states/nano-states.ts
+++ b/apps/builder/app/shared/nano-states/nano-states.ts
@@ -365,7 +365,13 @@ export type DragAndDropState = {
dragPayload?: DragStartPayload;
placementIndicator?: Placement;
};
+
const dragAndDropStateContainer = atom<DragAndDropState>({
isDragging: false,
});
export const useDragAndDropState = () => useValue(dragAndDropStateContainer);
+
+export const isDraggingStore = computed(
+ [dragAndDropStateContainer],
+ (state) => state.isDragging
+);