Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

Hide props and styles tabs for html embed (#1686)

Bogdan Chadkinc08e57cdbdf4
diff --git a/apps/builder/app/builder/features/inspector/inspector.tsx b/apps/builder/app/builder/features/inspector/inspector.tsx
index f18dbbbea7..251b4a09f7 100644
--- a/apps/builder/app/builder/features/inspector/inspector.tsx
+++ b/apps/builder/app/builder/features/inspector/inspector.tsx
@@ -22,6 +22,7 @@ import {
selectedInstanceStore,
isDraggingStore,
registeredComponentMetasStore,
+ registeredComponentPropsMetasStore,
} from "~/shared/nano-states";
import { SettingsPanel } from "../settings-panel";
import { NavigatorTree } from "~/builder/shared/navigator-tree";
@@ -71,6 +72,8 @@ export const Inspector = ({ publish, navigatorLayout }: InspectorProps) => {
const tabsRef = useRef<HTMLDivElement>(null);
const [tab, setTab] = useState("style");
const isDragging = useStore(isDraggingStore);
+ const metas = useStore(registeredComponentMetasStore);
+ const propsMetas = useStore(registeredComponentPropsMetasStore);
if (navigatorLayout === "docked" && isDragging) {
return <NavigatorTree />;
@@ -89,6 +92,18 @@ export const Inspector = ({ publish, navigatorLayout }: InspectorProps) => {
);
}
+ const meta = metas.get(selectedInstance.component);
+ const propsMeta = propsMetas.get(selectedInstance.component);
+ const isStyleTabVisible = meta?.stylable ?? true;
+ const isPropsTabVisible =
+ propsMeta && Object.keys(propsMeta.props).length !== 0;
+
+ const availableTabs = [
+ isStyleTabVisible ? "style" : undefined,
+ isPropsTabVisible ? "props" : undefined,
+ "settings",
+ ].filter((tab) => tab);
+
return (
<EnhancedTooltipProvider
delayDuration={1600}
@@ -98,18 +113,18 @@ export const Inspector = ({ publish, navigatorLayout }: InspectorProps) => {
<FloatingPanelProvider container={tabsRef}>
<PanelTabs
ref={tabsRef}
- value={selectedInstance?.component === "Slot" ? "settings" : tab}
+ value={availableTabs.includes(tab) ? tab : availableTabs[0]}
onValueChange={setTab}
asChild
>
<Flex direction="column">
<PanelTabsList>
- {selectedInstance.component !== "Slot" && (
- <>
- <PanelTabsTrigger value="style">Style</PanelTabsTrigger>
- {/* @note: events would be part of props */}
- <PanelTabsTrigger value="props">Properties</PanelTabsTrigger>
- </>
+ {isStyleTabVisible && (
+ <PanelTabsTrigger value="style">Style</PanelTabsTrigger>
+ )}
+ {/* @note: events would be part of props */}
+ {isPropsTabVisible && (
+ <PanelTabsTrigger value="props">Properties</PanelTabsTrigger>
)}
<PanelTabsTrigger value="settings">Settings</PanelTabsTrigger>
</PanelTabsList>
diff --git a/packages/react-sdk/src/components/component-meta.ts b/packages/react-sdk/src/components/component-meta.ts
index 400cfe1b91..6ed9c27aec 100644
--- a/packages/react-sdk/src/components/component-meta.ts
+++ b/packages/react-sdk/src/components/component-meta.ts
@@ -57,6 +57,7 @@ const WsComponentMeta = z.object({
]),
requiredAncestors: z.optional(z.array(z.string())),
invalidAncestors: z.optional(z.array(z.string())),
+ stylable: z.optional(z.boolean()),
label: z.string(),
icon: z.string(),
presetStyle: z.optional(z.record(z.string(), EmbedTemplateStyleDecl)),
diff --git a/packages/react-sdk/src/components/fragment.ws.ts b/packages/react-sdk/src/components/fragment.ws.ts
index 404978459b..8a5dc0c24c 100644
--- a/packages/react-sdk/src/components/fragment.ws.ts
+++ b/packages/react-sdk/src/components/fragment.ws.ts
@@ -4,6 +4,7 @@ export const meta: WsComponentMeta = {
type: "container",
label: "Fragment",
icon: "",
+ stylable: false,
};
export const propsMeta: WsComponentPropsMeta = {
diff --git a/packages/react-sdk/src/components/html-embed.ws.ts b/packages/react-sdk/src/components/html-embed.ws.ts
index 34b76a7ab4..e7847ed9a9 100644
--- a/packages/react-sdk/src/components/html-embed.ws.ts
+++ b/packages/react-sdk/src/components/html-embed.ws.ts
@@ -7,6 +7,7 @@ export const meta: WsComponentMeta = {
type: "embed",
label: "HTML Embed",
icon: EmbedIcon,
+ stylable: false,
};
export const propsMeta: WsComponentPropsMeta = {
diff --git a/packages/react-sdk/src/components/slot.ws.ts b/packages/react-sdk/src/components/slot.ws.ts
index 3a49184152..7578c1b596 100644
--- a/packages/react-sdk/src/components/slot.ws.ts
+++ b/packages/react-sdk/src/components/slot.ws.ts
@@ -6,6 +6,7 @@ export const meta: WsComponentMeta = {
type: "container",
label: "Slot",
icon: SlotComponentIcon,
+ stylable: false,
};
export const propsMeta: WsComponentPropsMeta = {