Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

fix: Make accordion forceMount template-scoped (#5819)

Oleg Isonenc8d9a2702301
diff --git a/packages/sdk-components-react-radix/src/__generated__/accordion.props.ts b/packages/sdk-components-react-radix/src/__generated__/accordion.props.ts
index 3f547d482d..e2344d6fd0 100644
--- a/packages/sdk-components-react-radix/src/__generated__/accordion.props.ts
+++ b/packages/sdk-components-react-radix/src/__generated__/accordion.props.ts
@@ -70,6 +70,5 @@ export const propsAccordionContent: Record<string, PropMeta> = {
required: false,
control: "boolean",
type: "boolean",
- defaultValue: true,
},
};
diff --git a/packages/sdk-components-react-radix/src/accordion.template.tsx b/packages/sdk-components-react-radix/src/accordion.template.tsx
index fd1ad8ae41..af1d68f4ad 100644
--- a/packages/sdk-components-react-radix/src/accordion.template.tsx
+++ b/packages/sdk-components-react-radix/src/accordion.template.tsx
@@ -76,10 +76,12 @@ const createAccordionItem = (triggerText: string, contentText: string) => {
font-size: ${fontSize.sm};
line-height: ${fontSizeLineHeight.sm};
transition: ${transition.all};
- height: var(--radix-collapsible-content-height);
&[data-state="closed"] {
height: 0;
}
+ &[data-state="open"] {
+ height: var(--radix-accordion-content-height);
+ }
`}
>
{new PlaceholderValue(contentText)}
diff --git a/packages/sdk-components-react-radix/src/accordion.tsx b/packages/sdk-components-react-radix/src/accordion.tsx
index b648c2d84e..15e4c821db 100644
--- a/packages/sdk-components-react-radix/src/accordion.tsx
+++ b/packages/sdk-components-react-radix/src/accordion.tsx
@@ -57,15 +57,10 @@ export const AccordionTrigger: ForwardRefExoticComponent<
RefAttributes<HTMLButtonElement>
> = Trigger;
-export const AccordionContent = forwardRef<
- HTMLDivElement,
- Omit<ComponentPropsWithoutRef<typeof Content>, "asChild" | "forceMount"> & {
- forceMount?: boolean;
- }
->(({ forceMount = true, ...props }, ref) => {
- const contentProps = forceMount ? { forceMount: true as const } : {};
- return <Content ref={ref} {...contentProps} {...props} />;
-});
+export const AccordionContent: ForwardRefExoticComponent<
+ Omit<ComponentProps<typeof Content>, "asChild"> &
+ RefAttributes<HTMLDivElement>
+> = Content;
/* BUILDER HOOKS */