Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.
TypeScript accessibilityalternativecloudflarecloudflare-workersdesignfreefrontendopen-sourceradix-uireactremixweb-developmentwebflowwebsite-builderwebsite-developmentwebsiteswebstudio
fix: stop evaluating page settings for sitemaps (#6614)
Oleg Isonenc94e5a94c18a
diff --git a/packages/sdk/src/page-utils.test.ts b/packages/sdk/src/page-utils.test.tsindex 0dc39b6c48..205272585f 100644--- a/packages/sdk/src/page-utils.test.ts+++ b/packages/sdk/src/page-utils.test.ts@@ -202,6 +202,28 @@ describe("findParentFolderByChildId", () => {});describe("getStaticSiteMapXml", () => {+ test("does not execute page settings while checking sitemap eligibility", () => {+ const marker = "__webstudioSitemapTestMarker";+ const globals = globalThis as Record<string, unknown>;+ const pagesWithExpression: Pages = {+ ...pages,+ pages: new Map(pages.pages).set("home", {+ ...pages.pages.get("home")!,+ meta: { excludePageFromSearch: `(globalThis.${marker} = true)` },+ }),+ };++ try {+ expect(globals[marker]).toBeUndefined();+ expect(getStaticSiteMapXml(pagesWithExpression, "2026-04-30")).toEqual(+ getStaticSiteMapXml(pages, "2026-04-30")+ );+ expect(globals[marker]).toBeUndefined();+ } finally {+ delete globals[marker];+ }+ });+test("includes html pages and excludes xml and text pages", () => {const pagesWithDocumentTypes: Pages = {...pages,diff --git a/packages/sdk/src/page-utils.ts b/packages/sdk/src/page-utils.tsindex 93d0a285e8..a8b29b3419 100644--- a/packages/sdk/src/page-utils.ts+++ b/packages/sdk/src/page-utils.ts@@ -1,4 +1,4 @@-import { executeExpression } from "./expression";+import { parseJsonExpression } from "@webstudio-is/expression";import {isPageDraft,type Folder,@@ -157,7 +157,7 @@ export const isPageEligibleForSitemap = (page: Page) =>(page.meta.documentType ?? "html") === "html" &&// A dynamic expression cannot be evaluated without its resource data, so it// remains eligible just as it did for static sitemap generation.- executeExpression(page.meta.excludePageFromSearch) !== true;+ parseJsonExpression(page.meta.excludePageFromSearch) !== true;export const getStaticSiteMapXml = (pages: Pages, updatedAt: string) => {const allPages = getPublishablePages(pages);