Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.
TypeScript accessibilityalternativecloudflarecloudflare-workersdesignfreefrontendopen-sourceradix-uireactremixweb-developmentwebflowwebsite-builderwebsite-developmentwebsiteswebstudio
Instance name bugs (#1200)
Oleg Isonenca33d421a25d
diff --git a/apps/builder/app/builder/features/settings-panel/settings-panel.tsx b/apps/builder/app/builder/features/settings-panel/settings-panel.tsxindex c48ddbbb54..8863531af0 100644--- a/apps/builder/app/builder/features/settings-panel/settings-panel.tsx+++ b/apps/builder/app/builder/features/settings-panel/settings-panel.tsx@@ -16,6 +16,8 @@ export const SettingsPanel = () => {<Flex gap="1" direction="column" grow><Label>Instance Name</Label><TextField+ /* Key is required, otherwise when label is undefined, previous value stayed */+ key={selectedInstance.id}onBlur={handleBlur}onKeyDown={handleKeyDown}placeholder={label}diff --git a/apps/builder/app/builder/features/settings-panel/use-settings-logic.ts b/apps/builder/app/builder/features/settings-panel/use-settings-logic.tsindex 64aa11d898..759a44c294 100644--- a/apps/builder/app/builder/features/settings-panel/use-settings-logic.ts+++ b/apps/builder/app/builder/features/settings-panel/use-settings-logic.ts@@ -7,14 +7,29 @@ import {} from "react";import { instancesStore, selectedInstanceStore } from "~/shared/nano-states";-type SettingUpdate = { label?: string };+type Setting = "label";+type Value = string;++type Operation =+ | {+ operation: "delete";+ property: Setting;+ }+ | {+ operation: "set";+ property: Setting;+ value: Value;+ };export const useSettingsLogic = () => {- const changes = useRef<SettingUpdate>({});+ const updates = useRef<Array<Operation>>([]);- const setLabel = (value: SettingUpdate[keyof SettingUpdate]) => {- // Empty string should be replaced with `undefined` so that we can render default label- changes.current.label = value || undefined;+ const setLabel = (value?: Value) => {+ if (value === undefined) {+ updates.current.push({ operation: "delete", property: "label" });+ return;+ }+ updates.current.push({ operation: "set", property: "label", value });};const updateLabel = useCallback(() => {@@ -24,8 +39,15 @@ export const useSettingsLogic = () => {}store.createTransaction([instancesStore], (instances) => {const instance = instances.get(selectedInstance.id);- if (instance !== undefined) {- instance.label = changes.current.label;+ if (instance === undefined) {+ return;+ }+ for (const update of updates.current) {+ if (update.operation === "delete") {+ delete instance.label;+ continue;+ }+ instance.label = update.value;}});}, []);