Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

fix: remove unusable filter from allowedArrayMethods in expressions (#5627)

Oleg Isonencc4c9c6565e6
diff --git a/apps/builder/app/builder/shared/expression-editor.test.ts b/apps/builder/app/builder/shared/expression-editor.test.ts
index 97dc2eaea0..063e7407d6 100644
--- a/apps/builder/app/builder/shared/expression-editor.test.ts
+++ b/apps/builder/app/builder/shared/expression-editor.test.ts
@@ -64,7 +64,6 @@ describe("generateCompletionOptions", () => {
expect(labels).toContain("1");
expect(labels).toContain("2");
expect(labels).toContain("length");
- expect(labels).toContain("filter()");
expect(labels).toContain("slice()");
// Check specific values
@@ -76,22 +75,6 @@ describe("generateCompletionOptions", () => {
});
});
- test("includes array methods when searching", () => {
- const target = [1, 2, 3];
- const options = generateCompletionOptions({
- target,
- pathName: "fil",
- pathLength: 1,
- });
-
- const methodOptions = options.filter((o) => o.type === "method");
- expect(methodOptions).toContainEqual({
- label: "filter()",
- detail: "array method",
- type: "method",
- });
- });
-
test("filters length property by pathName", () => {
const target = [1, 2, 3, 4, 5];
const options = generateCompletionOptions({
@@ -233,7 +216,6 @@ describe("generateCompletionOptions", () => {
// Empty array has length and all array methods
const labels = options.map((o) => o.label);
expect(labels).toContain("length");
- expect(labels).toContain("filter()");
expect(labels).toContain("slice()");
const lengthOption = options.find((o) => o.label === "length");
diff --git a/packages/sdk/src/expression.test.ts b/packages/sdk/src/expression.test.ts
index aeab795d0e..8a2836f28e 100644
--- a/packages/sdk/src/expression.test.ts
+++ b/packages/sdk/src/expression.test.ts
@@ -456,12 +456,6 @@ describe("transpile expression", () => {
executable: true,
})
).toEqual("items?.map?.(item => item?.id)");
- expect(
- transpileExpression({
- expression: "data.list.filter(x => x > 0)",
- executable: true,
- })
- ).toEqual("data?.list?.filter?.(x => x > 0)");
});
test("transpile nested method calls with optional chaining", () => {
diff --git a/packages/sdk/src/expression.ts b/packages/sdk/src/expression.ts
index ad75bda98f..18364b93a4 100644
--- a/packages/sdk/src/expression.ts
+++ b/packages/sdk/src/expression.ts
@@ -43,13 +43,7 @@ export const allowedStringMethods = new Set([
"toLocaleUpperCase",
]);
-export const allowedArrayMethods = new Set([
- "at",
- "includes",
- "join",
- "slice",
- "filter",
-]);
+export const allowedArrayMethods = new Set(["at", "includes", "join", "slice"]);
export const lintExpression = ({
expression,