Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.
TypeScript accessibilityalternativecloudflarecloudflare-workersdesignfreefrontendopen-sourceradix-uireactremixweb-developmentwebflowwebsite-builderwebsite-developmentwebsiteswebstudio
Don't react to isDragging/isDropTarget (#1164)
Oleg Isonendc487531d0c7
diff --git a/packages/design-system/src/components/tree/tree-node.tsx b/packages/design-system/src/components/tree/tree-node.tsxindex 049d98e023..5a9a8c8377 100644--- a/packages/design-system/src/components/tree/tree-node.tsx+++ b/packages/design-system/src/components/tree/tree-node.tsx@@ -209,6 +209,36 @@ const ItemContainer = styled(Flex, {},});+const useScrollIntoView = (+ element: HTMLElement | null,+ {+ isDragging,+ isDropTarget,+ isSelected,+ }: { isDragging: boolean; isDropTarget: boolean; isSelected: boolean }+) => {+ const isDraggingRef = useRef(isDragging);+ isDraggingRef.current = isDragging;+ const isDropTargetRef = useRef(isDropTarget);+ isDropTargetRef.current = isDropTarget;+ const elementRef = useRef(element);+ elementRef.current = element;++ // Scroll the selected button into view when selected from canvas.+ useEffect(() => {+ if (+ isSelected &&+ isDraggingRef.current === false &&+ isDropTargetRef.current === false+ ) {+ elementRef.current?.scrollIntoView({+ behavior: "smooth",+ block: "nearest",+ });+ }+ }, [isSelected]);+};+export type TreeItemRenderProps<Data extends { id: string }> = {dropTargetItemId?: string;onMouseEnter?: (item: Data) => void;@@ -282,15 +312,11 @@ export const TreeItemBody = <Data extends { id: string }>({const isDragging = dropTargetItemId !== undefined;const isDropTarget = dropTargetItemId === itemData.id;- // Scroll the selected button into view when selected from canvas.- useEffect(() => {- if (isSelected && isDragging === false && isDropTarget === false) {- itemButtonRef.current?.scrollIntoView({- behavior: "smooth",- block: "nearest",- });- }- }, [isSelected, isDragging, isDropTarget]);+ useScrollIntoView(itemButtonRef.current, {+ isSelected,+ isDragging,+ isDropTarget,+ });return (<ItemContainer