Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

fix: Remove default favicon from exports (#6310)

Oleg Isonene07cb22d2901
diff --git a/fixtures/react-router-cloudflare/public/favicon.ico b/fixtures/react-router-cloudflare/public/favicon.ico
deleted file mode 100644
index 9cb8c815dc..0000000000
Binary files a/fixtures/react-router-cloudflare/public/favicon.ico and /dev/null differ
diff --git a/fixtures/react-router-docker/public/favicon.ico b/fixtures/react-router-docker/public/favicon.ico
deleted file mode 100644
index 9cb8c815dc..0000000000
Binary files a/fixtures/react-router-docker/public/favicon.ico and /dev/null differ
diff --git a/fixtures/react-router-netlify/public/favicon.ico b/fixtures/react-router-netlify/public/favicon.ico
deleted file mode 100644
index 9cb8c815dc..0000000000
Binary files a/fixtures/react-router-netlify/public/favicon.ico and /dev/null differ
diff --git a/fixtures/react-router-vercel/public/favicon.ico b/fixtures/react-router-vercel/public/favicon.ico
deleted file mode 100644
index 9cb8c815dc..0000000000
Binary files a/fixtures/react-router-vercel/public/favicon.ico and /dev/null differ
diff --git a/fixtures/webstudio-cloudflare-template/public/favicon.ico b/fixtures/webstudio-cloudflare-template/public/favicon.ico
deleted file mode 100644
index 9cb8c815dc..0000000000
Binary files a/fixtures/webstudio-cloudflare-template/public/favicon.ico and /dev/null differ
diff --git a/fixtures/webstudio-features/public/favicon.ico b/fixtures/webstudio-features/public/favicon.ico
deleted file mode 100644
index 9cb8c815dc..0000000000
Binary files a/fixtures/webstudio-features/public/favicon.ico and /dev/null differ
diff --git a/packages/cli/src/prebuild.test.ts b/packages/cli/src/prebuild.test.ts
index 2d0303351e..2d113639c9 100644
--- a/packages/cli/src/prebuild.test.ts
+++ b/packages/cli/src/prebuild.test.ts
@@ -783,6 +783,28 @@ test("hydrates encoded filenames from an embedded SSG database", async () => {
});
describe("prebuild", () => {
+ test.each(["defaults", "react-router", "ssg"])(
+ "does not scaffold a default root favicon with the %s template",
+ async (template) => {
+ await writeSiteData(
+ createSiteData({ pageMeta: { faviconAssetId: "asset-image" } })
+ );
+ await prebuild({ assets: false, template: [template] });
+
+ await expect(stat("public/favicon.ico")).rejects.toMatchObject({
+ code: "ENOENT",
+ });
+ await expect(
+ readFile("app/__generated__/_index.tsx", "utf8")
+ ).resolves.toContain('"image.png"');
+ const headPath =
+ template === "ssg" ? "pages/index/+Head.tsx" : "app/routes/_index.tsx";
+ await expect(readFile(headPath, "utf8")).resolves.toContain(
+ template === "ssg" ? 'rel="icon"' : 'rel: "icon"'
+ );
+ }
+ );
+
test("materializes direct MDX Content Blocks into generated page code", async () => {
const source = "# Published from MDX";
const article: AssetFileDocument = {
diff --git a/packages/cli/templates/defaults/public/favicon.ico b/packages/cli/templates/defaults/public/favicon.ico
deleted file mode 100644
index 9cb8c815dc..0000000000
Binary files a/packages/cli/templates/defaults/public/favicon.ico and /dev/null differ
diff --git a/packages/cli/templates/react-router/public/favicon.ico b/packages/cli/templates/react-router/public/favicon.ico
deleted file mode 100644
index 9cb8c815dc..0000000000
Binary files a/packages/cli/templates/react-router/public/favicon.ico and /dev/null differ