Skip to content

Open source website builder and Webflow alternative. Webstudio is an advanced visual builder that connects to any headless CMS, supports all CSS properties, and can be hosted anywhere, including with us.

Allow button children and inner text over properties (#1203)

Oleg Isonenfd7d34d3129b
diff --git a/packages/react-sdk/src/components/__generated__/button.props.ts b/packages/react-sdk/src/components/__generated__/button.props.ts
index d17a5b3d26..875d026a80 100644
--- a/packages/react-sdk/src/components/__generated__/button.props.ts
+++ b/packages/react-sdk/src/components/__generated__/button.props.ts
@@ -452,4 +452,10 @@ export const props: Record<string, PropMeta> = {
control: "text",
type: "string",
},
+ innerText: {
+ required: false,
+ control: "text",
+ type: "string",
+ defaultValue: "Edit Inner Text in Properties",
+ },
};
diff --git a/packages/react-sdk/src/components/button.stories.tsx b/packages/react-sdk/src/components/button.stories.tsx
index c667152ec4..f3a925a87c 100644
--- a/packages/react-sdk/src/components/button.stories.tsx
+++ b/packages/react-sdk/src/components/button.stories.tsx
@@ -11,7 +11,3 @@ const Template: ComponentStory<typeof ButtonPrimitive> = (args) => (
);
export const Button = Template.bind({});
-
-Button.args = {
- children: "Test",
-};
diff --git a/packages/react-sdk/src/components/button.tsx b/packages/react-sdk/src/components/button.tsx
index 1c9ee5b8b2..ff748274fd 100644
--- a/packages/react-sdk/src/components/button.tsx
+++ b/packages/react-sdk/src/components/button.tsx
@@ -2,13 +2,22 @@ import { forwardRef, type ElementRef, type ComponentProps } from "react";
const defaultTag = "button";
-type ButtonProps = ComponentProps<typeof defaultTag>;
+type ButtonProps = ComponentProps<typeof defaultTag> & { innerText?: string };
export const Button = forwardRef<ElementRef<typeof defaultTag>, ButtonProps>(
- (props, ref) => <button {...props} ref={ref} />
+ (
+ {
+ type = "submit",
+ innerText = "Edit Inner Text in Properties",
+ children,
+ ...props
+ },
+ ref
+ ) => (
+ <button type={type} {...props} ref={ref}>
+ {children ? children : innerText}
+ </button>
+ )
);
-Button.defaultProps = {
- type: "submit", // Match the platform default
-};
Button.displayName = "Button";
diff --git a/packages/react-sdk/src/components/button.ws.tsx b/packages/react-sdk/src/components/button.ws.tsx
index fad61bd61d..bd74c22388 100644
--- a/packages/react-sdk/src/components/button.ws.tsx
+++ b/packages/react-sdk/src/components/button.ws.tsx
@@ -3,13 +3,12 @@ import type { WsComponentMeta, WsComponentPropsMeta } from "./component-type";
import { props } from "./__generated__/button.props";
export const meta: WsComponentMeta = {
- type: "rich-text",
+ type: "container",
label: "Button",
Icon: ButtonIcon,
- children: ["Button text you can edit"],
};
export const propsMeta: WsComponentPropsMeta = {
props,
- initialProps: ["type"],
+ initialProps: ["type", "innerText", "aria-label"],
};