Self hosted FLOSS fitness/workout, nutrition and weight tracker
Refuse account deletion during trainer-login sessions
Roland Geider184208360b4e
diff --git a/wger/core/middleware.py b/wger/core/middleware.pyindex 8c42a4728..0aa39118c 100644--- a/wger/core/middleware.py+++ b/wger/core/middleware.py@@ -200,7 +200,8 @@ class TrainerLoginMiddleware:These change how the account is logged into or recovered (email, password,two-factor, social connections), which would outlive the trainer session.- Logging out stays possible.+ Logging out stays possible. Deleting the member's own account is blocked+ as well, trainers can't delete members otherwise."""allowed_url_names = {'account_logout'}@@ -218,4 +219,7 @@ class TrainerLoginMiddleware:return Noneif view_func.__module__.startswith('allauth.'):return HttpResponseForbidden()+ # Both delete routes share the name, only the one without user_pk is the own account+ if request.resolver_match.view_name == 'core:user:delete' and 'user_pk' not in view_kwargs:+ return HttpResponseForbidden()return Nonediff --git a/wger/core/tests/test_trainer_login_account.py b/wger/core/tests/test_trainer_login_account.pyindex 4d0e2a0ab..68638e71d 100644--- a/wger/core/tests/test_trainer_login_account.py+++ b/wger/core/tests/test_trainer_login_account.py@@ -80,6 +80,19 @@ class TrainerLoginAccountManagementTestCase(WgerTestCase):self.member.refresh_from_db()self.assertFalse(self.member.has_usable_password())+ def test_account_can_not_be_deleted(self):+ """+ A member without a usable password (social login) can't be deleted by+ typing the username+ """+ self.member.set_unusable_password()+ self.member.save()+ self.impersonate_member()++ response = self.client.post(reverse('core:user:delete'), {'username': 'test'})+ self.assertEqual(response.status_code, 403)+ self.assertTrue(User.objects.filter(pk=self.member.pk).exists())+def test_logout_still_works(self):"""The session can still be ended