Self hosted FLOSS fitness/workout, nutrition and weight tracker
Properly check that the user owns the measurement category while saving
Roland Geider1fda5690b357
diff --git a/wger/manager/api/views.py b/wger/manager/api/views.pyindex 701d68226..136e94a70 100644--- a/wger/manager/api/views.py+++ b/wger/manager/api/views.py@@ -280,7 +280,7 @@ class WorkoutSessionViewSet(WgerOwnerObjectModelViewSet):"""Return objects to check for ownership permission"""- return [(Routine, 'workout')]+ return [(Routine, 'routine')]class WorkoutLogViewSet(WgerOwnerObjectModelViewSet):diff --git a/wger/measurements/api/views.py b/wger/measurements/api/views.pyindex b3d4dc4f0..2dd3fe340 100644--- a/wger/measurements/api/views.py+++ b/wger/measurements/api/views.py@@ -18,8 +18,11 @@# Standard Libraryimport logging+# Django+from django.contrib.auth.models import User+from django.core.exceptions import PermissionDenied+# Third Party-from rest_framework import viewsetsfrom rest_framework.permissions import IsAuthenticated# wger@@ -32,12 +35,13 @@ from wger.measurements.models import (Category,Measurement,)+from wger.utils.viewsets import WgerOwnerObjectModelViewSetlogger = logging.getLogger(__name__)-class CategoryViewSet(viewsets.ModelViewSet):+class CategoryViewSet(WgerOwnerObjectModelViewSet):"""API endpoint for measurement units"""@@ -64,8 +68,14 @@ class CategoryViewSet(viewsets.ModelViewSet):"""serializer.save(user=self.request.user)+ def get_owner_objects(self):+ """+ Return objects to check for ownership permission+ """+ return [(User, 'user')]+-class MeasurementViewSet(viewsets.ModelViewSet):+class MeasurementViewSet(WgerOwnerObjectModelViewSet):"""API endpoint for measurements"""@@ -76,6 +86,12 @@ class MeasurementViewSet(viewsets.ModelViewSet):ordering_fields = '__all__'filterset_class = MeasurementEntryFilterSet+ def get_owner_objects(self):+ """+ Return objects to check for ownership permission+ """+ return [(Category, 'category')]+def get_queryset(self):"""Only allow access to appropriate objects