Self hosted FLOSS fitness/workout, nutrition and weight tracker
Better classify and handle retriable vs non-retriable errors
Roland Geider46fe0696d0c6
diff --git a/wger/core/api/views.py b/wger/core/api/views.pyindex 84b61f8e6..d40a4d0b3 100644--- a/wger/core/api/views.py+++ b/wger/core/api/views.py@@ -21,6 +21,13 @@ import logging# Djangofrom django.conf import settingsfrom django.contrib.auth.models import User+from django.core.exceptions import ValidationError as DjangoValidationError+from django.db import (+ DataError,+ IntegrityError,+ InterfaceError,+ OperationalError,+)from django.http import (HttpResponseForbidden,JsonResponse,@@ -45,6 +52,7 @@ from rest_framework.decorators import (api_view,permission_classes,)+from rest_framework.exceptions import ValidationError as DRFValidationErrorfrom rest_framework.fields import BooleanFieldfrom rest_framework.permissions import (AllowAny,@@ -395,15 +403,33 @@ def upload_powersync_data(request):logger.warning(f'Received unknown PowerSync table: {table}')return JsonResponse({'error': f'Unknown table: {table}'}, status=200)- # Handlers return either `None` (operation processed successfully) or an- # error dict which we propagate back to the client. The HTTP status stays- # at 200 even on logical errors, since powersync treats non-2xx statuses- # as "retry forever".+ # Handlers return either `None` (processed) or an error dict for a+ # deterministic refusal (validation, FK ownership, etc). We propagate these+ # as 200 + `{error}` since powersync treats a non-2xx status as "retry", so+ # a permanent refusal must stay 200 or the client loops forever.+ #+ # The except ladder classifies transient infrastructure errors as retry (5xx)try:result = handler.dispatch(http_verb, payload=payload, user_id=user_id)++ except (OperationalError, InterfaceError):+ # Transient infrastructure error (deadlock, lock timeout, dropped+ # connection, etc.). Expected to clear on its own, so let the client+ # retry.+ logger.warning(f'Transient DB error for PowerSync table {table}, asking client to retry')+ return JsonResponse({'error': 'Temporarily unavailable'}, status=503)++ except (DjangoValidationError, DRFValidationError, IntegrityError, DataError) as e:+ # Deterministic refusal raised from save() (constraint, model clean,+ # custom create). Retry can't fix it, so reject permanently+ logger.warning(f'PowerSync {table} rejected: {e}')+ return JsonResponse({'error': 'Validation failed', 'details': str(e)}, status=200)+except Exception as e:+ # Unexpected and unclassified. Retry rather than silently drop the write;+ # a failure that persists is a server bug, made visible by these logs.logger.exception(f'Error processing PowerSync data for table {table}')- return JsonResponse({'error': str(e)}, status=200)+ return JsonResponse({'error': str(e)}, status=500)if result is not None:return JsonResponse(result, status=200)diff --git a/wger/core/tests/test_powersync.py b/wger/core/tests/test_powersync.pyindex 5554ba9ff..624440d1e 100644--- a/wger/core/tests/test_powersync.py+++ b/wger/core/tests/test_powersync.py@@ -12,6 +12,16 @@## You should have received a copy of the GNU Affero General Public License+# Standard Library+from unittest import mock++# Django+from django.core.exceptions import ValidationError+from django.db import (+ IntegrityError,+ OperationalError,+)+# Third Partyfrom rest_framework import status@@ -57,3 +67,49 @@ class UserProfilePowerSyncTestCase(self.assertEqual(response.status_code, status.HTTP_200_OK)self.assertEqual(response.json().get('error'), 'Method not allowed')self.assertEqual(UserProfile.objects.count(), before)++ def test_transient_db_error_is_retryable(self):+ """A transient DB error returns 5xx so powersync retries, never 200."""+ self.authenticate()+ with mock.patch(+ 'wger.utils.powersync.PowerSyncHandler.dispatch',+ side_effect=OperationalError('deadlock detected'),+ ):+ response = self.push('PATCH', {'id': self.pk_owned, 'weight_unit': 'lb'})++ self.assertEqual(response.status_code, status.HTTP_503_SERVICE_UNAVAILABLE)++ def test_unexpected_error_is_retryable(self):+ """An unclassified exception returns 5xx, not a silent 200 drop."""+ self.authenticate()+ with mock.patch(+ 'wger.utils.powersync.PowerSyncHandler.dispatch',+ side_effect=RuntimeError('boom'),+ ):+ response = self.push('PATCH', {'id': self.pk_owned, 'weight_unit': 'lb'})++ self.assertEqual(response.status_code, status.HTTP_500_INTERNAL_SERVER_ERROR)++ def test_raised_validation_error_is_permanent(self):+ """A ValidationError escaping save() is a permanent 200 reject, not a retry."""+ self.authenticate()+ with mock.patch(+ 'wger.utils.powersync.PowerSyncHandler.dispatch',+ side_effect=ValidationError('bad value'),+ ):+ response = self.push('PATCH', {'id': self.pk_owned, 'weight_unit': 'lb'})++ self.assertEqual(response.status_code, status.HTTP_200_OK)+ self.assertEqual(response.json().get('error'), 'Validation failed')++ def test_integrity_error_is_permanent(self):+ """A constraint violation can't be fixed by retrying, so it stays 200."""+ self.authenticate()+ with mock.patch(+ 'wger.utils.powersync.PowerSyncHandler.dispatch',+ side_effect=IntegrityError('duplicate key'),+ ):+ response = self.push('PATCH', {'id': self.pk_owned, 'weight_unit': 'lb'})++ self.assertEqual(response.status_code, status.HTTP_200_OK)+ self.assertEqual(response.json().get('error'), 'Validation failed')